From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E515C369AB for ; Tue, 15 Apr 2025 06:51:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C0E268214B; Tue, 15 Apr 2025 08:51:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=dolcini.it header.i=@dolcini.it header.b="AVR+y3Gk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 647D18214D; Tue, 15 Apr 2025 08:51:24 +0200 (CEST) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 92E2682145 for ; Tue, 15 Apr 2025 08:51:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=francesco@dolcini.it Received: from francesco-nb (31-10-206-125.static.upc.ch [31.10.206.125]) by mail11.truemail.it (Postfix) with ESMTPA id 051DE1F917; Tue, 15 Apr 2025 08:51:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1744699880; bh=8ig/P59T6H+IbOdsvoqAcWTPoO4sQ7Oa/EYaSsxISoA=; h=From:To:Subject; b=AVR+y3GkfPMah3Av8XNrz/AkvoEPNNS0YqjOAlZbolZ/c8M47iCvVCjkguTJk7dC+ UuNT91DK66Ty5hY2eF0WH26qLc6ZgghQ7YzyDayI9MpH4Gt/G57v/YPLdIHoxpFp0p lJqiW5RaF16pvxxduX14Gxgddcyc08n4XEZl9PXzQhUl248P3zGN4hdAcPclIjLN7h YbBkv1ndnUQ22VE16WG/Y993sPbgog3wbOxtTHG1sEWNLl1e/ju8BVMDTXG5+YGWpo giqFLZU3ZP+n6z+ZVFhGW2dxSabpqoAIfJ2E77OcaNtIwpHNWUA6pD3yW5WNOnIPNF o81C6o1PMxS7Q== Date: Tue, 15 Apr 2025 08:51:15 +0200 From: Francesco Dolcini To: Neha Malcom Francis , Tom Rini Cc: Francesco Dolcini , Nishanth Menon , Miquel Raynal , Simon Glass , Jaehoon Chung , Lukasz Majewski , Sean Anderson , Anatolij Gustschin , Fabio Estevm , Peng Fan , Mario Six , Svyatoslav Ryhel , Thomas Petazzoni , u-boot@lists.denx.de, Ian Ray , Michael Nazzareno Trimarchi , Dario Binacchi , Adam Ford , Marek Vasut , Udit Kumar Subject: Re: [PATCH v6 05/12] power-domain: Add refcounting Message-ID: <20250415065115.GA10924@francesco-nb> References: <20250403-ge-mainline-display-support-v6-0-478b5e3dd872@bootlin.com> <20250403-ge-mainline-display-support-v6-5-478b5e3dd872@bootlin.com> <7ae54055-7106-47f3-9e99-c7799f84a0f8@ti.com> <20250414180727.5d5zyenfagdc5qw2@unable> <20250414200635.GC5495@bill-the-cat> <20250414210041.GA8754@francesco-nb> <352905ca-4308-4928-9a39-5d9842f1ae9c@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <352905ca-4308-4928-9a39-5d9842f1ae9c@ti.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hello Tom, Neha On Tue, Apr 15, 2025 at 10:50:42AM +0530, Neha Malcom Francis wrote: > > > On 15/04/25 02:30, Francesco Dolcini wrote: > > On Mon, Apr 14, 2025 at 02:06:35PM -0600, Tom Rini wrote: > >> On Mon, Apr 14, 2025 at 01:07:27PM -0500, Nishanth Menon wrote: > >>> On 23:06-20250414, Francis, Neha wrote: > >>>> On 4/3/2025 1:09 PM, Miquel Raynal wrote: > >>>>> It is very surprising that such an uclass, specifically designed to > >>>>> handle resources that may be shared by different devices, is not keeping > >>>>> the count of the number of times a power domain has been > >>>>> enabled/disabled to avoid shutting it down unexpectedly or disabling it > >>>>> several times. > >>>>> > >>>>> Doing this causes troubles on eg. i.MX8MP because disabling power > >>>>> domains can be done in recursive loops were the same power domain > >>>>> disabled up to 4 times in a row. PGCs seem to have tight FSM internal > >>>>> timings to respect and it is easy to produce a race condition that puts > >>>>> the power domains in an unstable state, leading to ADB400 errors and > >>>>> later crashes in Linux. > >>>>> > >>>>> CI tests using power domains are slightly updated to make sure the count > >>>>> of on/off calls is even and the results match what we *now* expect. > >>>>> > >>>>> As we do not want to break existing users while stile getting > >>>>> interesting error codes, the implementation is split between: > >>>>> - a low-level helper reporting error codes if the requested transition > >>>>> could not be operated, > >>>>> - a higher-level helper ignoring the "non error" codes, like EALREADY and > >>>>> EBUSY. > >>>>> > >>>>> Signed-off-by: Miquel Raynal > >>>>> --- > >>>> > >>>> This commit looks to be breaking K3 platforms boot, please see "Latest Boot > >>>> Summary" [0]. Reverting the commit fixes boot. > >>>> > >>>> [0] https://lcpd.itg.ti.com/upstream/k3-boot-build/main/build-trends.html > > My bad on the internal link. > > >>> > >>> Uggh. This link is a TI internal link. Nutshell, it is broken > >>> between: > >>> v2025.04-921-gcb7555e93075 : https://source.denx.de/u-boot/u-boot.git > >>> and > >>> v2025.04-1041-g407d68638fe3 : https://source.denx.de/u-boot/u-boot.git > >>> > >>> Neha bisected it down to 197376fbf300e92afa0a1583815d9c9eb52d613a commit > >>> which is this patch. > >> > >> And assuming it's the same failure I got reported this morning by one of > >> my coworkers, we just get: > >> U-Boot SPL 2025.04-01050-ga40fc5afaec0 (Apr 14 2025 - 07:31:32 +0000) > >> SYSFW ABI: 3.1 (firmware rev 0x0009 '9.2.7--v09.02.07 (Kool Koala)') > > This is not the failure I am seeing, we hang before console comes up so > no prints. Looks like the different failure signature is due to TIFS > (SYSFW) firmware being different (v9.2.7 vs. 11.0.4) To me it was failing freezing just after this U-Boot SPL 2025.04-01076-g739ad58dbee8 (Apr 14 2025 - 17:23:46 +0200) SYSFW ABI: 4.0 (firmware rev 0x000b '11.0.7--v11.00.07 (Fancy Rat)') and, with commit 197376fbf300 ("power-domain: Add refcounting") reverted the issue is fixed and I get to the U-Boot command line. Francesco