From: ant.v.moryakov@gmail.com
To: u-boot@lists.denx.de
Cc: Maks Mishin <maks.mishinFZ@gmail.com>
Subject: [PATCH] tools: image-host: Fix potential memory leak
Date: Fri, 18 Apr 2025 11:19:58 +0300 [thread overview]
Message-ID: <20250418081958.12818-4-ant.v.moryakov@gmail.com> (raw)
In-Reply-To: <20250418081958.12818-1-ant.v.moryakov@gmail.com>
From: Maks Mishin <maks.mishinFZ@gmail.com>
Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
---
tools/image-host.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/image-host.c b/tools/image-host.c
index 4a24dee8..6b17b810 100644
--- a/tools/image-host.c
+++ b/tools/image-host.c
@@ -1024,10 +1024,13 @@ static int fit_config_process_sig(const char *keydir, const char *keyfile,
int ret;
node_name = fit_get_name(fit, noffset, NULL);
- if (fit_config_get_regions(fit, conf_noffset, noffset, ®ion,
+ ret = fit_config_get_regions(fit, conf_noffset, noffset, ®ion,
®ion_count, ®ion_prop,
- ®ion_proplen))
+ ®ion_proplen);
+ if (ret) {
+ free(region_prop);
return -1;
+ }
if (fit_image_setup_sig(&info, keydir, keyfile, fit, conf_name, noffset,
require_keys ? "conf" : NULL, engine_id,
--
2.34.1
next prev parent reply other threads:[~2025-04-18 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 8:19 [PATCH] scripts: Fix potential null-deref ant.v.moryakov
2025-04-18 8:19 ` [PATCH] tools: Fix memory and descriptor leak ant.v.moryakov
2025-04-18 13:51 ` Quentin Schulz
2025-04-18 8:19 ` [PATCH] tools: Fix potential memory leak in aisimage.c ant.v.moryakov
2025-04-18 13:52 ` Quentin Schulz
2025-04-18 8:19 ` ant.v.moryakov [this message]
2025-04-18 13:52 ` [PATCH] tools: image-host: Fix potential memory leak Quentin Schulz
2025-04-18 13:51 ` [PATCH] scripts: Fix potential null-deref Quentin Schulz
2025-04-18 14:18 ` Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2025-04-18 8:30 [PATCH] tools: image-host: Fix potential memory leak ant.v.moryakov
2025-04-18 13:52 ` Quentin Schulz
2025-04-18 8:32 ant.v.moryakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250418081958.12818-4-ant.v.moryakov@gmail.com \
--to=ant.v.moryakov@gmail.com \
--cc=maks.mishinFZ@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox