U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@kernel.org>
To: u-boot@lists.denx.de
Cc: Chen-Yu Tsai <wens@csie.org>, Andy Yan <andyshrk@163.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Kever Yang <kever.yang@rock-chips.com>,
	Maksim Kiselev <bigunclemax@gmail.com>,
	Nathan Barrett-Morrison <nathan.morrison@timesys.com>,
	Peng Fan <peng.fan@nxp.com>,
	Peter Robinson <pbrobinson@gmail.com>,
	Quentin Schulz <quentin.schulz@cherry.de>,
	Raymond Mao <raymond.mao@linaro.org>,
	Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>,
	Vasileios Bimpikas <vasileios.bimpikas@analog.com>
Subject: [PATCH 1/2] mmc: rockchip_dw_mmc: Enable by default for all supported SoCs
Date: Wed, 30 Apr 2025 01:41:24 +0800	[thread overview]
Message-ID: <20250429174125.2194499-1-wens@kernel.org> (raw)

From: Chen-Yu Tsai <wens@csie.org>

The rockchip_dw_mmc driver supports the MMC controller found in Rockchip
SoCs. This controller is used for the SD card on all SoCs and eMMC on
older SoCs. Almost all defconfigs for Rockchip platforms have this
enabled.

Enable it by default for all supported Rockchip SoCs. Disable it
explicitly in defconfigs that previously didn't have it enabled. Of
these, only the Cool Pi GenBook w/ CM5 doesn't actually use the
controller. The other two, the Geekbox and the RV1108 EVB, both have
MMC enabled in their device trees. With this patch, they will gain
support for MMC automatically.

Also limit the driver to Rockchip platforms only, like what is done for
the other dw_mmc platform glue drivers.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---

Changes in v2:
- Made CONFIG_MMC_DW_ROCKCHIP depend on ARCH_ROCKCHIP

 configs/coolpi-cm5-genbook-rk3588_defconfig | 1 +
 drivers/mmc/Kconfig                         | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/configs/coolpi-cm5-genbook-rk3588_defconfig b/configs/coolpi-cm5-genbook-rk3588_defconfig
index 3eb5dc968af6..92676ebb984a 100644
--- a/configs/coolpi-cm5-genbook-rk3588_defconfig
+++ b/configs/coolpi-cm5-genbook-rk3588_defconfig
@@ -65,6 +65,7 @@ CONFIG_MMC_HS400_ES_SUPPORT=y
 CONFIG_SPL_MMC_HS400_ES_SUPPORT=y
 CONFIG_MMC_HS400_SUPPORT=y
 CONFIG_SPL_MMC_HS400_SUPPORT=y
+# CONFIG_MMC_DW is not set
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_SDMA=y
 CONFIG_MMC_SDHCI_ROCKCHIP=y
diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
index 6740591a6533..ec9e9d51fbf9 100644
--- a/drivers/mmc/Kconfig
+++ b/drivers/mmc/Kconfig
@@ -251,6 +251,7 @@ config MMC_DAVINCI
 config MMC_DW
 	bool "Synopsys DesignWare Memory Card Interface"
 	select BOUNCE_BUFFER
+	default y if ARCH_ROCKCHIP
 	help
 	  This selects support for the Synopsys DesignWare Mobile Storage IP
 	  block, this provides host support for SD and MMC interfaces, in both
@@ -286,6 +287,8 @@ config MMC_DW_ROCKCHIP
 	bool "Rockchip SD/MMC controller support"
 	depends on OF_CONTROL
 	depends on MMC_DW
+	depends on ARCH_ROCKCHIP
+	default y
 	help
 	  This enables support for the Rockchip SD/MMM controller, which is
 	  based on Designware IP. The device is compatible with at least
-- 
2.39.5


             reply	other threads:[~2025-04-29 17:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 17:41 Chen-Yu Tsai [this message]
2025-04-29 17:41 ` [PATCH 2/2] mmc: rockchip_sdhci: Enable by default for all supported SoCs Chen-Yu Tsai
2025-04-29 17:42 ` [PATCH 1/2] mmc: rockchip_dw_mmc: " Chen-Yu Tsai
  -- strict thread matches above, loose matches on Subject: below --
2025-04-29 15:44 Chen-Yu Tsai
2025-04-29 16:30 ` Quentin Schulz
2025-04-29 16:51   ` Tom Rini
2025-04-29 17:34   ` Chen-Yu Tsai
2025-04-29 17:40     ` Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250429174125.2194499-1-wens@kernel.org \
    --to=wens@kernel.org \
    --cc=andyshrk@163.com \
    --cc=bigunclemax@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=jonas@kwiboo.se \
    --cc=kever.yang@rock-chips.com \
    --cc=nathan.morrison@timesys.com \
    --cc=pbrobinson@gmail.com \
    --cc=peng.fan@nxp.com \
    --cc=quentin.schulz@cherry.de \
    --cc=raymond.mao@linaro.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vasileios.bimpikas@analog.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox