From: Peng Fan <peng.fan@oss.nxp.com>
To: Andrew Goodbody <andrew.goodbody@linaro.org>
Cc: Peng Fan <peng.fan@nxp.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Tom Rini <trini@konsulko.com>, Tim Harvey <tharvey@gateworks.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH] mmc: Take cleanup path to free memory on error exit
Date: Mon, 7 Jul 2025 16:47:11 +0800 [thread overview]
Message-ID: <20250707084711.GD11488@nxa18884-linux> (raw)
In-Reply-To: <20250703-mmc_driver_fix-v1-1-4fc57fded698@linaro.org>
On Thu, Jul 03, 2025 at 03:03:30PM +0100, Andrew Goodbody wrote:
>Instead of returning -EINVAL directly which will not call the cleanup
>path to free memory, fix the code to set the error and then goto the
>cleanup code.
>
>This issue found by Smatch.
>
>Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
prev parent reply other threads:[~2025-07-07 7:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 14:03 [PATCH] mmc: Take cleanup path to free memory on error exit Andrew Goodbody
2025-07-07 8:47 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707084711.GD11488@nxa18884-linux \
--to=peng.fan@oss.nxp.com \
--cc=andrew.goodbody@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=peng.fan@nxp.com \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox