u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] PHYTEC imx8m boards: enable OP-TEE as default
@ 2025-08-14 12:05 Yannic Moog
  2025-08-14 12:05 ` [PATCH v2 1/2] phytec-imx8m boards: enable OP-TEE for KASLR Yannic Moog
  2025-08-14 12:05 ` [PATCH v2 2/2] doc: phytec: update imx8m docs for optee builds Yannic Moog
  0 siblings, 2 replies; 5+ messages in thread
From: Yannic Moog @ 2025-08-14 12:05 UTC (permalink / raw)
  To: Tom Rini, Fabio Estevam, Teresa Remmet
  Cc: u-boot, upstream, Benjamin Hahn, Yashwanth Varakala, Jan Remmet,
	Yannic Moog

OPTEE config was unset by default and the doc for the boards was not
quite accurate as TEE configs must be enabled first in order to be able
to build with OP-TEE support.
This series enables the config by default, i.e. when wanting to build
without OP-TEE now, configs need to be modified.
Update and clean up the documentation:
Change instructions on how to build bootable image with the new OP-TEE
related changes.

---
Changes in v2:
- Use proper board PLATFORM for OP-TEE since boards have been merged to
  master on optee_os (https://github.com/OP-TEE/optee_os/pull/7487)
- add -j $(nproc) to make commands
- Link to v1: https://lore.kernel.org/r/20250813-imx8m-optee-enable-v1-0-bbff23f047e5@phytec.de

---
Yannic Moog (2):
      phytec-imx8m boards: enable OP-TEE for KASLR
      doc: phytec: update imx8m docs for optee builds

 board/phytec/phycore_imx8mm/MAINTAINERS     |  1 -
 configs/imx8mm-phygate-tauri-l_defconfig    |  5 +++-
 configs/phycore-imx8mm_defconfig            |  5 +++-
 configs/phycore-imx8mp_defconfig            |  4 +++
 doc/board/phytec/imx8mm-optee-build.rsti    | 14 ----------
 doc/board/phytec/imx8mm-phygate-tauri-l.rst | 42 ++++++++++++++++++----------
 doc/board/phytec/phycore-imx8mm.rst         | 43 +++++++++++++++++++----------
 doc/board/phytec/phycore-imx8mp.rst         | 41 ++++++++++++++-------------
 8 files changed, 91 insertions(+), 64 deletions(-)
---
base-commit: b6e2cfca1a6fd10c8f12016a40d690d2ec61796c
change-id: 20250730-imx8m-optee-enable-dd28b305167e

Best regards,
-- 
Yannic Moog <y.moog@phytec.de>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] phytec-imx8m boards: enable OP-TEE for KASLR
  2025-08-14 12:05 [PATCH v2 0/2] PHYTEC imx8m boards: enable OP-TEE as default Yannic Moog
@ 2025-08-14 12:05 ` Yannic Moog
  2025-09-02  7:16   ` Teresa Remmet
  2025-08-14 12:05 ` [PATCH v2 2/2] doc: phytec: update imx8m docs for optee builds Yannic Moog
  1 sibling, 1 reply; 5+ messages in thread
From: Yannic Moog @ 2025-08-14 12:05 UTC (permalink / raw)
  To: Tom Rini, Fabio Estevam, Teresa Remmet
  Cc: u-boot, upstream, Benjamin Hahn, Yashwanth Varakala, Jan Remmet,
	Yannic Moog

Enable OP-TEE config and RNG by default.
Set OP-TEE load address to end of 1GiB RAM for phycore-imx8mp as the
board is supported in a 1GiB RAM variant.
For the imx8mm boards, only 2GiB versions are supported, so the default
at the end of 2GiB is sufficient.

Signed-off-by: Yannic Moog <y.moog@phytec.de>
---
 configs/imx8mm-phygate-tauri-l_defconfig | 5 ++++-
 configs/phycore-imx8mm_defconfig         | 5 ++++-
 configs/phycore-imx8mp_defconfig         | 4 ++++
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/configs/imx8mm-phygate-tauri-l_defconfig b/configs/imx8mm-phygate-tauri-l_defconfig
index 7369c0a05ac98315682127f0e96af7d36c4763d2..6dc95d6d3edbc0b4ed25a66d23f1b65435e01697 100644
--- a/configs/imx8mm-phygate-tauri-l_defconfig
+++ b/configs/imx8mm-phygate-tauri-l_defconfig
@@ -73,9 +73,9 @@ CONFIG_SPL_CLK_COMPOSITE_CCF=y
 CONFIG_CLK_COMPOSITE_CCF=y
 CONFIG_SPL_CLK_IMX8MM=y
 CONFIG_CLK_IMX8MM=y
+CONFIG_FSL_CAAM=y
 CONFIG_MXC_GPIO=y
 CONFIG_DM_I2C=y
-CONFIG_MISC=y
 CONFIG_I2C_EEPROM=y
 CONFIG_SYS_I2C_EEPROM_ADDR=0x51
 CONFIG_SUPPORT_EMMC_BOOT=y
@@ -97,11 +97,14 @@ CONFIG_IMX8M_POWER_DOMAIN=y
 CONFIG_DM_REGULATOR=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_RNG=y
 CONFIG_DM_SERIAL=y
 CONFIG_MXC_UART=y
 CONFIG_SYSRESET=y
 CONFIG_SPL_SYSRESET=y
 CONFIG_SYSRESET_PSCI=y
 CONFIG_SYSRESET_WATCHDOG=y
+CONFIG_TEE=y
+CONFIG_OPTEE=y
 CONFIG_DM_THERMAL=y
 CONFIG_IMX_WATCHDOG=y
diff --git a/configs/phycore-imx8mm_defconfig b/configs/phycore-imx8mm_defconfig
index 4d6bce26f07f7b90e7c3674f4b9ddcac8d775e1d..4cf4d3972567bcf77d9ee7e2fda707070a778c72 100644
--- a/configs/phycore-imx8mm_defconfig
+++ b/configs/phycore-imx8mm_defconfig
@@ -82,9 +82,9 @@ CONFIG_SPL_CLK_COMPOSITE_CCF=y
 CONFIG_CLK_COMPOSITE_CCF=y
 CONFIG_SPL_CLK_IMX8MM=y
 CONFIG_CLK_IMX8MM=y
+CONFIG_FSL_CAAM=y
 CONFIG_MXC_GPIO=y
 CONFIG_DM_I2C=y
-CONFIG_MISC=y
 CONFIG_I2C_EEPROM=y
 CONFIG_SYS_I2C_EEPROM_ADDR=0x51
 CONFIG_SUPPORT_EMMC_BOOT=y
@@ -120,6 +120,7 @@ CONFIG_POWER_DOMAIN=y
 CONFIG_IMX8M_POWER_DOMAIN=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_RNG=y
 CONFIG_DM_SERIAL=y
 CONFIG_MXC_UART=y
 CONFIG_SPI=y
@@ -129,5 +130,7 @@ CONFIG_SYSRESET=y
 CONFIG_SPL_SYSRESET=y
 CONFIG_SYSRESET_PSCI=y
 CONFIG_SYSRESET_WATCHDOG=y
+CONFIG_TEE=y
+CONFIG_OPTEE=y
 CONFIG_DM_THERMAL=y
 CONFIG_IMX_WATCHDOG=y
diff --git a/configs/phycore-imx8mp_defconfig b/configs/phycore-imx8mp_defconfig
index 6bd8bcf15daa95966aa973d8a493ebc1f05b14e9..c497f0bcd9131abab0b751ec9cc81194405b1f19 100644
--- a/configs/phycore-imx8mp_defconfig
+++ b/configs/phycore-imx8mp_defconfig
@@ -13,6 +13,7 @@ CONFIG_ENV_SECT_SIZE=0x10000
 CONFIG_SYS_I2C_MXC_I2C1=y
 CONFIG_DM_GPIO=y
 CONFIG_DEFAULT_DEVICE_TREE="freescale/imx8mp-phyboard-pollux-rdk"
+CONFIG_IMX8M_OPTEE_LOAD_ADDR=0x7e000000
 CONFIG_TARGET_PHYCORE_IMX8MP=y
 CONFIG_OF_LIBFDT_OVERLAY=y
 CONFIG_SYS_MONITOR_LEN=524288
@@ -153,6 +154,7 @@ CONFIG_DM_REGULATOR=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
 CONFIG_SPL_POWER_I2C=y
+CONFIG_DM_RNG=y
 CONFIG_DM_SERIAL=y
 CONFIG_MXC_UART=y
 CONFIG_SPI=y
@@ -162,6 +164,8 @@ CONFIG_SYSRESET=y
 CONFIG_SPL_SYSRESET=y
 CONFIG_SYSRESET_PSCI=y
 CONFIG_SYSRESET_WATCHDOG=y
+CONFIG_TEE=y
+CONFIG_OPTEE=y
 CONFIG_DM_THERMAL=y
 CONFIG_USB=y
 CONFIG_DM_USB_GADGET=y

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] doc: phytec: update imx8m docs for optee builds
  2025-08-14 12:05 [PATCH v2 0/2] PHYTEC imx8m boards: enable OP-TEE as default Yannic Moog
  2025-08-14 12:05 ` [PATCH v2 1/2] phytec-imx8m boards: enable OP-TEE for KASLR Yannic Moog
@ 2025-08-14 12:05 ` Yannic Moog
  2025-09-02  7:25   ` Teresa Remmet
  1 sibling, 1 reply; 5+ messages in thread
From: Yannic Moog @ 2025-08-14 12:05 UTC (permalink / raw)
  To: Tom Rini, Fabio Estevam, Teresa Remmet
  Cc: u-boot, upstream, Benjamin Hahn, Yashwanth Varakala, Jan Remmet,
	Yannic Moog

OP-TEE configs are enabled by default, change the doc to no longer
declare OP-TEE as optional.
Further, phycore-imx8mm and imx8mm-phygate-tauri-l use different build
instructions, so dissolve the common file for building OP-TEE.
While at it, introduce style changes where export commands are no longer
used.

Signed-off-by: Yannic Moog <y.moog@phytec.de>
---
 board/phytec/phycore_imx8mm/MAINTAINERS     |  1 -
 doc/board/phytec/imx8mm-optee-build.rsti    | 14 ----------
 doc/board/phytec/imx8mm-phygate-tauri-l.rst | 42 ++++++++++++++++++----------
 doc/board/phytec/phycore-imx8mm.rst         | 43 +++++++++++++++++++----------
 doc/board/phytec/phycore-imx8mp.rst         | 41 ++++++++++++++-------------
 5 files changed, 79 insertions(+), 62 deletions(-)

diff --git a/board/phytec/phycore_imx8mm/MAINTAINERS b/board/phytec/phycore_imx8mm/MAINTAINERS
index 7631e1cb331b608335620d0db49104459f673d1d..58c5e2d0af9fe404a5995fecc96cdbaa5845f979 100644
--- a/board/phytec/phycore_imx8mm/MAINTAINERS
+++ b/board/phytec/phycore_imx8mm/MAINTAINERS
@@ -9,6 +9,5 @@ F:	configs/imx8mm-phygate-tauri-l_defconfig
 F:      configs/phycore-imx8mm_defconfig
 F:	doc/board/phytec/imx8mm-phygate-tauri-l.rst
 F:	doc/board/phytec/index.rst
-F:	doc/board/phytec/imx8mm-optee-build.rsti
 F:	doc/board/phytec/phycore_imx8mm.rst
 F:      include/configs/phycore_imx8mm.h
diff --git a/doc/board/phytec/imx8mm-optee-build.rsti b/doc/board/phytec/imx8mm-optee-build.rsti
deleted file mode 100644
index c83de5cc7cf4a0229cbd89f4c7d2bfd8448cb735..0000000000000000000000000000000000000000
--- a/doc/board/phytec/imx8mm-optee-build.rsti
+++ /dev/null
@@ -1,14 +0,0 @@
-Build the OP-TEE binary (optional)
-----------------------------------
-
-.. code-block:: bash
-
-   $ git clone https://github.com/OP-TEE/optee_os.git
-   $ cd optee_os
-   $ make CFG_TEE_BENCHMARK=n \
-     CROSS_COMPILE=aarch64-linux-gnu- \
-     O=out/arm \
-     PLATFORM=imx-mx8mmevk \
-     CFG_TZDRAM_START=0x56000000 \
-     CFG_DDR_SIZE=0x80000000 \
-     CFG_UART_BASE=UART3_BASE
diff --git a/doc/board/phytec/imx8mm-phygate-tauri-l.rst b/doc/board/phytec/imx8mm-phygate-tauri-l.rst
index 0d9e1024f8c5300e91a3a4c18b2babd5853a0824..4dd82cd9785fa585ed216664a25f593d4e723dbb 100644
--- a/doc/board/phytec/imx8mm-phygate-tauri-l.rst
+++ b/doc/board/phytec/imx8mm-phygate-tauri-l.rst
@@ -9,7 +9,7 @@ Quick Start
 -----------
 
 - Build the ARM Trusted firmware binary
-- Build the OP-TEE binary (optional)
+- Build the OP-TEE binary
 - Get ddr firmware
 - Build U-Boot
 - Boot
@@ -21,23 +21,35 @@ Build the ARM Trusted firmware binary
 
    $ git clone https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git
    $ cd trusted-firmware-a
-   $ export CROSS_COMPILE=aarch64-linux-gnu-
-   $ export IMX_BOOT_UART_BASE=0x30880000
-   $ # with optee
-   $ make PLAT=imx8mm BL32_BASE=0x56000000 SPD=opteed bl31
-   $ # without optee
-   $ make PLAT=imx8mm bl31
+   $ make -j $(nproc) \
+          CROSS_COMPILE=aarch64-linux-gnu- \
+          PLAT=imx8mm \
+          IMX_BOOT_UART_BASE=0x30880000 \
+          BL32_BASE=0xbe000000 \
+          SPD=opteed \
+          bl31
 
-.. include:: imx8mm-optee-build.rsti
+Build the OP-TEE binary
+-----------------------
+
+.. code-block:: bash
+
+   $ git clone https://github.com/OP-TEE/optee_os.git
+   $ cd optee_os
+   $ make -j $(nproc) \
+          CROSS_COMPILE=aarch64-linux-gnu- \
+          CFG_TEE_BENCHMARK=n \
+          O=out/arm \
+          PLATFORM=imx-mx8mm_phygate_tauri_l
 
 Get the ddr firmware
 --------------------
 
 .. code-block:: bash
 
-   $ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.23.bin
-   $ chmod +x firmware-imx-8.23.bin
-   $ ./firmware-imx-8.23.bin
+   $ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.28-994fa14.bin
+   $ chmod +x firmware-imx-8.28-994fa14.bin
+   $ ./firmware-imx-8.28-994fa14.bin
 
 Build U-Boot for SD card
 ------------------------
@@ -49,15 +61,17 @@ Copy binaries
 
    $ cp <TF-A dir>/build/imx8mm/release/bl31.bin .
    $ cp <OP-TEE dir>/out/arm/core/tee-raw.bin tee.bin
-   $ cp firmware-imx-8.23/firmware/ddr/synopsys/lpddr4*.bin .
+   $ cp firmware-imx-8.28-994fa14/firmware/ddr/synopsys/lpddr4*.bin .
 
 Build U-Boot
 ^^^^^^^^^^^^
 
 .. code-block:: bash
 
-   $ make imx8mm-phygate-tauri-l_defconfig
-   $ make flash.bin
+   $ make -j $(nproc)
+          CROSS_COMPILE=aarch64-linux-gnu- \
+          imx8mm-phygate-tauri-l_defconfig \
+          flash.bin
 
 Flash SD card
 ^^^^^^^^^^^^^
diff --git a/doc/board/phytec/phycore-imx8mm.rst b/doc/board/phytec/phycore-imx8mm.rst
index 08f5949e02d8d2bfba71867d93c2b3ed8fdc67e2..d5edbc91474e95f677dd12e5fcc6c16092dea1cd 100644
--- a/doc/board/phytec/phycore-imx8mm.rst
+++ b/doc/board/phytec/phycore-imx8mm.rst
@@ -9,7 +9,7 @@ Quick Start
 -----------
 
 - Build the ARM Trusted firmware binary
-- Build the OP-TEE binary (optional)
+- Build the OP-TEE binary
 - Get ddr firmware
 - Build U-Boot
 - Boot
@@ -21,23 +21,35 @@ Build the ARM Trusted firmware binary
 
    $ git clone https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git
    $ cd trusted-firmware-a
-   $ export CROSS_COMPILE=aarch64-linux-gnu-
-   $ export IMX_BOOT_UART_BASE=0x30880000
-   $ # with optee
-   $ make PLAT=imx8mm BL32_BASE=0x56000000 SPD=opteed bl31
-   $ # without optee
-   $ make PLAT=imx8mm bl31
+   $ make -j $(nproc) \
+          CROSS_COMPILE=aarch64-linux-gnu- \
+          PLAT=imx8mm \
+          IMX_BOOT_UART_BASE=0x30880000 \
+          BL32_BASE=0x7e000000 \
+          SPD=opteed \
+          bl31
 
-.. include:: imx8mm-optee-build.rsti
+Build the OP-TEE binary
+-----------------------
+
+.. code-block:: bash
+
+   $ git clone https://github.com/OP-TEE/optee_os.git
+   $ cd optee_os
+   $ make -j $(nproc) \
+          CROSS_COMPILE=aarch64-linux-gnu- \
+          CFG_TEE_BENCHMARK=n \
+          O=out/arm \
+          PLATFORM=imx-mx8mm_phyboard_polis
 
 Get the ddr firmware
 --------------------
 
 .. code-block:: bash
 
-   $ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.19.bin
-   $ chmod +x firmware-imx-8.19.bin
-   $ ./firmware-imx-8.19.bin
+   $ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.28-994fa14.bin
+   $ chmod +x firmware-imx-8.28-994fa14.bin
+   $ ./firmware-imx-8.28-994fa14.bin
 
 Build U-Boot for SD card
 ------------------------
@@ -48,15 +60,18 @@ Copy binaries
 .. code-block:: bash
 
    $ cp <TF-A dir>/build/imx8mm/release/bl31.bin .
-   $ cp firmware-imx-8.19/firmware/ddr/synopsys/lpddr4*.bin .
+   $ cp <OP-TEE dir>/out/arm/core/tee-raw.bin tee.bin
+   $ cp firmware-imx-8.28-994fa14/firmware/ddr/synopsys/lpddr4*.bin .
 
 Build U-Boot
 ^^^^^^^^^^^^
 
 .. code-block:: bash
 
-   $ make phycore-imx8mm_defconfig
-   $ make flash.bin
+   $ make -j $(nproc) \
+          CROSS_COMPILE=aarch64-linux-gnu- \
+          phycore-imx8mm_defconfig \
+          flash.bin
 
 Flash SD card
 ^^^^^^^^^^^^^
diff --git a/doc/board/phytec/phycore-imx8mp.rst b/doc/board/phytec/phycore-imx8mp.rst
index 50be99126537a2dc5323bd49c1513b196182c5f3..cea3a2835e69d6c6d3aa4c16698aebd09f73bf49 100644
--- a/doc/board/phytec/phycore-imx8mp.rst
+++ b/doc/board/phytec/phycore-imx8mp.rst
@@ -3,13 +3,13 @@
 phyCORE-i.MX 8M Plus
 ====================
 
-The phyCORE-i.MX 8M Plus with 2GB of main memory is supported.
+The phyCORE-i.MX 8M Plus with 1,2,4GB of main memory is supported.
 
 Quick Start
 -----------
 
 - Build the ARM Trusted firmware binary
-- Build the OP-TEE binary (optional)
+- Build the OP-TEE binary
 - Get ddr firmware
 - Build U-Boot
 - Boot
@@ -21,12 +21,13 @@ Build the ARM Trusted firmware binary
 
    $ git clone https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git
    $ cd trusted-firmware-a
-   $ export CROSS_COMPILE=aarch64-linux-gnu-
-   $ export IMX_BOOT_UART_BASE=0x30860000
-   $ # with optee
-   $ make PLAT=imx8mp SPD=opteed bl31
-   $ # without optee
-   $ make PLAT=imx8mp bl31
+   $ make -j $(nproc) \
+          CROSS_COMPILE=aarch64-linux-gnu- \
+          PLAT=imx8mp \
+          IMX_BOOT_UART_BASE=0x30860000 \
+          BL32_BASE=0x7e000000 \
+          SPD=opteed \
+          bl31
 
 Build the OP-TEE binary (optional)
 ----------------------------------
@@ -35,20 +36,20 @@ Build the OP-TEE binary (optional)
 
    $ git clone https://github.com/OP-TEE/optee_os.git
    $ cd optee_os
-   $ make CFG_TEE_BENCHMARK=n \
-     CROSS_COMPILE=aarch64-linux-gnu- \
-     O=out/arm \
-     PLATFORM=imx-mx8mp_phyboard_pollux \
-     CFG_TZDRAM_START=0x56000000
+   $ make -j $(nproc) \
+          CROSS_COMPILE=aarch64-linux-gnu- \
+          CFG_TEE_BENCHMARK=n \
+          O=out/arm \
+          PLATFORM=imx-mx8mp_phyboard_pollux
 
 Get the ddr firmware
 --------------------
 
 .. code-block:: bash
 
-   $ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.19.bin
-   $ chmod +x firmware-imx-8.19.bin
-   $ ./firmware-imx-8.19.bin
+   $ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.28-994fa14.bin
+   $ chmod +x firmware-imx-8.28-994fa14.bin
+   $ ./firmware-imx-8.28-994fa14.bin
 
 Build U-Boot for SD card
 ------------------------
@@ -60,15 +61,17 @@ Copy binaries
 
    $ cp <TF-A dir>/build/imx8mp/release/bl31.bin .
    $ cp <OP-TEE dir>/out/arm/core/tee-raw.bin tee.bin
-   $ cp firmware-imx-8.19/firmware/ddr/synopsys/lpddr4*.bin .
+   $ cp firmware-imx-8.28-994fa14/firmware/ddr/synopsys/lpddr4*.bin .
 
 Build U-Boot
 ^^^^^^^^^^^^
 
 .. code-block:: bash
 
-   $ make phycore-imx8mp_defconfig
-   $ make flash.bin
+   $ make -j $(nproc) \
+          CROSS_COMPILE=aarch64-linux-gnu- \
+          phycore-imx8mp_defconfig \
+          flash.bin
 
 Flash SD card
 ^^^^^^^^^^^^^

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] phytec-imx8m boards: enable OP-TEE for KASLR
  2025-08-14 12:05 ` [PATCH v2 1/2] phytec-imx8m boards: enable OP-TEE for KASLR Yannic Moog
@ 2025-09-02  7:16   ` Teresa Remmet
  0 siblings, 0 replies; 5+ messages in thread
From: Teresa Remmet @ 2025-09-02  7:16 UTC (permalink / raw)
  To: festevam@gmail.com, trini@konsulko.com, Yannic Moog
  Cc: upstream@lists.phytec.de, u-boot@lists.denx.de, Jan Remmet,
	Benjamin Hahn, Yashwanth Varakala

Hello Yannic

Am Donnerstag, dem 14.08.2025 um 14:05 +0200 schrieb Yannic Moog:
> Enable OP-TEE config and RNG by default.
> Set OP-TEE load address to end of 1GiB RAM for phycore-imx8mp as the
> board is supported in a 1GiB RAM variant.
> For the imx8mm boards, only 2GiB versions are supported, so the
> default
> at the end of 2GiB is sufficient.

sorry for the late review.
When looking at the phycore-imx8mm_defconfig I can see that
CONFIG_IMX8M_OPTEE_LOAD_ADDR is set here to 0x7e000000. 
See commit e6e8c601ed78 ("board: phytec: migrate imx8mm boards to
standard boot")
So at the end of 1GiB likewise to phyCORE-i.MX8MP and not what your
commit message says.
For tauri the default is used (end of 2GiB).
Can you please check?

Kind Regards,
Teresa

> 
> Signed-off-by: Yannic Moog <y.moog@phytec.de>
> ---
>  configs/imx8mm-phygate-tauri-l_defconfig | 5 ++++-
>  configs/phycore-imx8mm_defconfig         | 5 ++++-
>  configs/phycore-imx8mp_defconfig         | 4 ++++
>  3 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/imx8mm-phygate-tauri-l_defconfig
> b/configs/imx8mm-phygate-tauri-l_defconfig
> index
> 7369c0a05ac98315682127f0e96af7d36c4763d2..6dc95d6d3edbc0b4ed25a66d23f
> 1b65435e01697 100644
> --- a/configs/imx8mm-phygate-tauri-l_defconfig
> +++ b/configs/imx8mm-phygate-tauri-l_defconfig
> @@ -73,9 +73,9 @@ CONFIG_SPL_CLK_COMPOSITE_CCF=y
>  CONFIG_CLK_COMPOSITE_CCF=y
>  CONFIG_SPL_CLK_IMX8MM=y
>  CONFIG_CLK_IMX8MM=y
> +CONFIG_FSL_CAAM=y
>  CONFIG_MXC_GPIO=y
>  CONFIG_DM_I2C=y
> -CONFIG_MISC=y
>  CONFIG_I2C_EEPROM=y
>  CONFIG_SYS_I2C_EEPROM_ADDR=0x51
>  CONFIG_SUPPORT_EMMC_BOOT=y
> @@ -97,11 +97,14 @@ CONFIG_IMX8M_POWER_DOMAIN=y
>  CONFIG_DM_REGULATOR=y
>  CONFIG_DM_REGULATOR_FIXED=y
>  CONFIG_DM_REGULATOR_GPIO=y
> +CONFIG_DM_RNG=y
>  CONFIG_DM_SERIAL=y
>  CONFIG_MXC_UART=y
>  CONFIG_SYSRESET=y
>  CONFIG_SPL_SYSRESET=y
>  CONFIG_SYSRESET_PSCI=y
>  CONFIG_SYSRESET_WATCHDOG=y
> +CONFIG_TEE=y
> +CONFIG_OPTEE=y
>  CONFIG_DM_THERMAL=y
>  CONFIG_IMX_WATCHDOG=y
> diff --git a/configs/phycore-imx8mm_defconfig b/configs/phycore-
> imx8mm_defconfig
> index
> 4d6bce26f07f7b90e7c3674f4b9ddcac8d775e1d..4cf4d3972567bcf77d9ee7e2fda
> 707070a778c72 100644
> --- a/configs/phycore-imx8mm_defconfig
> +++ b/configs/phycore-imx8mm_defconfig
> @@ -82,9 +82,9 @@ CONFIG_SPL_CLK_COMPOSITE_CCF=y
>  CONFIG_CLK_COMPOSITE_CCF=y
>  CONFIG_SPL_CLK_IMX8MM=y
>  CONFIG_CLK_IMX8MM=y
> +CONFIG_FSL_CAAM=y
>  CONFIG_MXC_GPIO=y
>  CONFIG_DM_I2C=y
> -CONFIG_MISC=y
>  CONFIG_I2C_EEPROM=y
>  CONFIG_SYS_I2C_EEPROM_ADDR=0x51
>  CONFIG_SUPPORT_EMMC_BOOT=y
> @@ -120,6 +120,7 @@ CONFIG_POWER_DOMAIN=y
>  CONFIG_IMX8M_POWER_DOMAIN=y
>  CONFIG_DM_REGULATOR_FIXED=y
>  CONFIG_DM_REGULATOR_GPIO=y
> +CONFIG_DM_RNG=y
>  CONFIG_DM_SERIAL=y
>  CONFIG_MXC_UART=y
>  CONFIG_SPI=y
> @@ -129,5 +130,7 @@ CONFIG_SYSRESET=y
>  CONFIG_SPL_SYSRESET=y
>  CONFIG_SYSRESET_PSCI=y
>  CONFIG_SYSRESET_WATCHDOG=y
> +CONFIG_TEE=y
> +CONFIG_OPTEE=y
>  CONFIG_DM_THERMAL=y
>  CONFIG_IMX_WATCHDOG=y
> diff --git a/configs/phycore-imx8mp_defconfig b/configs/phycore-
> imx8mp_defconfig
> index
> 6bd8bcf15daa95966aa973d8a493ebc1f05b14e9..c497f0bcd9131abab0b751ec9cc
> 81194405b1f19 100644
> --- a/configs/phycore-imx8mp_defconfig
> +++ b/configs/phycore-imx8mp_defconfig
> @@ -13,6 +13,7 @@ CONFIG_ENV_SECT_SIZE=0x10000
>  CONFIG_SYS_I2C_MXC_I2C1=y
>  CONFIG_DM_GPIO=y
>  CONFIG_DEFAULT_DEVICE_TREE="freescale/imx8mp-phyboard-pollux-rdk"
> +CONFIG_IMX8M_OPTEE_LOAD_ADDR=0x7e000000
>  CONFIG_TARGET_PHYCORE_IMX8MP=y
>  CONFIG_OF_LIBFDT_OVERLAY=y
>  CONFIG_SYS_MONITOR_LEN=524288
> @@ -153,6 +154,7 @@ CONFIG_DM_REGULATOR=y
>  CONFIG_DM_REGULATOR_FIXED=y
>  CONFIG_DM_REGULATOR_GPIO=y
>  CONFIG_SPL_POWER_I2C=y
> +CONFIG_DM_RNG=y
>  CONFIG_DM_SERIAL=y
>  CONFIG_MXC_UART=y
>  CONFIG_SPI=y
> @@ -162,6 +164,8 @@ CONFIG_SYSRESET=y
>  CONFIG_SPL_SYSRESET=y
>  CONFIG_SYSRESET_PSCI=y
>  CONFIG_SYSRESET_WATCHDOG=y
> +CONFIG_TEE=y
> +CONFIG_OPTEE=y
>  CONFIG_DM_THERMAL=y
>  CONFIG_USB=y
>  CONFIG_DM_USB_GADGET=y
> 

-- 
PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany

Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber,
Dipl.-Ing. (FH) Markus Lickes | Handelsregister Mainz HRB 4656 |
Finanzamt Mainz | St.Nr. 26/665/00608, DE 149059855

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] doc: phytec: update imx8m docs for optee builds
  2025-08-14 12:05 ` [PATCH v2 2/2] doc: phytec: update imx8m docs for optee builds Yannic Moog
@ 2025-09-02  7:25   ` Teresa Remmet
  0 siblings, 0 replies; 5+ messages in thread
From: Teresa Remmet @ 2025-09-02  7:25 UTC (permalink / raw)
  To: festevam@gmail.com, trini@konsulko.com, Yannic Moog
  Cc: upstream@lists.phytec.de, u-boot@lists.denx.de, Jan Remmet,
	Benjamin Hahn, Yashwanth Varakala

Hello Yannic,

Am Donnerstag, dem 14.08.2025 um 14:05 +0200 schrieb Yannic Moog:
> OP-TEE configs are enabled by default, change the doc to no longer
> declare OP-TEE as optional.
> Further, phycore-imx8mm and imx8mm-phygate-tauri-l use different
> build
> instructions, so dissolve the common file for building OP-TEE.
> While at it, introduce style changes where export commands are no
> longer
> used.

you do a lot of changes in this commit. The firmware version change is
not mentioned in the commit message. I think it would be easier to
follow your changes if you split the commit into multiple ones here.

Kind Regards,
Teresa

> 
> Signed-off-by: Yannic Moog <y.moog@phytec.de>
> ---
>  board/phytec/phycore_imx8mm/MAINTAINERS     |  1 -
>  doc/board/phytec/imx8mm-optee-build.rsti    | 14 ----------
>  doc/board/phytec/imx8mm-phygate-tauri-l.rst | 42 ++++++++++++++++++-
> ---------
>  doc/board/phytec/phycore-imx8mm.rst         | 43
> +++++++++++++++++++----------
>  doc/board/phytec/phycore-imx8mp.rst         | 41 ++++++++++++++-----
> --------
>  5 files changed, 79 insertions(+), 62 deletions(-)
> 
> diff --git a/board/phytec/phycore_imx8mm/MAINTAINERS
> b/board/phytec/phycore_imx8mm/MAINTAINERS
> index
> 7631e1cb331b608335620d0db49104459f673d1d..58c5e2d0af9fe404a5995fecc96
> cdbaa5845f979 100644
> --- a/board/phytec/phycore_imx8mm/MAINTAINERS
> +++ b/board/phytec/phycore_imx8mm/MAINTAINERS
> @@ -9,6 +9,5 @@ F:      configs/imx8mm-phygate-tauri-l_defconfig
>  F:      configs/phycore-imx8mm_defconfig
>  F:     doc/board/phytec/imx8mm-phygate-tauri-l.rst
>  F:     doc/board/phytec/index.rst
> -F:     doc/board/phytec/imx8mm-optee-build.rsti
>  F:     doc/board/phytec/phycore_imx8mm.rst
>  F:      include/configs/phycore_imx8mm.h
> diff --git a/doc/board/phytec/imx8mm-optee-build.rsti
> b/doc/board/phytec/imx8mm-optee-build.rsti
> deleted file mode 100644
> index
> c83de5cc7cf4a0229cbd89f4c7d2bfd8448cb735..000000000000000000000000000
> 0000000000000
> --- a/doc/board/phytec/imx8mm-optee-build.rsti
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -Build the OP-TEE binary (optional)
> -----------------------------------
> -
> -.. code-block:: bash
> -
> -   $ git clone https://github.com/OP-TEE/optee_os.git
> -   $ cd optee_os
> -   $ make CFG_TEE_BENCHMARK=n \
> -     CROSS_COMPILE=aarch64-linux-gnu- \
> -     O=out/arm \
> -     PLATFORM=imx-mx8mmevk \
> -     CFG_TZDRAM_START=0x56000000 \
> -     CFG_DDR_SIZE=0x80000000 \
> -     CFG_UART_BASE=UART3_BASE
> diff --git a/doc/board/phytec/imx8mm-phygate-tauri-l.rst
> b/doc/board/phytec/imx8mm-phygate-tauri-l.rst
> index
> 0d9e1024f8c5300e91a3a4c18b2babd5853a0824..4dd82cd9785fa585ed216664a25
> f593d4e723dbb 100644
> --- a/doc/board/phytec/imx8mm-phygate-tauri-l.rst
> +++ b/doc/board/phytec/imx8mm-phygate-tauri-l.rst
> @@ -9,7 +9,7 @@ Quick Start
>  -----------
>  
>  - Build the ARM Trusted firmware binary
> -- Build the OP-TEE binary (optional)
> +- Build the OP-TEE binary
>  - Get ddr firmware
>  - Build U-Boot
>  - Boot
> @@ -21,23 +21,35 @@ Build the ARM Trusted firmware binary
>  
>     $ git clone
> https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git
>     $ cd trusted-firmware-a
> -   $ export CROSS_COMPILE=aarch64-linux-gnu-
> -   $ export IMX_BOOT_UART_BASE=0x30880000
> -   $ # with optee
> -   $ make PLAT=imx8mm BL32_BASE=0x56000000 SPD=opteed bl31
> -   $ # without optee
> -   $ make PLAT=imx8mm bl31
> +   $ make -j $(nproc) \
> +          CROSS_COMPILE=aarch64-linux-gnu- \
> +          PLAT=imx8mm \
> +          IMX_BOOT_UART_BASE=0x30880000 \
> +          BL32_BASE=0xbe000000 \
> +          SPD=opteed \
> +          bl31
>  
> -.. include:: imx8mm-optee-build.rsti
> +Build the OP-TEE binary
> +-----------------------
> +
> +.. code-block:: bash
> +
> +   $ git clone https://github.com/OP-TEE/optee_os.git
> +   $ cd optee_os
> +   $ make -j $(nproc) \
> +          CROSS_COMPILE=aarch64-linux-gnu- \
> +          CFG_TEE_BENCHMARK=n \
> +          O=out/arm \
> +          PLATFORM=imx-mx8mm_phygate_tauri_l
>  
>  Get the ddr firmware
>  --------------------
>  
>  .. code-block:: bash
>  
> -   $ wget
> https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.23.bin
> -   $ chmod +x firmware-imx-8.23.bin
> -   $ ./firmware-imx-8.23.bin
> +   $ wget
> https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.28-994fa14.bin
> +   $ chmod +x firmware-imx-8.28-994fa14.bin
> +   $ ./firmware-imx-8.28-994fa14.bin
>  
>  Build U-Boot for SD card
>  ------------------------
> @@ -49,15 +61,17 @@ Copy binaries
>  
>     $ cp <TF-A dir>/build/imx8mm/release/bl31.bin .
>     $ cp <OP-TEE dir>/out/arm/core/tee-raw.bin tee.bin
> -   $ cp firmware-imx-8.23/firmware/ddr/synopsys/lpddr4*.bin .
> +   $ cp firmware-imx-8.28-994fa14/firmware/ddr/synopsys/lpddr4*.bin
> .
>  
>  Build U-Boot
>  ^^^^^^^^^^^^
>  
>  .. code-block:: bash
>  
> -   $ make imx8mm-phygate-tauri-l_defconfig
> -   $ make flash.bin
> +   $ make -j $(nproc)
> +          CROSS_COMPILE=aarch64-linux-gnu- \
> +          imx8mm-phygate-tauri-l_defconfig \
> +          flash.bin
>  
>  Flash SD card
>  ^^^^^^^^^^^^^
> diff --git a/doc/board/phytec/phycore-imx8mm.rst
> b/doc/board/phytec/phycore-imx8mm.rst
> index
> 08f5949e02d8d2bfba71867d93c2b3ed8fdc67e2..d5edbc91474e95f677dd12e5fcc
> 6c16092dea1cd 100644
> --- a/doc/board/phytec/phycore-imx8mm.rst
> +++ b/doc/board/phytec/phycore-imx8mm.rst
> @@ -9,7 +9,7 @@ Quick Start
>  -----------
>  
>  - Build the ARM Trusted firmware binary
> -- Build the OP-TEE binary (optional)
> +- Build the OP-TEE binary
>  - Get ddr firmware
>  - Build U-Boot
>  - Boot
> @@ -21,23 +21,35 @@ Build the ARM Trusted firmware binary
>  
>     $ git clone
> https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git
>     $ cd trusted-firmware-a
> -   $ export CROSS_COMPILE=aarch64-linux-gnu-
> -   $ export IMX_BOOT_UART_BASE=0x30880000
> -   $ # with optee
> -   $ make PLAT=imx8mm BL32_BASE=0x56000000 SPD=opteed bl31
> -   $ # without optee
> -   $ make PLAT=imx8mm bl31
> +   $ make -j $(nproc) \
> +          CROSS_COMPILE=aarch64-linux-gnu- \
> +          PLAT=imx8mm \
> +          IMX_BOOT_UART_BASE=0x30880000 \
> +          BL32_BASE=0x7e000000 \
> +          SPD=opteed \
> +          bl31
>  
> -.. include:: imx8mm-optee-build.rsti
> +Build the OP-TEE binary
> +-----------------------
> +
> +.. code-block:: bash
> +
> +   $ git clone https://github.com/OP-TEE/optee_os.git
> +   $ cd optee_os
> +   $ make -j $(nproc) \
> +          CROSS_COMPILE=aarch64-linux-gnu- \
> +          CFG_TEE_BENCHMARK=n \
> +          O=out/arm \
> +          PLATFORM=imx-mx8mm_phyboard_polis
>  
>  Get the ddr firmware
>  --------------------
>  
>  .. code-block:: bash
>  
> -   $ wget
> https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.19.bin
> -   $ chmod +x firmware-imx-8.19.bin
> -   $ ./firmware-imx-8.19.bin
> +   $ wget
> https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.28-994fa14.bin
> +   $ chmod +x firmware-imx-8.28-994fa14.bin
> +   $ ./firmware-imx-8.28-994fa14.bin
>  
>  Build U-Boot for SD card
>  ------------------------
> @@ -48,15 +60,18 @@ Copy binaries
>  .. code-block:: bash
>  
>     $ cp <TF-A dir>/build/imx8mm/release/bl31.bin .
> -   $ cp firmware-imx-8.19/firmware/ddr/synopsys/lpddr4*.bin .
> +   $ cp <OP-TEE dir>/out/arm/core/tee-raw.bin tee.bin
> +   $ cp firmware-imx-8.28-994fa14/firmware/ddr/synopsys/lpddr4*.bin
> .
>  
>  Build U-Boot
>  ^^^^^^^^^^^^
>  
>  .. code-block:: bash
>  
> -   $ make phycore-imx8mm_defconfig
> -   $ make flash.bin
> +   $ make -j $(nproc) \
> +          CROSS_COMPILE=aarch64-linux-gnu- \
> +          phycore-imx8mm_defconfig \
> +          flash.bin
>  
>  Flash SD card
>  ^^^^^^^^^^^^^
> diff --git a/doc/board/phytec/phycore-imx8mp.rst
> b/doc/board/phytec/phycore-imx8mp.rst
> index
> 50be99126537a2dc5323bd49c1513b196182c5f3..cea3a2835e69d6c6d3aa4c16698
> aebd09f73bf49 100644
> --- a/doc/board/phytec/phycore-imx8mp.rst
> +++ b/doc/board/phytec/phycore-imx8mp.rst
> @@ -3,13 +3,13 @@
>  phyCORE-i.MX 8M Plus
>  ====================
>  
> -The phyCORE-i.MX 8M Plus with 2GB of main memory is supported.
> +The phyCORE-i.MX 8M Plus with 1,2,4GB of main memory is supported.
>  
>  Quick Start
>  -----------
>  
>  - Build the ARM Trusted firmware binary
> -- Build the OP-TEE binary (optional)
> +- Build the OP-TEE binary
>  - Get ddr firmware
>  - Build U-Boot
>  - Boot
> @@ -21,12 +21,13 @@ Build the ARM Trusted firmware binary
>  
>     $ git clone
> https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git
>     $ cd trusted-firmware-a
> -   $ export CROSS_COMPILE=aarch64-linux-gnu-
> -   $ export IMX_BOOT_UART_BASE=0x30860000
> -   $ # with optee
> -   $ make PLAT=imx8mp SPD=opteed bl31
> -   $ # without optee
> -   $ make PLAT=imx8mp bl31
> +   $ make -j $(nproc) \
> +          CROSS_COMPILE=aarch64-linux-gnu- \
> +          PLAT=imx8mp \
> +          IMX_BOOT_UART_BASE=0x30860000 \
> +          BL32_BASE=0x7e000000 \
> +          SPD=opteed \
> +          bl31
>  
>  Build the OP-TEE binary (optional)
>  ----------------------------------
> @@ -35,20 +36,20 @@ Build the OP-TEE binary (optional)
>  
>     $ git clone https://github.com/OP-TEE/optee_os.git
>     $ cd optee_os
> -   $ make CFG_TEE_BENCHMARK=n \
> -     CROSS_COMPILE=aarch64-linux-gnu- \
> -     O=out/arm \
> -     PLATFORM=imx-mx8mp_phyboard_pollux \
> -     CFG_TZDRAM_START=0x56000000
> +   $ make -j $(nproc) \
> +          CROSS_COMPILE=aarch64-linux-gnu- \
> +          CFG_TEE_BENCHMARK=n \
> +          O=out/arm \
> +          PLATFORM=imx-mx8mp_phyboard_pollux
>  
>  Get the ddr firmware
>  --------------------
>  
>  .. code-block:: bash
>  
> -   $ wget
> https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.19.bin
> -   $ chmod +x firmware-imx-8.19.bin
> -   $ ./firmware-imx-8.19.bin
> +   $ wget
> https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.28-994fa14.bin
> +   $ chmod +x firmware-imx-8.28-994fa14.bin
> +   $ ./firmware-imx-8.28-994fa14.bin
>  
>  Build U-Boot for SD card
>  ------------------------
> @@ -60,15 +61,17 @@ Copy binaries
>  
>     $ cp <TF-A dir>/build/imx8mp/release/bl31.bin .
>     $ cp <OP-TEE dir>/out/arm/core/tee-raw.bin tee.bin
> -   $ cp firmware-imx-8.19/firmware/ddr/synopsys/lpddr4*.bin .
> +   $ cp firmware-imx-8.28-994fa14/firmware/ddr/synopsys/lpddr4*.bin
> .
>  
>  Build U-Boot
>  ^^^^^^^^^^^^
>  
>  .. code-block:: bash
>  
> -   $ make phycore-imx8mp_defconfig
> -   $ make flash.bin
> +   $ make -j $(nproc) \
> +          CROSS_COMPILE=aarch64-linux-gnu- \
> +          phycore-imx8mp_defconfig \
> +          flash.bin
>  
>  Flash SD card
>  ^^^^^^^^^^^^^
> 

-- 
PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany

Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber,
Dipl.-Ing. (FH) Markus Lickes | Handelsregister Mainz HRB 4656 |
Finanzamt Mainz | St.Nr. 26/665/00608, DE 149059855

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-09-02  7:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-14 12:05 [PATCH v2 0/2] PHYTEC imx8m boards: enable OP-TEE as default Yannic Moog
2025-08-14 12:05 ` [PATCH v2 1/2] phytec-imx8m boards: enable OP-TEE for KASLR Yannic Moog
2025-09-02  7:16   ` Teresa Remmet
2025-08-14 12:05 ` [PATCH v2 2/2] doc: phytec: update imx8m docs for optee builds Yannic Moog
2025-09-02  7:25   ` Teresa Remmet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).