RE: [RFC 05/10] eeprom: starfive: Update eeprom data format version to 3

Hal Feng
2025-09-02T09:14:08Z

> On 29.08.25 15:47, Heinrich Schuchardt wrote:
> On 29.08.25 08:09, Hal Feng wrote:
> > Add eeprom data format v3 support.
> > Add wifi_bt field in ATOM4 and add "mac wifi_bt <?>" command to modify
> it.
> > Set or show eth0/1 MAC address only if the board has eth0/1.
> >
> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> > ---
> > .../visionfive2/visionfive2-i2c-eeprom.c | 91 ++++++++++++++++---
> > 1 file changed, 78 insertions(+), 13 deletions(-)
> >
> > diff --git a/board/starfive/visionfive2/visionfive2-i2c-eeprom.c
> > b/board/starfive/visionfive2/visionfive2-i2c-eeprom.c
> > index 43b8af4fc59..7352252c475 100644
> > --- a/board/starfive/visionfive2/visionfive2-i2c-eeprom.c
> > +++ b/board/starfive/visionfive2/visionfive2-i2c-eeprom.c
> > @@ -11,7 +11,7 @@
> > #include <u-boot/crc.h>
> > #include <linux/delay.h>
> >
> > -#define FORMAT_VERSION 0x2
> > +#define FORMAT_VERSION 0x3
> > #define PCB_VERSION 0xB1
> > #define BOM_VERSION 'A'
> > /*
> > @@ -105,7 +105,8 @@ struct eeprom_atom4_data {
> > u8 bom_revision; /* BOM version */
> > u8 mac0_addr[MAC_ADDR_BYTES]; /* Ethernet0 MAC */
> > u8 mac1_addr[MAC_ADDR_BYTES]; /* Ethernet1 MAC */
> > - u8 reserved[2];
> > + u8 wifi_bt; /* WIFI/BT support flag */
> > + u8 reserved;
> > };
> >
> > struct starfive_eeprom_atom4 {
> > @@ -128,6 +129,35 @@ static union {
> > /* Set to 1 if we've read EEPROM into memory */
> > static int has_been_read __section(".data");
> >
> > +static const char * const board_no_eth0_list[] = {
> > + "FML13V01",
> > +};
> > +
> > +static const char * const board_no_eth1_list[] = {
> > + "FML13V01",
> > + "MARS",
> > + "VF7110SL",
> > +};
>
> Do you know in which category the Milk-V Mars CM ("MARC") falls?

Milk-V Mars CM board has eth0 but no eth1.
Will add "MARC" in board_no_eth1_list. Thanks.

Best regards,
Hal