RE: [RFC 01/10] riscv: dts: starfive: jh7110-common: Move out some nodes to the board dts

Hal Feng
2025-10-22T15:24:18Z

> On 03.09.25 00:18, E Shattow wrote:
>
> Hello Hal, and Heinrich,
>
> On 8/29/25 00:19, Heinrich Schuchardt wrote:
> > On 29.08.25 08:09, Hal Feng wrote:
> >> Some node in this file are not used by the upcoming VisionFive 2 Lite
> >> board. Move them to the board dts to prepare for adding the new
> >> VisionFive 2 Lite device tree.
> >>
> >> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> >
> > LGTM
> >
> > Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> >
>
> NAK

Please ignore patch 1 and patch 2.

>
> Better to drop jh7110-common-u-boot.dtsi from U-Boot [1]. Also we can drop
> jh7110-u-boot.dtsi file but that does require some additional work:
>
> - upstream dt-binding memory-controllers/starfive,jh7110-dmc.yaml [2]
> - upstream devicetree changes adding memory controller [3]
> - upstream bootph-pre-ram hints [4]
> - implement cpufreq driver

Why do we need the cpufreq driver in u-boot? You want the u-boot to run at the
highest frequency?
I think it is more stable to keep the u-boot running at 1GHz with lower power
consumption.

> - refactor drivers/ram/starfive/starfive_ddr.c to use common clock framework
> and delete 'clock-frequency = <2133>' in dts

2133 is the DDR data rate to set. We can not get this frequency using common
clock framework.

Best regards,
Hal

>
> I am not interested in writing U-Boot drivers. Hal, can you make the needed
> improvements in U-Boot for cpufreq and memory controller drivers?
>
> 1: https://lore.kernel.org/u-boot/20250815050315.62956-1-e@freeshell.de/
> 2: https://lore.kernel.org/lkml/20250823100159.203925-2-e@freeshell.de/
> 3: https://lore.kernel.org/lkml/20250823100159.203925-3-e@freeshell.de/
> 4: https://lore.kernel.org/lkml/20250823100159.203925-4-e@freeshell.de/