Re: [RFC 02/10] riscv: dts: starfive: Add VisionFive 2 Lite board device tree

Heinrich Schuchardt
2025-09-03T12:03:38Z

On 9/3/25 13:07, Sumit Garg wrote:
> On Tue, Sep 02, 2025 at 01:03:09PM -0700, E Shattow wrote:
>> Hi Hal,
>>
>> On 8/28/25 23:09, Hal Feng wrote:
>>> VisionFive 2 Lite is a mini SBC based on the StarFive JH7110S SoC.
>>>
>>> Board features:
>>> - JH7110S SoC
>>> - 2/4/8 GiB LPDDR4 DRAM
>>> - AXP15060 PMIC
>>> - 40 pin GPIO header
>>> - 1x USB 3.0 host port
>>> - 3x USB 2.0 host port
>>> - 1x M.2 M-Key (size: 2242)
>>> - 1x MicroSD slot (optional non-removable eMMC)
>>> - 1x QSPI Flash
>>> - 1x I2C EEPROM
>>> - 1x 1Gbps Ethernet port
>>> - SDIO-based Wi-Fi & UART-based Bluetooth
>>> - 1x HDMI port
>>> - 1x 2-lane DSI
>>> - 1x 2-lane CSI
>>>
>>
>> Prefer to see subject line and URL of recent upstream discussion or git
>> web commit for the new or modified dts changes from upstream of
>> devicetree-rebasing in this commit and not just in the cover letter.
>>
>> + From upstream LKML discussion "[RFC 3/3] riscv: dts: starfive: Add
>> VisionFive 2 Lite board device tree" [1].
>> + 1:
>> https://lore.kernel.org/all/20250821100930.71404-4-hal.feng@starfivetech.com/
>>
>>> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
>>> ---
>>> .../jh7110s-starfive-visionfive-2-lite.dts | 152 ++++++++++++++++++
>>> 1 file changed, 152 insertions(+)
>>> create mode 100644 dts/upstream/src/riscv/starfive/jh7110s-starfive-visionfive-2-lite.dts
>>>
>>> diff --git a/dts/upstream/src/riscv/starfive/jh7110s-starfive-visionfive-2-lite.dts b/dts/upstream/src/riscv/starfive/jh7110s-starfive-visionfive-2-lite.dts
>>> new file mode 100644
>>> index 00000000000..a0cb9912eb8
>>> --- /dev/null
>>> +++ b/dts/upstream/src/riscv/starfive/jh7110s-starfive-visionfive-2-lite.dts
>>
>> No, do not directly add or modify upstream dts in dts/upstream/src
>> subtree. We are not permitted in U-Boot to merge out-of-band devicetree
>> changes to the devicetree-rebasing subtree as this creates more work for
>> Tom, if I understand correctly?
>>
>> Instead add or modify this dts as
>> arch/riscv/dts/jh7110s-starfive-visionfive-2-lite-u-boot.dtsi filename.
>
> That's right. dts/upstream subtree isn't allowed to be directly patched
> but it is rather synced regularly with devicetree-rebasing. So please
> follow documentation documentation here [1].
>
> [1] https://docs.u-boot.org/en/latest/develop/devicetree/control.html#resyncing-with-devicetree-rebasing
>
> -Sumit

Is mixing upstream dtbs and non upstream dtbs in CONFIG_OF_LIST
supported by buildman?
Do files in arch/risc-v/dts/ override upstream files of the same name?

Best regards

Heinrich