[PATCH v3 0/3] Hyperflash boot fixes for j721e

[PATCH v3 0/3] Hyperflash boot fixes for j721e

[Anurag Dutta]

Hi all,
This series introdues a couple of small fixes that involves
enabling hyperflash at R5 SPL stage and Kconfig changes that are
required for HBMC boot on j721e

Test logs:
j721e : https://gist.github.com/anuragdutta731/f228b509e69a324f08c250e0d84a97ab
j7200 : https://gist.github.com/anuragdutta731/adf340a5a3ba727baae930fcec382524

Changelog : v3 :
1. Modified commit messages and added correct fixes tag

Link to v2:
https://lore.kernel.org/all/20250902064839.1296877-1-a-dutta@ti.com/

Changelog : v2 :
1. Modified commit messages according to review comments
2. Added configs for r5 spl for j721e for hbmc boot

Link to v1 :
https://lore.kernel.org/all/20250416061652.2394419-1-a-dutta@ti.com/

Anurag Dutta (3):
  mtd: Kconfig: Add SPL_MUX_MMIO dependency to HBMC driver
  configs: j721e_evm_r5: Enable HBMC and MUX_MMIO at SPL
  arm: dts: k3-j721e-r5-common-proc-board: Enable HBMC in R5 SPL stage

 arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 1 +
 configs/j721e_evm_r5_defconfig                 | 2 ++
 drivers/mtd/Kconfig                            | 2 +-
 3 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.34.1

[PATCH v3 1/3] mtd: Kconfig: Add SPL_MUX_MMIO dependency to HBMC driver

[Anurag Dutta]

MUX_MMIO is needed by HBMC in SPL stage. Enable it at SPL as well
as u-boot proper stage.

Signed-off-by: Anurag Dutta <a-dutta@ti.com>
---
 drivers/mtd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index 2b7f5e5ed7b..e76601a5545 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -202,7 +202,7 @@ config RENESAS_RPC_HF
 
 config HBMC_AM654
 	bool "HyperBus controller driver for AM65x SoC"
-	depends on MULTIPLEXER && MUX_MMIO
+	depends on MULTIPLEXER && (MUX_MMIO || SPL_MUX_MMIO)
 	help
 	 This is the driver for HyperBus controller on TI's AM65x and
 	 other SoCs
-- 
2.34.1

[PATCH v3 2/3] configs: j721e_evm_r5: Enable HBMC and MUX_MMIO at SPL

[Anurag Dutta]

Commit 0e198ff1a911 ("configs: Resync with savedefconfig") removed
the necessary configs required to boot HyperFlash successfully, due to
missing Kconfig dependencies. Now that the Kconfig dependencies have
been added, re-enable the HBMC and MUX_MMIO configs in the SPL stage.

Fixes: 0e198ff1a911 ("configs: Resync with savedefconfig")
Signed-off-by: Anurag Dutta <a-dutta@ti.com>
---
 configs/j721e_evm_r5_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/j721e_evm_r5_defconfig b/configs/j721e_evm_r5_defconfig
index ceb2e273b54..52290722686 100644
--- a/configs/j721e_evm_r5_defconfig
+++ b/configs/j721e_evm_r5_defconfig
@@ -124,6 +124,7 @@ CONFIG_CFI_FLASH=y
 CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y
 CONFIG_FLASH_CFI_MTD=y
 CONFIG_SYS_FLASH_CFI=y
+CONFIG_HBMC_AM654=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH_SFDP_SUPPORT=y
 CONFIG_SPI_FLASH_SOFT_RESET=y
@@ -133,6 +134,7 @@ CONFIG_SPI_FLASH_S28HX_T=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_MT35XU=y
 CONFIG_MULTIPLEXER=y
+CONFIG_SPL_MUX_MMIO=y
 CONFIG_PINCTRL=y
 # CONFIG_PINCTRL_GENERIC is not set
 CONFIG_SPL_PINCTRL=y
-- 
2.34.1

[PATCH v3 3/3] arm: dts: k3-j721e-r5-common-proc-board: Enable HBMC in R5 SPL stage

[Anurag Dutta]

Enable HBMC in the R5 SPL stage

Fixes: c9df79ee64d0 ("arm: dts: k3-j721e-r5-common: Add HBMC overrides for R5 SPL")
Signed-off-by: Anurag Dutta <a-dutta@ti.com>
---
 arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
index c775432505b..e4f799dfb27 100644
--- a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
+++ b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
@@ -52,6 +52,7 @@
 };
 
 &hbmc {
+	status = "okay";
 	reg = <0x0 0x47040000 0x0 0x100>,
 		<0x0 0x50000000 0x0 0x8000000>;
 	ranges = <0x0 0x0 0x0 0x50000000 0x4000000>,
-- 
2.34.1

Re: [PATCH v3 2/3] configs: j721e_evm_r5: Enable HBMC and MUX_MMIO at SPL

[Kumar, Udit]

On 9/2/2025 3:49 PM, Anurag Dutta wrote:
> Commit 0e198ff1a911 ("configs: Resync with savedefconfig") removed
> the necessary configs required to boot HyperFlash successfully, due to
> missing Kconfig dependencies. Now that the Kconfig dependencies have
> been added, re-enable the HBMC and MUX_MMIO configs in the SPL stage.
>
> Fixes: 0e198ff1a911 ("configs: Resync with savedefconfig")
> Signed-off-by: Anurag Dutta <a-dutta@ti.com>
> ---

Reviewed-by: Udit Kumar <u-kumar1@ti.com>


>   configs/j721e_evm_r5_defconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/configs/j721e_evm_r5_defconfig b/configs/j721e_evm_r5_defconfig
> index ceb2e273b54..52290722686 100644
> --- a/configs/j721e_evm_r5_defconfig
> +++ b/configs/j721e_evm_r5_defconfig
> @@ -124,6 +124,7 @@ CONFIG_CFI_FLASH=y
>   CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y
>   CONFIG_FLASH_CFI_MTD=y
>   CONFIG_SYS_FLASH_CFI=y
> +CONFIG_HBMC_AM654=y
>   CONFIG_DM_SPI_FLASH=y
>   CONFIG_SPI_FLASH_SFDP_SUPPORT=y
>   CONFIG_SPI_FLASH_SOFT_RESET=y
> @@ -133,6 +134,7 @@ CONFIG_SPI_FLASH_S28HX_T=y
>   CONFIG_SPI_FLASH_STMICRO=y
>   CONFIG_SPI_FLASH_MT35XU=y
>   CONFIG_MULTIPLEXER=y
> +CONFIG_SPL_MUX_MMIO=y
>   CONFIG_PINCTRL=y
>   # CONFIG_PINCTRL_GENERIC is not set
>   CONFIG_SPL_PINCTRL=y

Re: [PATCH v3 3/3] arm: dts: k3-j721e-r5-common-proc-board: Enable HBMC in R5 SPL stage

[Kumar, Udit]

On 9/2/2025 3:50 PM, Anurag Dutta wrote:
> Enable HBMC in the R5 SPL stage
>
> Fixes: c9df79ee64d0 ("arm: dts: k3-j721e-r5-common: Add HBMC overrides for R5 SPL")
> Signed-off-by: Anurag Dutta <a-dutta@ti.com>
> ---
>   arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> index c775432505b..e4f799dfb27 100644
> --- a/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> +++ b/arch/arm/dts/k3-j721e-r5-common-proc-board.dts
> @@ -52,6 +52,7 @@
>   };
>   
>   &hbmc {
> +	status = "okay";

Reviewed-by: Udit Kumar <u-kumar1@ti.com>


>   	reg = <0x0 0x47040000 0x0 0x100>,
>   		<0x0 0x50000000 0x0 0x8000000>;
>   	ranges = <0x0 0x0 0x0 0x50000000 0x4000000>,

Re: [PATCH v3 2/3] configs: j721e_evm_r5: Enable HBMC and MUX_MMIO at SPL

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

On Tue, Sep 02, 2025 at 03:49:59PM +0530, Anurag Dutta wrote:

> Commit 0e198ff1a911 ("configs: Resync with savedefconfig") removed
> the necessary configs required to boot HyperFlash successfully, due to
> missing Kconfig dependencies. Now that the Kconfig dependencies have
> been added, re-enable the HBMC and MUX_MMIO configs in the SPL stage.
> 
> Fixes: 0e198ff1a911 ("configs: Resync with savedefconfig")
> Signed-off-by: Anurag Dutta <a-dutta@ti.com>

Please note that this means it never worked to start with.
"savedefconfig" does the equivalent of "make foo_defconfig" and then
uses the output. So those symbols were missing in the output normally.
We can keep the fixes tag, and I'll apply this for v2025.10 soon, but I
want to clarify the problem.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 2/3] configs: j721e_evm_r5: Enable HBMC and MUX_MMIO at SPL

[Kumar, Udit]

Hi Tom

On 9/2/2025 9:16 PM, Tom Rini wrote:
> On Tue, Sep 02, 2025 at 03:49:59PM +0530, Anurag Dutta wrote:
>
>> Commit 0e198ff1a911 ("configs: Resync with savedefconfig") removed
>> the necessary configs required to boot HyperFlash successfully, due to
>> missing Kconfig dependencies. Now that the Kconfig dependencies have
>> been added, re-enable the HBMC and MUX_MMIO configs in the SPL stage.
>>
>> Fixes: 0e198ff1a911 ("configs: Resync with savedefconfig")
>> Signed-off-by: Anurag Dutta <a-dutta@ti.com>
> Please note that this means it never worked to start with.
> "savedefconfig" does the equivalent of "make foo_defconfig" and then


It was working before but due to some boot issues , due to DT sync

we disabled HBMC with commit id 5b2671594b80af116e259313d48bcd580d71f462 .


Instead of saying Fixes: 0e198ff1a91,

This patch is fixing sha id 5b2671594b80af116e259313d48bcd580d71f462 by 
kind of revert.

my bad to give R/B , overlooked on sha id of fixes tag.


> uses the output. So those symbols were missing in the output normally.
> We can keep the fixes tag, and I'll apply this for v2025.10 soon, but I
> want to clarify the problem.

Re: [PATCH v3 2/3] configs: j721e_evm_r5: Enable HBMC and MUX_MMIO at SPL

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]

On Tue, Sep 02, 2025 at 09:36:25PM +0530, Kumar, Udit wrote:
> Hi Tom
> 
> On 9/2/2025 9:16 PM, Tom Rini wrote:
> > On Tue, Sep 02, 2025 at 03:49:59PM +0530, Anurag Dutta wrote:
> > 
> > > Commit 0e198ff1a911 ("configs: Resync with savedefconfig") removed
> > > the necessary configs required to boot HyperFlash successfully, due to
> > > missing Kconfig dependencies. Now that the Kconfig dependencies have
> > > been added, re-enable the HBMC and MUX_MMIO configs in the SPL stage.
> > > 
> > > Fixes: 0e198ff1a911 ("configs: Resync with savedefconfig")
> > > Signed-off-by: Anurag Dutta <a-dutta@ti.com>
> > Please note that this means it never worked to start with.
> > "savedefconfig" does the equivalent of "make foo_defconfig" and then
> 
> 
> It was working before but due to some boot issues , due to DT sync
> 
> we disabled HBMC with commit id 5b2671594b80af116e259313d48bcd580d71f462 .
> 
> 
> Instead of saying Fixes: 0e198ff1a91,
> 
> This patch is fixing sha id 5b2671594b80af116e259313d48bcd580d71f462 by kind
> of revert.
> 
> my bad to give R/B , overlooked on sha id of fixes tag.

Again, no, that's not quite how it works. When we do a defconfig resync
like this we're just making the defconfigs reflect the present reality.
If you checkout 5b2671594b80af116e259313d48bcd580d71f462^ and then look
at the resulting defconfig, that option will be off. Doing a git blame
on drivers/mtd/Kconfig the right fixes tag is for:
commit 8f71d37838ba0b0bfa047f5133877092ee9d1110
Author: Anurag Dutta <a-dutta@ti.com>
Date:   Fri Nov 29 17:01:36 2024 +0530

    mtd: Kconfig: Change HBMC driver's dependency to MULTIPLEXER and MUX_MMIO
    
    The HBMC_AM654 driver was dependent on SYSCON because syscon APIs were
    being used to select the multiplexer state. Change the dependency to
    MULTIPLEXER and MUX_MMIO because mux APIs are now being used to
    select mux state.
    
    Signed-off-by: Anurag Dutta <a-dutta@ti.com>

As that's what changed the dependencies for the option.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 2/3] configs: j721e_evm_r5: Enable HBMC and MUX_MMIO at SPL

[Kumar, Udit]

Hi Tom,

On 9/2/2025 9:42 PM, Tom Rini wrote:
> On Tue, Sep 02, 2025 at 09:36:25PM +0530, Kumar, Udit wrote:
>> Hi Tom
>>
>> On 9/2/2025 9:16 PM, Tom Rini wrote:
>>> On Tue, Sep 02, 2025 at 03:49:59PM +0530, Anurag Dutta wrote:
>>>
>>>> Commit 0e198ff1a911 ("configs: Resync with savedefconfig") removed
>>>> the necessary configs required to boot HyperFlash successfully, due to
>>>> missing Kconfig dependencies. Now that the Kconfig dependencies have
>>>> been added, re-enable the HBMC and MUX_MMIO configs in the SPL stage.
>>>>
>>>> Fixes: 0e198ff1a911 ("configs: Resync with savedefconfig")
>>>> Signed-off-by: Anurag Dutta <a-dutta@ti.com>
>>> Please note that this means it never worked to start with.
>>> "savedefconfig" does the equivalent of "make foo_defconfig" and then
>>
>> It was working before but due to some boot issues , due to DT sync
>>
>> we disabled HBMC with commit id 5b2671594b80af116e259313d48bcd580d71f462 .
>>
>>
>> Instead of saying Fixes: 0e198ff1a91,
>>
>> This patch is fixing sha id 5b2671594b80af116e259313d48bcd580d71f462 by kind
>> of revert.
>>
>> my bad to give R/B , overlooked on sha id of fixes tag.
> Again, no, that's not quite how it works. When we do a defconfig resync
> like this we're just making the defconfigs reflect the present reality.

would need your suggestion here, what should be fixes tag,

My comments were not related to defconfig sync

> If you checkout 5b2671594b80af116e259313d48bcd580d71f462^ and then look
> at the resulting defconfig, that option will be off. Doing a git blame
> on drivers/mtd/Kconfig the right fixes tag is for:


If you look at sha id d7ef2ef7c87528c359e110d7170e01a98aaecf14 (configs: 
j721e_evm_defconfig: Add HBMC related configs)

is adding support for HBMC. So it was functional before.


Later due to DT sync and HBMC was broken so we disabled HBMC with sha id 
5b2671594b80af116e259313d48bcd580d71f462.


After that there was attempt to enable HBMC via below sha ids

8f71d37838ba0b0bfa047f5133877092ee9d1110 (mtd: Kconfig: Change HBMC 
driver's dependency to MULTIPLEXER and MUX_MMIO)

fd7fcd4098d5c1ba9e20dbd72aa5f9a74f0cbe42 (configs: 
j721e_evm_*_defconfig: Add configs for Hyperflash boot)

c9df79ee64d0885277d5061a9426744920c4d6a5 (arm: dts: k3-j721e-r5-common: 
Add HBMC overrides for R5 SPL)

a42b8b0b3fe0ffe69ffb932bf3e709a62ff34a23 (mtd: HBMC-AM654: Changed 
syscon API to mux APIs)

f0558f3a89fe0fa900b162ae2758772e37f72739 (mux: Makefile: Add config for 
mux drivers)



> commit 8f71d37838ba0b0bfa047f5133877092ee9d1110
> Author: Anurag Dutta <a-dutta@ti.com>
> Date:   Fri Nov 29 17:01:36 2024 +0530
>
>      mtd: Kconfig: Change HBMC driver's dependency to MULTIPLEXER and MUX_MMIO
>      
>      The HBMC_AM654 driver was dependent on SYSCON because syscon APIs were
>      being used to select the multiplexer state. Change the dependency to
>      MULTIPLEXER and MUX_MMIO because mux APIs are now being used to
>      select mux state.
>      
>      Signed-off-by: Anurag Dutta <a-dutta@ti.com>
>
> As that's what changed the dependencies for the option.
>