From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Weijie Gao <weijie.gao@mediatek.com>
Cc: <u-boot@lists.denx.de>,
GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
Tom Rini <trini@konsulko.com>,
"Lucien . Jheng" <lucienzx159@gmail.com>
Subject: Re: [PATCH v3 2/5] misc: fs_loader: allow using long script name in request_firmware_into_buf_via_script()
Date: Wed, 3 Sep 2025 13:36:00 +0200 [thread overview]
Message-ID: <20250903133600.52169228@karo-electronics.de> (raw)
In-Reply-To: <038e8258c903367dccd9c7cd1adb51bcf2bdf307.1756885599.git.weijie.gao@mediatek.com>
Hi,
On Wed, 3 Sep 2025 16:38:30 +0800 Weijie Gao wrote:
> Use cmd_process() to remove the length limit of script name used for
> run_command().
>
> Signed-off-by: Weijie Gao <weijie.gao@mediatek.com>
> ---
> drivers/misc/fs_loader.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
> index 87acd385e23..6a6796c1931 100644
> --- a/drivers/misc/fs_loader.c
> +++ b/drivers/misc/fs_loader.c
> @@ -232,18 +232,15 @@ int request_firmware_into_buf_via_script(void **buf, size_t max_size,
> const char *script_name,
> size_t *retsize)
> {
> + char *args[2] = { (char *)"run", (char *)script_name };
>
const char *args[2] = { "run", script_name };
does not work?
I don't see any need for a non-const 'args' here.
Lothar Waßmann
next prev parent reply other threads:[~2025-09-03 11:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 8:38 [PATCH v3 0/5] Add support for MediaTek MT7987/MT7988 built-in 2.5Gb ethernet PHY (v3) Weijie Gao
2025-09-03 8:38 ` [PATCH v3 1/5] misc: fs_loader: allow returning actual firmware data size in request_firmware_into_buf_via_script() Weijie Gao
2025-09-03 8:38 ` [PATCH v3 2/5] misc: fs_loader: allow using long script name " Weijie Gao
2025-09-03 11:36 ` Lothar Waßmann [this message]
2025-09-04 0:23 ` Weijie Gao
2025-09-04 9:28 ` Lothar Waßmann
2025-09-05 1:26 ` Weijie Gao
2025-09-05 5:35 ` Lothar Waßmann
2025-09-03 8:38 ` [PATCH v3 3/5] net: mediatek: associate PHY device with dts node specified by phy-handle Weijie Gao
2025-09-03 8:38 ` [PATCH v3 4/5] net: phy: Add MediaTek built-in 2.5Gb ethernet PHY driver Weijie Gao
2025-09-03 8:38 ` [PATCH v3 5/5] MAINTAINERS: update ethernet-related file list for MediaTek ARM platform Weijie Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903133600.52169228@karo-electronics.de \
--to=lw@karo-electronics.de \
--cc=GSS_MTK_Uboot_upstream@mediatek.com \
--cc=lucienzx159@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox