From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de, Heinrich Schuchardt <xypron.glpk@gmx.de>,
Andrew Goodbody <andrew.goodbody@linaro.org>,
Maximilian Brune <maximilian.brune@9elements.com>,
Moritz Fischer <moritzf@google.com>,
Sam Protsenko <semen.protsenko@linaro.org>
Subject: Re: [PATCH v4 01/11] boot: Try all bootmeths on the final partition
Date: Wed, 15 Oct 2025 13:04:46 -0600 [thread overview]
Message-ID: <20251015190446.GS6113@bill-the-cat> (raw)
In-Reply-To: <20251015154423.908468-2-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Wed, Oct 15, 2025 at 04:44:04PM +0100, Simon Glass wrote:
> At present, normally when one bootmeth fails on a partition, we move on
> and try the next bootmeth. However, this was not the case for the final
> partition due to a bug. Rework the logic so that all partitions are
> treated the same.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v4:
> - Reword the commit message as Tom suggested
>
> boot/bootflow.c | 34 ++++++++++++++++------------------
> 1 file changed, 16 insertions(+), 18 deletions(-)
I'm glad you reworded this, but it's frustrating you didn't also post
this stand alone (and presumably sooner) as was requested as it's a
stand alone fix.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-10-15 19:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 15:44 [PATCH v4 00/11] boot: Support priority for global bootmeths Simon Glass
2025-10-15 15:44 ` [PATCH v4 01/11] boot: Try all bootmeths on the final partition Simon Glass
2025-10-15 19:04 ` Tom Rini [this message]
2025-10-16 12:55 ` Heinrich Schuchardt
2025-10-16 15:33 ` Tom Rini
2025-10-15 15:44 ` [PATCH v4 02/11] boot: Add a new test for global bootmeths Simon Glass
2025-10-15 15:44 ` [PATCH v4 03/11] boot: Update first_glob_method when dropping a bootmeth Simon Glass
2025-10-15 15:44 ` [PATCH v4 04/11] boot: Add a flag for whether there are global bootmeths Simon Glass
2025-10-15 15:44 ` [PATCH v4 05/11] boot: Keep track of which bootmeths have been used Simon Glass
2025-10-15 15:44 ` [PATCH v4 06/11] boot: Support rescanning the global bootmeths Simon Glass
2025-10-15 15:44 ` [PATCH v4 07/11] boot: Only run global bootmeths once each Simon Glass
2025-10-15 15:44 ` [PATCH v4 08/11] boot: Implement a priority for global bootmeths Simon Glass
2025-10-15 15:44 ` [PATCH v4 09/11] boot: Don't change the method count after " Simon Glass
2025-10-15 15:44 ` [PATCH v4 10/11] boot: Run global bootmeths after all bootdevs are exhausted Simon Glass
2025-10-15 15:44 ` [PATCH v4 11/11] boot: Run the EFI bootmgr just before network devices Simon Glass
2025-10-15 19:09 ` [PATCH v4 00/11] boot: Support priority for global bootmeths Tom Rini
2025-10-22 22:16 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015190446.GS6113@bill-the-cat \
--to=trini@konsulko.com \
--cc=andrew.goodbody@linaro.org \
--cc=maximilian.brune@9elements.com \
--cc=moritzf@google.com \
--cc=semen.protsenko@linaro.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox