Re: [PATCH v5 1/5] docker: add OP-TEE and TF-A build for testing Firmware Handoff

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

On Tue, Oct 21, 2025 at 08:34:33AM -0700, Raymond Mao wrote:

> Fetch OP-TEE (4.7.0), TF-A (v2.13.0), MbedTLS (v3.6) and build
> bl1 and fip with both Firmware Handoff and Measured Boot enabled.
> 
> Signed-off-by: Raymond Mao <raymond.mao@linaro.org>
> Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
> Changes in V2:
> - Move OP-TEE dependencies into the common group.
> - Fetch MbedTLS/TF-A and build bl1/fip in dockerfile instead of
>   post-buildman script.
> - Remove Trust Boot related build options.
> Changes in V3:
> - Clean-up of OP-TEE deps.
> Changes in V4:
> - Minimize OP-TEE build options.
> Changes in V5:
> - Add '--depth=1' and '--branch' when cloning OP-TEE, MbedTLS and TF-A.
> 
>  tools/docker/Dockerfile | 38 +++++++++++++++++++++++++++++++++++---
>  1 file changed, 35 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
> index 5b4c75f8400..3286b2ba6b2 100644
> --- a/tools/docker/Dockerfile
> +++ b/tools/docker/Dockerfile
[snip]
> @@ -227,10 +229,22 @@ RUN git clone https://gitlab.com/qemu-project/qemu.git /tmp/qemu && \
>  	make -j$(nproc) all install && \
>  	rm -rf /tmp/qemu
>  
> -# Build fiptool
> -RUN git clone https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git /tmp/tf-a && \
> +# Build OP-TEE for qemu_arm64
> +RUN git clone --depth=1 --branch 4.7.0 https://github.com/OP-TEE/optee_os.git /tmp/optee_os && \

I was asking for this to be two lines:
RUN git clone --depth=1 https://github.com/OP-TEE/optee_os.git /tmp/optee_os \
	--branch 4.7.0 && \

So that updates to later versions can be a single line change that's
also clearly just changing the version number.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]