Re: [PATCH v1 0/6] remoteproc: k3-r5: Build fixes and security improvements

Philippe Schenker
2025-11-07T08:21:58Z

[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]

Hi Tom,

Sorry for not spotting this. I will improve the patchset and send a v2.

On Thu, 2025-11-06 at 13:35 -0600, Tom Rini wrote:
> On Thu, Oct 23, 2025 at 11:46:18AM +0200, Philippe Schenker wrote:
>
> > From: Philippe Schenker <philippe.schenker@impulsing.ch>
> >
> >
> > This series fixes compilation errors when building for R5 cores and
> > addresses a security issue where authenticated images were not
> > being
> > used correctly.
> >
> > Patch 1: Cosmetic removal of duplicate code
> >
> > Patches 2-3: Fix build errors caused by type mismatches between
> > function signatures and the types used in R5 builds.
> >
> > Patches 4-5: fix a bug where ti_secure_image_post_process()
> > relocates
> > images during authentication, but callers were still using the
> > original
> > unverified addresses.
> >
> > Patch 6: Implements is_running operation to allow querying R5F core
> > status.
> >
> > Note: If preferred, I can split this series.
>
> With the series applied, I see warnings now on:
> j721e_beagleboneai64_r5 am62x_beagleplay_r5 am67a_beagley_ai_r5
> phycore_am62ax_r5 phycore_am62ax_r5_ethboot phycore_am62ax_r5_usbdfu
> phycore_am62x_r5 phycore_am62x_r5_ethboot phycore_am62x_r5_usbdfu
> phycore_am64x_r5 am62ax_evm_r5 am62dx_evm_r5 am62px_evm_r5
> am62px_evm_r5_ethboot am62x_evm_r5 am62x_evm_r5_ethboot am62x_lpsk_r5
> am64x_evm_r5 am65x_evm_r5 am65x_evm_r5_usbdfu am65x_evm_r5_usbmsc
> j7200_evm_r5 j721e_evm_r5 j721e_sk_r5 am68_sk_r5 am68_sk_r5_ethboot
> j721s2_evm_r5 j722s_evm_r5 j722s_evm_r5_ethboot am69_sk_r5
> am69_sk_r5_ethboot j742s2_evm_r5 j784s4_evm_r5 verdin-am62_r5
> verdin-am62p_r5
> like:
> arch/arm/mach-k3/security.c:122:20: error: cast to pointer from
> integer of different size [-Werror=int-to-pointer-cast]
>    122 |         *p_image = (void *)image_addr;

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 659 bytes --]