* [PATCH v5 0/2] net: phy: aquantia: Switch to generic firmware loader
@ 2025-11-01 12:31 Beiyan Yun
2025-11-01 12:31 ` [PATCH v5 1/2] net: phy: aquantia: refactor firmware upload helpers Beiyan Yun
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Beiyan Yun @ 2025-11-01 12:31 UTC (permalink / raw)
To: u-boot
Cc: Tom Rini, Yao Zi, Marek Vasut, Beiyan Yun, Jerome Forissier,
Joe Hershberger, Lucien.Jheng, Ramon Fried, Romain Gantois,
Siddharth Vadapalli, Sky Huang, Weijie Gao
Hi,
This patch series refactors the Aquantia PHY firmware loader to use
the generic fwloader framework.
The existing loader is limited to loading firmware from an MMC device,
which restricts its use on many devices (e.g., routers) that may use
other storage like USB or have a UBIFS root filesystem. Migrating to the
generic firmware loader allows firmware to be sourced from any backend
supported by the fwloader scripting framework.
The series is structured as follows:
- The first patch prepares current loading code for fwloader.
- The second and main patch replaces the custom loader with generic one.
This change has been tested on a Buffalo WXR18000BE10P router, loading
firmware from a UBIFS volume for Marvell CUX3410.
Changes in v5:
- Remove fsloader codepath
- Drop binding changes
- Make script name static
- Minor refactor
Changes in v4:
- Split firmware upload helpers change
- Reorder `aquantia_read_fw`
- Make `aquantia_read_fw` weak to allow overide
- Rename exit label in `aquantia_read_fw`
- Kconfig polish
Changes in v3:
- Select FW_LOADER with PHY_AQUANTIA_UPLOAD_FW
Changes in v2:
- Add support for script based loader
Beiyan Yun (2):
net: phy: aquantia: refactor firmware upload helpers
net: phy: aquantia: use generic firmware loader
drivers/net/phy/Kconfig | 23 ++++-----
drivers/net/phy/aquantia.c | 103 +++++++++++++++++--------------------
2 files changed, 59 insertions(+), 67 deletions(-)
--
2.47.3
base-commit: 62b45e82bdbf703571450e97f605893fe0d50530
branch: aquantia-fsloader-v5
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v5 1/2] net: phy: aquantia: refactor firmware upload helpers
2025-11-01 12:31 [PATCH v5 0/2] net: phy: aquantia: Switch to generic firmware loader Beiyan Yun
@ 2025-11-01 12:31 ` Beiyan Yun
2025-11-01 12:31 ` [PATCH v5 2/2] net: phy: aquantia: use generic firmware loader Beiyan Yun
2025-11-15 7:48 ` [PATCH v5 0/2] net: phy: aquantia: Switch to " Beiyan Yun
2 siblings, 0 replies; 9+ messages in thread
From: Beiyan Yun @ 2025-11-01 12:31 UTC (permalink / raw)
To: u-boot
Cc: Tom Rini, Yao Zi, Marek Vasut, Beiyan Yun, Jerome Forissier,
Joe Hershberger, Ramon Fried, Siddharth Vadapalli
Split `aquantia_upload_firmware` into `aquantia_upload_firmware`
and `aquantia_do_upload_firmware` to prepare for fwloader change.
Signed-off-by: Beiyan Yun <root@infi.wang>
---
Changes in v5:
- Minor refactor
Changes in v4:
- New
drivers/net/phy/aquantia.c | 37 +++++++++++++++++++++++++------------
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c
index 903fcd667f6..fc2476fb038 100644
--- a/drivers/net/phy/aquantia.c
+++ b/drivers/net/phy/aquantia.c
@@ -218,27 +218,26 @@ static u32 unpack_u24(const u8 *data)
return (data[2] << 16) + (data[1] << 8) + data[0];
}
-static int aquantia_upload_firmware(struct phy_device *phydev)
+static int aquantia_do_upload_firmware(struct phy_device *phydev,
+ const u8 *addr, size_t fw_length)
{
int ret;
- u8 *addr = NULL;
- size_t fw_length = 0;
u16 calculated_crc, read_crc;
char version[VERSION_STRING_SIZE];
u32 primary_offset, iram_offset, iram_size, dram_offset, dram_size;
const struct fw_header *header;
- ret = aquantia_read_fw(&addr, &fw_length);
- if (ret != 0)
- return ret;
+ if (!addr || !fw_length) {
+ printf("%s: Invalid firmware data\n", phydev->dev->name);
+ return -EINVAL;
+ }
- read_crc = (addr[fw_length - 2] << 8) | addr[fw_length - 1];
+ read_crc = (addr[fw_length - 2] << 8) | addr[fw_length - 1];
calculated_crc = crc16_ccitt(0, addr, fw_length - 2);
if (read_crc != calculated_crc) {
printf("%s bad firmware crc: file 0x%04x calculated 0x%04x\n",
phydev->dev->name, read_crc, calculated_crc);
- ret = -EINVAL;
- goto done;
+ return -EINVAL;
}
/* Find the DRAM and IRAM sections within the firmware file. */
@@ -268,14 +267,14 @@ static int aquantia_upload_firmware(struct phy_device *phydev)
ret = aquantia_load_memory(phydev, DRAM_BASE_ADDR, &addr[dram_offset],
dram_size);
if (ret != 0)
- goto done;
+ return ret;
debug("loading iram 0x%08x from offset=%d size=%d\n",
IRAM_BASE_ADDR, iram_offset, iram_size);
ret = aquantia_load_memory(phydev, IRAM_BASE_ADDR, &addr[iram_offset],
iram_size);
if (ret != 0)
- goto done;
+ return ret;
/* make sure soft reset and low power mode are clear */
phy_write(phydev, MDIO_MMD_VEND1, GLOBAL_STANDARD_CONTROL, 0);
@@ -289,8 +288,22 @@ static int aquantia_upload_firmware(struct phy_device *phydev)
phy_write(phydev, MDIO_MMD_VEND1, UP_CONTROL, UP_RUN_STALL_OVERRIDE);
printf("%s firmware loading done.\n", phydev->dev->name);
-done:
+ return 0;
+}
+
+static int aquantia_upload_firmware(struct phy_device *phydev)
+{
+ int ret;
+ u8 *addr = NULL;
+ size_t fw_length = 0;
+
+ ret = aquantia_read_fw(&addr, &fw_length);
+ if (ret != 0)
+ return ret;
+
+ ret = aquantia_do_upload_firmware(phydev, addr, fw_length);
free(addr);
+
return ret;
}
#else
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v5 2/2] net: phy: aquantia: use generic firmware loader
2025-11-01 12:31 [PATCH v5 0/2] net: phy: aquantia: Switch to generic firmware loader Beiyan Yun
2025-11-01 12:31 ` [PATCH v5 1/2] net: phy: aquantia: refactor firmware upload helpers Beiyan Yun
@ 2025-11-01 12:31 ` Beiyan Yun
2025-11-15 7:48 ` [PATCH v5 0/2] net: phy: aquantia: Switch to " Beiyan Yun
2 siblings, 0 replies; 9+ messages in thread
From: Beiyan Yun @ 2025-11-01 12:31 UTC (permalink / raw)
To: u-boot
Cc: Tom Rini, Yao Zi, Marek Vasut, Beiyan Yun, Jerome Forissier,
Joe Hershberger, Lucien.Jheng, Ramon Fried, Romain Gantois,
Siddharth Vadapalli, Sky Huang, Weijie Gao
Aquantia PHYs are being used w/o SPI flash in some routers recently.
Current firmware loader only attempts to load from FS on top of MMC,
limiting the use on many devices.
Removed the old firmware loader, migrate to generic script based firmware
loader to allow a wider range and runtime override of firmware source.
(e.g., MMC, USB, UBIFS).
Tested on Buffalo WXR18000BE10P with UBIFS.
Signed-off-by: Beiyan Yun <root@infi.wang>
---
Changes in v5:
- Remove fsloader codepath
- Drop binding changes
- Make script name static
Changes in v4:
- Split firmware upload helpers change
- Reorder `aquantia_read_fw`
- Make `aquantia_read_fw` weak to allow overide
- Rename exit label in `aquantia_read_fw`
- Kconfig polish
Changes in v3:
- Select FW_LOADER with PHY_AQUANTIA_UPLOAD_FW
Changes in v2:
- Add support for script based loader
drivers/net/phy/Kconfig | 23 ++++++------
drivers/net/phy/aquantia.c | 76 ++++++++++++++------------------------
2 files changed, 39 insertions(+), 60 deletions(-)
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 018be98705a..d8845469dd5 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -91,23 +91,22 @@ menuconfig PHY_AQUANTIA
config PHY_AQUANTIA_UPLOAD_FW
bool "Aquantia firmware loading support"
depends on PHY_AQUANTIA
+ select FW_LOADER
help
- Aquantia PHYs use firmware which can be either loaded automatically
- from storage directly attached to the phy or loaded by the boot loader
- via MDIO commands. The firmware is loaded from a file, specified by
- the PHY_AQUANTIA_FW_PART and PHY_AQUANTIA_FW_NAME options.
+ Aquantia PHYs use firmware which can be either loaded automatically
+ from storage directly attached to the phy or loaded by the boot loader
+ via MDIO commands.
-config PHY_AQUANTIA_FW_PART
- string "Aquantia firmware partition"
- depends on PHY_AQUANTIA_UPLOAD_FW
- help
- Partition containing the firmware file.
+ This option enables loading the firmware using the generic
+ firmware loader framework.
-config PHY_AQUANTIA_FW_NAME
- string "Aquantia firmware filename"
+config PHY_AQUANTIA_FW_MAX_SIZE
+ hex "Max firmware size"
depends on PHY_AQUANTIA_UPLOAD_FW
+ default 0x80000
help
- Firmware filename.
+ The maximum size of the Aquantia PHY firmware. This is used to
+ allocate a buffer to load the firmware into.
config PHY_ATHEROS
bool "Atheros Ethernet PHYs support"
diff --git a/drivers/net/phy/aquantia.c b/drivers/net/phy/aquantia.c
index fc2476fb038..e0deef58f52 100644
--- a/drivers/net/phy/aquantia.c
+++ b/drivers/net/phy/aquantia.c
@@ -16,7 +16,9 @@
#include <u-boot/crc.h>
#include <malloc.h>
#include <asm/byteorder.h>
-#include <fs.h>
+#if (IS_ENABLED(CONFIG_PHY_AQUANTIA_UPLOAD_FW))
+#include <fw_loader.h>
+#endif
#define AQUNTIA_10G_CTL 0x20
#define AQUNTIA_VENDOR_P1 0xc400
@@ -127,52 +129,29 @@ struct fw_header {
#pragma pack()
-#if defined(CONFIG_PHY_AQUANTIA_UPLOAD_FW)
-static int aquantia_read_fw(u8 **fw_addr, size_t *fw_length)
+#if (IS_ENABLED(CONFIG_PHY_AQUANTIA_UPLOAD_FW))
+int __weak aquantia_read_fw(struct phy_device *phydev,
+ u8 **fw_addr, size_t *fw_length)
{
- loff_t length, read;
int ret;
- void *addr = NULL;
-
- *fw_addr = NULL;
- *fw_length = 0;
- debug("Loading Aquantia microcode from %s %s\n",
- CONFIG_PHY_AQUANTIA_FW_PART, CONFIG_PHY_AQUANTIA_FW_NAME);
- ret = fs_set_blk_dev("mmc", CONFIG_PHY_AQUANTIA_FW_PART, FS_TYPE_ANY);
- if (ret < 0)
- goto cleanup;
-
- ret = fs_size(CONFIG_PHY_AQUANTIA_FW_NAME, &length);
- if (ret < 0)
- goto cleanup;
-
- addr = malloc(length);
- if (!addr) {
- ret = -ENOMEM;
- goto cleanup;
- }
-
- ret = fs_set_blk_dev("mmc", CONFIG_PHY_AQUANTIA_FW_PART, FS_TYPE_ANY);
- if (ret < 0)
- goto cleanup;
-
- ret = fs_read(CONFIG_PHY_AQUANTIA_FW_NAME, (ulong)addr, 0, length,
- &read);
- if (ret < 0)
- goto cleanup;
+ u8 *microcode;
- *fw_addr = addr;
- *fw_length = length;
- debug("Found Aquantia microcode.\n");
+ microcode = malloc(CONFIG_PHY_AQUANTIA_FW_MAX_SIZE);
+ if (!microcode) {
+ printf("Failed to allocate memory for firmware\n");
+ return -ENOMEM;
+ }
-cleanup:
- if (ret < 0) {
- printf("loading firmware file %s %s failed with error %d\n",
- CONFIG_PHY_AQUANTIA_FW_PART,
- CONFIG_PHY_AQUANTIA_FW_NAME, ret);
- free(addr);
+ ret = request_firmware_into_buf_via_script(
+ microcode, CONFIG_PHY_AQUANTIA_FW_MAX_SIZE,
+ "aqr_phy_load_firmware", fw_length);
+ if (ret) {
+ free(microcode);
+ return ret;
}
- return ret;
+
+ *fw_addr = microcode;
+ return 1;
}
/* load data into the phy's memory */
@@ -293,16 +272,17 @@ static int aquantia_do_upload_firmware(struct phy_device *phydev,
static int aquantia_upload_firmware(struct phy_device *phydev)
{
- int ret;
+ int ret, fwrc;
u8 *addr = NULL;
- size_t fw_length = 0;
+ size_t fw_length;
- ret = aquantia_read_fw(&addr, &fw_length);
- if (ret != 0)
- return ret;
+ fwrc = aquantia_read_fw(phydev, &addr, &fw_length);
+ if (fwrc < 0)
+ return fwrc;
ret = aquantia_do_upload_firmware(phydev, addr, fw_length);
- free(addr);
+ if (fwrc > 0)
+ free(addr);
return ret;
}
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v5 0/2] net: phy: aquantia: Switch to generic firmware loader
2025-11-01 12:31 [PATCH v5 0/2] net: phy: aquantia: Switch to generic firmware loader Beiyan Yun
2025-11-01 12:31 ` [PATCH v5 1/2] net: phy: aquantia: refactor firmware upload helpers Beiyan Yun
2025-11-01 12:31 ` [PATCH v5 2/2] net: phy: aquantia: use generic firmware loader Beiyan Yun
@ 2025-11-15 7:48 ` Beiyan Yun
2025-11-26 14:22 ` Jerome Forissier
2 siblings, 1 reply; 9+ messages in thread
From: Beiyan Yun @ 2025-11-15 7:48 UTC (permalink / raw)
To: Beiyan Yun
Cc: u-boot, Tom Rini, Zi Yao, Marek Vasut, Jerome Forissier,
Joe Hershberger, Lucien.Jheng, Ramon Fried, Romain Gantois,
Siddharth Vadapalli, Sky Huang, Weijie Gao
Hi all,
Gentle ping. Any comments on this patch?
Thanks,
Yun
> Beiyan Yun <root@infi.wang>於2025年11月1日 下午8:34寫道：
>
>
> Hi,
>
> This patch series refactors the Aquantia PHY firmware loader to use
> the generic fwloader framework.
>
> The existing loader is limited to loading firmware from an MMC device,
> which restricts its use on many devices (e.g., routers) that may use
> other storage like USB or have a UBIFS root filesystem. Migrating to the
> generic firmware loader allows firmware to be sourced from any backend
> supported by the fwloader scripting framework.
>
> The series is structured as follows:
> - The first patch prepares current loading code for fwloader.
> - The second and main patch replaces the custom loader with generic one.
>
> This change has been tested on a Buffalo WXR18000BE10P router, loading
> firmware from a UBIFS volume for Marvell CUX3410.
>
> Changes in v5:
> - Remove fsloader codepath
> - Drop binding changes
> - Make script name static
> - Minor refactor
>
> Changes in v4:
> - Split firmware upload helpers change
> - Reorder `aquantia_read_fw`
> - Make `aquantia_read_fw` weak to allow overide
> - Rename exit label in `aquantia_read_fw`
> - Kconfig polish
>
> Changes in v3:
> - Select FW_LOADER with PHY_AQUANTIA_UPLOAD_FW
>
> Changes in v2:
> - Add support for script based loader
>
> Beiyan Yun (2):
> net: phy: aquantia: refactor firmware upload helpers
> net: phy: aquantia: use generic firmware loader
>
> drivers/net/phy/Kconfig | 23 ++++-----
> drivers/net/phy/aquantia.c | 103 +++++++++++++++++--------------------
> 2 files changed, 59 insertions(+), 67 deletions(-)
>
> --
> 2.47.3
>
> base-commit: 62b45e82bdbf703571450e97f605893fe0d50530
> branch: aquantia-fsloader-v5
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 0/2] net: phy: aquantia: Switch to generic firmware loader
2025-11-15 7:48 ` [PATCH v5 0/2] net: phy: aquantia: Switch to " Beiyan Yun
@ 2025-11-26 14:22 ` Jerome Forissier
2025-11-26 14:24 ` Marek Vasut
0 siblings, 1 reply; 9+ messages in thread
From: Jerome Forissier @ 2025-11-26 14:22 UTC (permalink / raw)
To: Beiyan Yun
Cc: u-boot, Tom Rini, Zi Yao, Marek Vasut, Joe Hershberger,
Lucien.Jheng, Ramon Fried, Romain Gantois, Siddharth Vadapalli,
Sky Huang, Weijie Gao
Hi Yun,
On 11/15/25 08:48, Beiyan Yun wrote:
> Hi all,
>
> Gentle ping. Any comments on this patch?
Since there is no comment I will pick it up and move it to my net-next queue.
Thanks!
--
Jerome
>
> Thanks,
> Yun
>
>> Beiyan Yun <root@infi.wang>於2025年11月1日 下午8:34寫道：
>>
>>
>> Hi,
>>
>> This patch series refactors the Aquantia PHY firmware loader to use
>> the generic fwloader framework.
>>
>> The existing loader is limited to loading firmware from an MMC device,
>> which restricts its use on many devices (e.g., routers) that may use
>> other storage like USB or have a UBIFS root filesystem. Migrating to the
>> generic firmware loader allows firmware to be sourced from any backend
>> supported by the fwloader scripting framework.
>>
>> The series is structured as follows:
>> - The first patch prepares current loading code for fwloader.
>> - The second and main patch replaces the custom loader with generic one.
>>
>> This change has been tested on a Buffalo WXR18000BE10P router, loading
>> firmware from a UBIFS volume for Marvell CUX3410.
>>
>> Changes in v5:
>> - Remove fsloader codepath
>> - Drop binding changes
>> - Make script name static
>> - Minor refactor
>>
>> Changes in v4:
>> - Split firmware upload helpers change
>> - Reorder `aquantia_read_fw`
>> - Make `aquantia_read_fw` weak to allow overide
>> - Rename exit label in `aquantia_read_fw`
>> - Kconfig polish
>>
>> Changes in v3:
>> - Select FW_LOADER with PHY_AQUANTIA_UPLOAD_FW
>>
>> Changes in v2:
>> - Add support for script based loader
>>
>> Beiyan Yun (2):
>> net: phy: aquantia: refactor firmware upload helpers
>> net: phy: aquantia: use generic firmware loader
>>
>> drivers/net/phy/Kconfig | 23 ++++-----
>> drivers/net/phy/aquantia.c | 103 +++++++++++++++++--------------------
>> 2 files changed, 59 insertions(+), 67 deletions(-)
>>
>> --
>> 2.47.3
>>
>> base-commit: 62b45e82bdbf703571450e97f605893fe0d50530
>> branch: aquantia-fsloader-v5
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 0/2] net: phy: aquantia: Switch to generic firmware loader
2025-11-26 14:22 ` Jerome Forissier
@ 2025-11-26 14:24 ` Marek Vasut
2025-11-26 14:28 ` Jerome Forissier
2025-11-29 3:10 ` Beiyan Yun
0 siblings, 2 replies; 9+ messages in thread
From: Marek Vasut @ 2025-11-26 14:24 UTC (permalink / raw)
To: Jerome Forissier, Beiyan Yun
Cc: u-boot, Tom Rini, Zi Yao, Marek Vasut, Joe Hershberger,
Lucien.Jheng, Ramon Fried, Romain Gantois, Siddharth Vadapalli,
Sky Huang, Weijie Gao
On 11/26/25 3:22 PM, Jerome Forissier wrote:
> Hi Yun,
>
> On 11/15/25 08:48, Beiyan Yun wrote:
>> Hi all,
>>
>> Gentle ping. Any comments on this patch?
>
> Since there is no comment I will pick it up and move it to my net-next queue.
Ideally the driver should use one firmware loader, not both.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 0/2] net: phy: aquantia: Switch to generic firmware loader
2025-11-26 14:24 ` Marek Vasut
@ 2025-11-26 14:28 ` Jerome Forissier
2025-11-29 3:10 ` Beiyan Yun
1 sibling, 0 replies; 9+ messages in thread
From: Jerome Forissier @ 2025-11-26 14:28 UTC (permalink / raw)
To: Marek Vasut, Beiyan Yun
Cc: u-boot, Tom Rini, Zi Yao, Marek Vasut, Joe Hershberger,
Lucien.Jheng, Ramon Fried, Romain Gantois, Siddharth Vadapalli,
Sky Huang, Weijie Gao
On 11/26/25 15:24, Marek Vasut wrote:
> On 11/26/25 3:22 PM, Jerome Forissier wrote:
>> Hi Yun,
>>
>> On 11/15/25 08:48, Beiyan Yun wrote:
>>> Hi all,
>>>
>>> Gentle ping. Any comments on this patch?
>>
>> Since there is no comment I will pick it up and move it to my net-next queue.
>
> Ideally the driver should use one firmware loader, not both.
Is this a NACK or can things be improved later on?
--
Jerome
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 0/2] net: phy: aquantia: Switch to generic firmware loader
2025-11-26 14:24 ` Marek Vasut
2025-11-26 14:28 ` Jerome Forissier
@ 2025-11-29 3:10 ` Beiyan Yun
2025-11-29 3:47 ` Marek Vasut
1 sibling, 1 reply; 9+ messages in thread
From: Beiyan Yun @ 2025-11-29 3:10 UTC (permalink / raw)
To: Marek Vasut
Cc: Jerome Forissier, u-boot, Tom Rini, Zi Yao, Marek Vasut,
Joe Hershberger, Lucien.Jheng, Ramon Fried, Romain Gantois,
Siddharth Vadapalli, Sky Huang, Weijie Gao
Hi Marek,
> On 26 Nov 2025, at 10:24 PM, Marek Vasut <marek.vasut@mailbox.org> wrote:
>
> On 11/26/25 3:22 PM, Jerome Forissier wrote:
>> Hi Yun,
>> On 11/15/25 08:48, Beiyan Yun wrote:
>>> Hi all,
>>>
>>> Gentle ping. Any comments on this patch?
>> Since there is no comment I will pick it up and move it to my net-next queue.
>
> Ideally the driver should use one firmware loader, not both.
v5 removed fsloader, only the fwloader codepath is used.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v5 0/2] net: phy: aquantia: Switch to generic firmware loader
2025-11-29 3:10 ` Beiyan Yun
@ 2025-11-29 3:47 ` Marek Vasut
0 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2025-11-29 3:47 UTC (permalink / raw)
To: Beiyan Yun
Cc: Jerome Forissier, u-boot, Tom Rini, Zi Yao, Marek Vasut,
Joe Hershberger, Lucien.Jheng, Ramon Fried, Romain Gantois,
Siddharth Vadapalli, Sky Huang, Weijie Gao
On 11/29/25 4:10 AM, Beiyan Yun wrote:
Hello Yun,
>> On 26 Nov 2025, at 10:24 PM, Marek Vasut <marek.vasut@mailbox.org> wrote:
>>
>> On 11/26/25 3:22 PM, Jerome Forissier wrote:
>>> Hi Yun,
>>> On 11/15/25 08:48, Beiyan Yun wrote:
>>>> Hi all,
>>>>
>>>> Gentle ping. Any comments on this patch?
>>> Since there is no comment I will pick it up and move it to my net-next queue.
>>
>> Ideally the driver should use one firmware loader, not both.
>
> v5 removed fsloader, only the fwloader codepath is used.
Oh, that's nice, thank you.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-11-29 3:47 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-01 12:31 [PATCH v5 0/2] net: phy: aquantia: Switch to generic firmware loader Beiyan Yun
2025-11-01 12:31 ` [PATCH v5 1/2] net: phy: aquantia: refactor firmware upload helpers Beiyan Yun
2025-11-01 12:31 ` [PATCH v5 2/2] net: phy: aquantia: use generic firmware loader Beiyan Yun
2025-11-15 7:48 ` [PATCH v5 0/2] net: phy: aquantia: Switch to " Beiyan Yun
2025-11-26 14:22 ` Jerome Forissier
2025-11-26 14:24 ` Marek Vasut
2025-11-26 14:28 ` Jerome Forissier
2025-11-29 3:10 ` Beiyan Yun
2025-11-29 3:47 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox