public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Brian Sune <briansune@gmail.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v6] Add optimized Makefile support for SoCFPGA handoff
Date: Tue, 4 Nov 2025 11:51:23 -0600	[thread overview]
Message-ID: <20251104175123.GE6688@bill-the-cat> (raw)
In-Reply-To: <20251104010003.525-1-briansune@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]

On Tue, Nov 04, 2025 at 09:00:03AM +0800, Brian Sune wrote:
> Add optimized Makefile support for SoCFPGA handoff
> 
> - Introduce socfpga_g5_hanoff_prepare target in U-Boot Makefile
> - Detects Altera/Intel SoCFPGA boards from .config
> - Combines vendor/board extraction into a single shell call
> - Checks for hps_isw_handoff folder and .hiof files
> - Uses ls -d instead of find for faster folder detection
> - Runs BSP generator script only if files exist
> - Non-blocking: continues if handoff folder or files are missing
> - HANDOFF_PATH user define allows overriding auto-detected folder
> - Minimizes subshells and other slow constructs for faster CI
> 
> Signed-off-by: Brian Sune <briansune@gmail.com>
> ---
>  Makefile | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 51 insertions(+), 2 deletions(-)

This should be able to reside in arch/arm/mach-socfpga/config.mk and so
it should be moved there. It might need to be done under "archprepare".
That would also let us gate even trying it with an ifeq, like we do
currently. I also don't see that you tested this "make O=/tmp/somedir"
(which is not the HANDOFF_PATH thing) and I expect it doesn't work there
as it references ".config" and not "$(objdir)/.config".

Finally, since you mentioned AIs in other emails, we do not yet have a
formal policy for or against their usage in this project (it is
something we need to discuss) but at a minimum the Fedora policy makes
sense to me if using one:
https://docs.fedoraproject.org/en-US/council/policy/ai-contribution-policy/

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-11-04 17:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04  1:00 [PATCH v6] Add optimized Makefile support for SoCFPGA handoff Brian Sune
2025-11-04 17:51 ` Tom Rini [this message]
2025-11-04 20:42   ` Sune Brian
2025-11-04 21:18     ` Tom Rini
2025-11-04 21:33       ` Sune Brian
2025-11-04 22:37         ` Tom Rini
2025-11-04 22:48           ` Sune Brian
2025-11-04 23:07             ` Tom Rini
2025-11-04 23:30               ` Sune Brian
2025-11-04 21:11   ` Sune Brian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251104175123.GE6688@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=briansune@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox