public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH 0/2] Add Radxa ROCK 5B+ defconfig
@ 2025-11-04 18:25 Bryan Hinton
  2025-11-04 18:25 ` [PATCH 1/2] configs: Add rock5b_plus-rk3588_defconfig Bryan Hinton
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Bryan Hinton @ 2025-11-04 18:25 UTC (permalink / raw)
  To: u-boot; +Cc: trini, Bryan Hinton

This series adds initial support for the Radxa ROCK 5B+ (RK3588).
It introduces a new defconfig that mirrors the ROCK 5B baseline
while building from the vendored upstream DTS snapshot
(rockchip/rk3588-rock-5b-plus).

Tested on ROCK 5B+ rev 1.2 (32 GB LPDDR5) booting U-Boot from microSD card.
Build used:
  - TPL rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.19.bin
  - BL31 rk3588_bl31_v1.51.elf
  - GCC 15.1.0 toolchain

The eMMC controller enumerates even without a soldered module. SPL → U-Boot
boot verified; SD and USB enumeration work as expected.

Thanks,
Bryan

---
Bryan Hinton (2):
  configs: Add rock5b_plus-rk3588_defconfig
  MAINTAINERS: Add entry for Radxa ROCK 5B+

 MAINTAINERS                          |   5 ++
 configs/rock5b_plus-rk3588_defconfig | 118 +++++++++++++++++++++++++++
 2 files changed, 123 insertions(+)
 create mode 100644 configs/rock5b_plus-rk3588_defconfig

-- 
2.51.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/2] configs: Add rock5b_plus-rk3588_defconfig
  2025-11-04 18:25 [PATCH 0/2] Add Radxa ROCK 5B+ defconfig Bryan Hinton
@ 2025-11-04 18:25 ` Bryan Hinton
  2025-11-04 18:29   ` Tom Rini
  2025-11-04 18:25 ` [PATCH 2/2] MAINTAINERS: Add entry for Radxa ROCK 5B+ Bryan Hinton
  2025-11-04 19:04 ` [PATCH 0/2] Add Radxa ROCK 5B+ defconfig Jonas Karlman
  2 siblings, 1 reply; 8+ messages in thread
From: Bryan Hinton @ 2025-11-04 18:25 UTC (permalink / raw)
  To: u-boot; +Cc: trini, Bryan Hinton

Add initial defconfig for the Radxa ROCK 5B+ (RK3588), tested on board
revision 1.2 with 32 GB LPDDR5. This mirrors the existing ROCK 5B baseline
and uses the DTS from U-Boot’s vendored Linux snapshot
(rockchip/rk3588-rock-5b-plus).

Build and test details:
  - U-Boot build: 2026.01-rc1-00232-g0673831a738b-dirty (Nov 04 2025 - 21:18:07 -0600)
  - Toolchain: aarch64-linux-gnu-gcc (GCC) 15.1.0
  - DDR TPL: rkbin/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.19.bin
  - BL31: rkbin/bin/rk35/rk3588_bl31_v1.51.elf
  - Boot medium: microSD card (U-Boot image written via dd)
  - SoC: RK3588 (8× Cortex-A76/A55)
  - DRAM: 32 GiB LPDDR5 detected
  - eMMC socket present but module not soldered (controller still detected)
  - Verified: SPL → U-Boot prompt
  - `mmc list` shows SD + eMMC controllers
  - USB EHCI/XHCI enumeration works (`usb tree`)
  - Control FDT present (`fdt addr ${fdtcontroladdr}; fdt print / model`)
  - Default environment: `fdtfile=rockchip/rk3588-rock-5b-plus.dtb`

This configuration reuses the ROCK 5B base defconfig with minimal adjustments
and builds from the upstream DTS snapshot. Follow-up patches will enable
NVMe, Ethernet, and saveenv support.

Signed-off-by: Bryan Hinton <bryan@bryanhinton.com>
---
 configs/rock5b_plus-rk3588_defconfig | 118 +++++++++++++++++++++++++++
 1 file changed, 118 insertions(+)
 create mode 100644 configs/rock5b_plus-rk3588_defconfig

diff --git a/configs/rock5b_plus-rk3588_defconfig b/configs/rock5b_plus-rk3588_defconfig
new file mode 100644
index 00000000000..be406180b64
--- /dev/null
+++ b/configs/rock5b_plus-rk3588_defconfig
@@ -0,0 +1,118 @@
+CONFIG_ARM=y
+CONFIG_SKIP_LOWLEVEL_INIT=y
+CONFIG_SYS_HAS_NONCACHED_MEMORY=y
+CONFIG_COUNTER_FREQUENCY=24000000
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_SF_DEFAULT_SPEED=24000000
+CONFIG_SF_DEFAULT_MODE=0x2000
+CONFIG_ROCKCHIP_RK3588=y
+CONFIG_ROCKCHIP_SPI_IMAGE=y
+CONFIG_SPL_SERIAL=y
+CONFIG_TARGET_ROCK5B_RK3588=y
+CONFIG_SYS_LOAD_ADDR=0xc00800
+CONFIG_SF_DEFAULT_BUS=5
+CONFIG_DEBUG_UART_BASE=0xFEB50000
+CONFIG_DEBUG_UART_CLOCK=24000000
+CONFIG_SPL_SPI_FLASH_SUPPORT=y
+CONFIG_SPL_SPI=y
+CONFIG_PCI=y
+CONFIG_DEBUG_UART=y
+CONFIG_AHCI=y
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_SPL_FIT_SIGNATURE=y
+CONFIG_SPL_LOAD_FIT=y
+CONFIG_LEGACY_IMAGE_FORMAT=y
+CONFIG_OF_BOARD_SETUP=y
+# CONFIG_DISPLAY_CPUINFO is not set
+CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_SPL_MAX_SIZE=0x40000
+# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
+CONFIG_SPL_SPI_LOAD=y
+CONFIG_SYS_SPI_U_BOOT_OFFS=0x60000
+CONFIG_SPL_ATF=y
+CONFIG_CMD_TCPM=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_GPT=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_PCI=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_ROCKUSB=y
+CONFIG_CMD_USB_MASS_STORAGE=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_REGULATOR=y
+# CONFIG_SPL_DOS_PARTITION is not set
+CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_LIVE=y
+CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
+CONFIG_SPL_DM_SEQ_ALIAS=y
+CONFIG_SPL_REGMAP=y
+CONFIG_SPL_SYSCON=y
+CONFIG_AHCI_PCI=y
+CONFIG_DWC_AHCI=y
+CONFIG_SPL_CLK=y
+# CONFIG_USB_FUNCTION_FASTBOOT is not set
+CONFIG_ROCKCHIP_GPIO=y
+CONFIG_SYS_I2C_ROCKCHIP=y
+CONFIG_LED=y
+CONFIG_LED_GPIO=y
+CONFIG_MISC=y
+CONFIG_SUPPORT_EMMC_RPMB=y
+CONFIG_MMC_DW=y
+CONFIG_MMC_DW_ROCKCHIP=y
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_SDMA=y
+CONFIG_MMC_SDHCI_ROCKCHIP=y
+CONFIG_SPI_FLASH_SFDP_SUPPORT=y
+CONFIG_SPI_FLASH_MACRONIX=y
+CONFIG_SPI_FLASH_XTX=y
+CONFIG_PHYLIB=y
+CONFIG_RTL8169=y
+CONFIG_NVME_PCI=y
+CONFIG_PCIE_DW_ROCKCHIP=y
+CONFIG_PHY_ROCKCHIP_INNO_USB2=y
+CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
+CONFIG_PHY_ROCKCHIP_USBDP=y
+CONFIG_SPL_PINCTRL=y
+CONFIG_PWM_ROCKCHIP=y
+CONFIG_SPL_RAM=y
+CONFIG_SCSI=y
+CONFIG_BAUDRATE=1500000
+CONFIG_DEBUG_UART_SHIFT=2
+CONFIG_SYS_NS16550_MEM32=y
+CONFIG_ROCKCHIP_SFC=y
+CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GENERIC=y
+CONFIG_SPL_USB_DWC3_GENERIC=y
+CONFIG_TYPEC_TCPM=y
+CONFIG_TYPEC_FUSB302=y
+CONFIG_USB_HOST_ETHER=y
+CONFIG_USB_ETHER_ASIX=y
+CONFIG_USB_ETHER_ASIX88179=y
+CONFIG_USB_ETHER_LAN75XX=y
+CONFIG_USB_ETHER_LAN78XX=y
+CONFIG_USB_ETHER_MCS7830=y
+CONFIG_USB_ETHER_RTL8152=y
+CONFIG_USB_ETHER_SMSC95XX=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_FUNCTION_ROCKUSB=y
+CONFIG_ERRNO_STR=y
+CONFIG_OF_UPSTREAM=y
+CONFIG_OF_SEPARATE=y
+# CONFIG_MULTI_DTB_FIT is not set
+CONFIG_DEFAULT_DEVICE_TREE="rockchip/rk3588-rock-5b-plus"
+CONFIG_OF_LIST="rockchip/rk3588-rock-5b-plus"
+CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-rock-5b-plus.dtb"
+
+# Minimal first version; follow-ups can add NVMe, Ethernet, saveenv
+# CONFIG_CMD_SAVEENV is not set
+# CONFIG_NVME is not set
-- 
2.51.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] MAINTAINERS: Add entry for Radxa ROCK 5B+
  2025-11-04 18:25 [PATCH 0/2] Add Radxa ROCK 5B+ defconfig Bryan Hinton
  2025-11-04 18:25 ` [PATCH 1/2] configs: Add rock5b_plus-rk3588_defconfig Bryan Hinton
@ 2025-11-04 18:25 ` Bryan Hinton
  2025-11-04 19:04 ` [PATCH 0/2] Add Radxa ROCK 5B+ defconfig Jonas Karlman
  2 siblings, 0 replies; 8+ messages in thread
From: Bryan Hinton @ 2025-11-04 18:25 UTC (permalink / raw)
  To: u-boot; +Cc: trini, Bryan Hinton

Signed-off-by: Bryan Hinton <bryan@bryanhinton.com>
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 8c7d0e0ab2f..bae65d7c651 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1974,3 +1974,8 @@ T:	git https://source.denx.de/u-boot/u-boot.git
 F:	configs/tools-only_defconfig
 F:	*
 F:	*/
+
+RADXA ROCK 5B+
+M:    Bryan Hinton <bryan@bryanhinton.com>
+S:    Maintained
+F:    configs/rock5b_plus-rk3588_defconfig
-- 
2.51.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] configs: Add rock5b_plus-rk3588_defconfig
  2025-11-04 18:25 ` [PATCH 1/2] configs: Add rock5b_plus-rk3588_defconfig Bryan Hinton
@ 2025-11-04 18:29   ` Tom Rini
  0 siblings, 0 replies; 8+ messages in thread
From: Tom Rini @ 2025-11-04 18:29 UTC (permalink / raw)
  To: Bryan Hinton; +Cc: u-boot

[-- Attachment #1: Type: text/plain, Size: 2247 bytes --]

On Tue, Nov 04, 2025 at 12:25:11PM -0600, Bryan Hinton wrote:
> Add initial defconfig for the Radxa ROCK 5B+ (RK3588), tested on board
> revision 1.2 with 32 GB LPDDR5. This mirrors the existing ROCK 5B baseline
> and uses the DTS from U-Boot’s vendored Linux snapshot
> (rockchip/rk3588-rock-5b-plus).
> 
> Build and test details:
>   - U-Boot build: 2026.01-rc1-00232-g0673831a738b-dirty (Nov 04 2025 - 21:18:07 -0600)
>   - Toolchain: aarch64-linux-gnu-gcc (GCC) 15.1.0
>   - DDR TPL: rkbin/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.19.bin
>   - BL31: rkbin/bin/rk35/rk3588_bl31_v1.51.elf
>   - Boot medium: microSD card (U-Boot image written via dd)
>   - SoC: RK3588 (8× Cortex-A76/A55)
>   - DRAM: 32 GiB LPDDR5 detected
>   - eMMC socket present but module not soldered (controller still detected)
>   - Verified: SPL → U-Boot prompt
>   - `mmc list` shows SD + eMMC controllers
>   - USB EHCI/XHCI enumeration works (`usb tree`)
>   - Control FDT present (`fdt addr ${fdtcontroladdr}; fdt print / model`)
>   - Default environment: `fdtfile=rockchip/rk3588-rock-5b-plus.dtb`
> 
> This configuration reuses the ROCK 5B base defconfig with minimal adjustments
> and builds from the upstream DTS snapshot. Follow-up patches will enable
> NVMe, Ethernet, and saveenv support.
> 
> Signed-off-by: Bryan Hinton <bryan@bryanhinton.com>
> ---
>  configs/rock5b_plus-rk3588_defconfig | 118 +++++++++++++++++++++++++++
>  1 file changed, 118 insertions(+)
>  create mode 100644 configs/rock5b_plus-rk3588_defconfig

A thing we don't talk about enough is that defconfig files can use
"#include". So how much is different here from
configs/rock5b-rk3588_defconfig and could we instead do something like
configs/rpi_4_acpi_defconfig does to just augment an existing defconfig?
Next, this needs to update a MAINTAINERS file at the same time in order
for CI to pass.

[snip]
> +# Minimal first version; follow-ups can add NVMe, Ethernet, saveenv
> +# CONFIG_CMD_SAVEENV is not set
> +# CONFIG_NVME is not set

Please don't include that, and make sure this is the output from a "make
savedefconfig" so that we don't have noise in the file later when it's
resynced automatically. Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] Add Radxa ROCK 5B+ defconfig
  2025-11-04 18:25 [PATCH 0/2] Add Radxa ROCK 5B+ defconfig Bryan Hinton
  2025-11-04 18:25 ` [PATCH 1/2] configs: Add rock5b_plus-rk3588_defconfig Bryan Hinton
  2025-11-04 18:25 ` [PATCH 2/2] MAINTAINERS: Add entry for Radxa ROCK 5B+ Bryan Hinton
@ 2025-11-04 19:04 ` Jonas Karlman
  2025-11-04 19:43   ` Bryan Hinton
  2 siblings, 1 reply; 8+ messages in thread
From: Jonas Karlman @ 2025-11-04 19:04 UTC (permalink / raw)
  To: Bryan Hinton; +Cc: trini@konsulko.com, u-boot@lists.denx.de

Hi Bryan,

On 11/4/2025 7:25 PM, Bryan Hinton wrote:
> This series adds initial support for the Radxa ROCK 5B+ (RK3588).
> It introduces a new defconfig that mirrors the ROCK 5B baseline
> while building from the vendored upstream DTS snapshot
> (rockchip/rk3588-rock-5b-plus).

Please take a look at the existing "rockchip: Add support for ROCK 5B+"
series at [1], it extends the rock5b target to also support the 5B+
variant instead of adding a new defconfig target.

[1] https://patchwork.ozlabs.org/cover/2118033/

Regards,
Jonas

> 
> Tested on ROCK 5B+ rev 1.2 (32 GB LPDDR5) booting U-Boot from microSD card.
> Build used:
>   - TPL rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.19.bin
>   - BL31 rk3588_bl31_v1.51.elf
>   - GCC 15.1.0 toolchain
> 
> The eMMC controller enumerates even without a soldered module. SPL → U-Boot
> boot verified; SD and USB enumeration work as expected.
> 
> Thanks,
> Bryan
> 
> ---
> Bryan Hinton (2):
>   configs: Add rock5b_plus-rk3588_defconfig
>   MAINTAINERS: Add entry for Radxa ROCK 5B+
> 
>  MAINTAINERS                          |   5 ++
>  configs/rock5b_plus-rk3588_defconfig | 118 +++++++++++++++++++++++++++
>  2 files changed, 123 insertions(+)
>  create mode 100644 configs/rock5b_plus-rk3588_defconfig
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] Add Radxa ROCK 5B+ defconfig
  2025-11-04 19:04 ` [PATCH 0/2] Add Radxa ROCK 5B+ defconfig Jonas Karlman
@ 2025-11-04 19:43   ` Bryan Hinton
  2025-11-04 19:58     ` Jonas Karlman
  0 siblings, 1 reply; 8+ messages in thread
From: Bryan Hinton @ 2025-11-04 19:43 UTC (permalink / raw)
  To: Jonas Karlman; +Cc: trini, u-boot

Thanks, I did see that. When I pulled mainline master, I only saw the 5b defconfig and dtsi includes in arch/arm/dts. The plus dts file was in dts/upstream/src/arm64/rockchip and appeared to mirror the dts configuration in Linux mainline arch/arm64/boot/dts/rockchip for the 5b+.  I tried the dts configuration a few different ways and reduced it to just including the 5b config per Tom in the patches just sent.
I’m doing other testing on the board related to memory and timing, and hope to submit some more mainline contributions in the future.

Which TPL do you use for testing the rock5b+?


> On Nov 4, 2025, at 1:04 PM, Jonas Karlman <jonas@kwiboo.se> wrote:
> 
> Hi Bryan,
> 
>> On 11/4/2025 7:25 PM, Bryan Hinton wrote:
>> This series adds initial support for the Radxa ROCK 5B+ (RK3588).
>> It introduces a new defconfig that mirrors the ROCK 5B baseline
>> while building from the vendored upstream DTS snapshot
>> (rockchip/rk3588-rock-5b-plus).
> 
> Please take a look at the existing "rockchip: Add support for ROCK 5B+"
> series at [1], it extends the rock5b target to also support the 5B+
> variant instead of adding a new defconfig target.
> 
> [1] https://patchwork.ozlabs.org/cover/2118033/
> 
> Regards,
> Jonas
> 
>> 
>> Tested on ROCK 5B+ rev 1.2 (32 GB LPDDR5) booting U-Boot from microSD card.
>> Build used:
>>  - TPL rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.19.bin
>>  - BL31 rk3588_bl31_v1.51.elf
>>  - GCC 15.1.0 toolchain
>> 
>> The eMMC controller enumerates even without a soldered module. SPL → U-Boot
>> boot verified; SD and USB enumeration work as expected.
>> 
>> Thanks,
>> Bryan
>> 
>> ---
>> Bryan Hinton (2):
>>  configs: Add rock5b_plus-rk3588_defconfig
>>  MAINTAINERS: Add entry for Radxa ROCK 5B+
>> 
>> MAINTAINERS                          |   5 ++
>> configs/rock5b_plus-rk3588_defconfig | 118 +++++++++++++++++++++++++++
>> 2 files changed, 123 insertions(+)
>> create mode 100644 configs/rock5b_plus-rk3588_defconfig
>> 
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] Add Radxa ROCK 5B+ defconfig
  2025-11-04 19:43   ` Bryan Hinton
@ 2025-11-04 19:58     ` Jonas Karlman
  2025-11-04 21:23       ` Bryan Hinton
  0 siblings, 1 reply; 8+ messages in thread
From: Jonas Karlman @ 2025-11-04 19:58 UTC (permalink / raw)
  To: Bryan Hinton; +Cc: trini, u-boot

Hi Bryan,

On 11/4/2025 8:43 PM, Bryan Hinton wrote:
> Thanks, I did see that. When I pulled mainline master, I only saw the 5b
> defconfig and dtsi includes in arch/arm/dts. The plus dts file was in
> dts/upstream/src/arm64/rockchip and appeared to mirror the dts
> configuration in Linux mainline arch/arm64/boot/dts/rockchip for the 5b+.
> I tried the dts configuration a few different ways and reduced it to just
> including the 5b config per Tom in the patches just sent.
> I’m doing other testing on the board related to memory and timing, and
> hope to submit some more mainline contributions in the future.

Please try the existing series and if possible review it instead of
sending a new conflicting series :-)

The plan is to use a single rock5b defconfig target for both 5B and 5B+.
And in the future the ROCK 5T should also be able to the same target.

> 
> Which TPL do you use for testing the rock5b+?

The latest ddr bin from rkbin at the time when my series was sent back
in July and August when my series was sent, should have been the
v1.19.bin blob. Did you have an issue with a TPL blob using my series?

With my series applied you should be able to build the rock5b target
and when booting on a 5B+ you should be able to see something like

  Model: Radxa ROCK 5B+
  SoC:   RK3588

and this will indicate that the 5B+ device tree is correctly used.

Regards,
Jonas

> 
> 
>> On Nov 4, 2025, at 1:04 PM, Jonas Karlman <jonas@kwiboo.se> wrote:
>>
>> Hi Bryan,
>>
>>> On 11/4/2025 7:25 PM, Bryan Hinton wrote:
>>> This series adds initial support for the Radxa ROCK 5B+ (RK3588).
>>> It introduces a new defconfig that mirrors the ROCK 5B baseline
>>> while building from the vendored upstream DTS snapshot
>>> (rockchip/rk3588-rock-5b-plus).
>>
>> Please take a look at the existing "rockchip: Add support for ROCK 5B+"
>> series at [1], it extends the rock5b target to also support the 5B+
>> variant instead of adding a new defconfig target.
>>
>> [1] https://patchwork.ozlabs.org/cover/2118033/
>>
>> Regards,
>> Jonas
>>
>>>
>>> Tested on ROCK 5B+ rev 1.2 (32 GB LPDDR5) booting U-Boot from microSD card.
>>> Build used:
>>>  - TPL rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.19.bin
>>>  - BL31 rk3588_bl31_v1.51.elf
>>>  - GCC 15.1.0 toolchain
>>>
>>> The eMMC controller enumerates even without a soldered module. SPL → U-Boot
>>> boot verified; SD and USB enumeration work as expected.
>>>
>>> Thanks,
>>> Bryan
>>>
>>> ---
>>> Bryan Hinton (2):
>>>  configs: Add rock5b_plus-rk3588_defconfig
>>>  MAINTAINERS: Add entry for Radxa ROCK 5B+
>>>
>>> MAINTAINERS                          |   5 ++
>>> configs/rock5b_plus-rk3588_defconfig | 118 +++++++++++++++++++++++++++
>>> 2 files changed, 123 insertions(+)
>>> create mode 100644 configs/rock5b_plus-rk3588_defconfig
>>>
>>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] Add Radxa ROCK 5B+ defconfig
  2025-11-04 19:58     ` Jonas Karlman
@ 2025-11-04 21:23       ` Bryan Hinton
  0 siblings, 0 replies; 8+ messages in thread
From: Bryan Hinton @ 2025-11-04 21:23 UTC (permalink / raw)
  To: Jonas Karlman; +Cc: trini, u-boot


> On Nov 4, 2025, at 1:58 PM, Jonas Karlman <jonas@kwiboo.se> wrote:
> 
> Hi Bryan,
> 
>> On 11/4/2025 8:43 PM, Bryan Hinton wrote:
>> Thanks, I did see that. When I pulled mainline master, I only saw the 5b
>> defconfig and dtsi includes in arch/arm/dts. The plus dts file was in
>> dts/upstream/src/arm64/rockchip and appeared to mirror the dts
>> configuration in Linux mainline arch/arm64/boot/dts/rockchip for the 5b+.
>> I tried the dts configuration a few different ways and reduced it to just
>> including the 5b config per Tom in the patches just sent.
>> I’m doing other testing on the board related to memory and timing, and
>> hope to submit some more mainline contributions in the future.
> 
> Please try the existing series and if possible review it instead of
> sending a new conflicting series :-)
> 
I reviewed your sdram and configuration changes for the patch you sent and rebuilt u-boot with those changes applied from dts/upstream.

> The plan is to use a single rock5b defconfig target for both 5B and 5B+.
> And in the future the ROCK 5T should also be able to the same target.

ok. I tested various compiles of u-boot from radx, collabora, armbian, and u-boot mainline. The different builds and device trees are not consistent for the 5b and 5b+ boards so getting everything under a single defconfig would be great.

>> Which TPL do you use for testing the rock5b+?
> 
> The latest ddr bin from rkbin at the time when my series was sent back
> in July and August when my series was sent, should have been the
> v1.19.bin blob. Did you have an issue with a TPL blob using my series?
> 
I used the official blob referenced above and not all of the peripherals and bus power up properly. I noted that there are variations of the TPL binary in different public repositories with varying memory clock settings based on the file name descriptions, with the original file referenced above implying lp5_2400MHz.



> With my series applied you should be able to build the rock5b target
> and when booting on a 5B+ you should be able to see something like
> 
> Model: Radxa ROCK 5B+
> SoC:   RK3588
> 
> and this will indicate that the 5B+ device tree is correctly used.
> 
Yes, I applied your v2 series patches and re-built.  I have a boot log from the u-boot build for your patches. I will send that as a reply to the original thread.  

As you probably know,  peripheral support on this board appears to be spread across vendor branches.


> Regards,
> Jonas
> 
>> 
>> 
>>>> On Nov 4, 2025, at 1:04 PM, Jonas Karlman <jonas@kwiboo.se> wrote:
>>> 
>>> Hi Bryan,
>>> 
>>>> On 11/4/2025 7:25 PM, Bryan Hinton wrote:
>>>> This series adds initial support for the Radxa ROCK 5B+ (RK3588).
>>>> It introduces a new defconfig that mirrors the ROCK 5B baseline
>>>> while building from the vendored upstream DTS snapshot
>>>> (rockchip/rk3588-rock-5b-plus).
>>> 
>>> Please take a look at the existing "rockchip: Add support for ROCK 5B+"
>>> series at [1], it extends the rock5b target to also support the 5B+
>>> variant instead of adding a new defconfig target.
>>> 
>>> [1] https://patchwork.ozlabs.org/cover/2118033/
>>> 
>>> Regards,
>>> Jonas
>>> 
>>>> 
>>>> Tested on ROCK 5B+ rev 1.2 (32 GB LPDDR5) booting U-Boot from microSD card.
>>>> Build used:
>>>> - TPL rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.19.bin
>>>> - BL31 rk3588_bl31_v1.51.elf
>>>> - GCC 15.1.0 toolchain
>>>> 
>>>> The eMMC controller enumerates even without a soldered module. SPL → U-Boot
>>>> boot verified; SD and USB enumeration work as expected.
>>>> 
>>>> Thanks,
>>>> Bryan
>>>> 
>>>> ---
>>>> Bryan Hinton (2):
>>>> configs: Add rock5b_plus-rk3588_defconfig
>>>> MAINTAINERS: Add entry for Radxa ROCK 5B+
>>>> 
>>>> MAINTAINERS                          |   5 ++
>>>> configs/rock5b_plus-rk3588_defconfig | 118 +++++++++++++++++++++++++++
>>>> 2 files changed, 123 insertions(+)
>>>> create mode 100644 configs/rock5b_plus-rk3588_defconfig
>>>> 
>>> 
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-11-04 21:24 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 18:25 [PATCH 0/2] Add Radxa ROCK 5B+ defconfig Bryan Hinton
2025-11-04 18:25 ` [PATCH 1/2] configs: Add rock5b_plus-rk3588_defconfig Bryan Hinton
2025-11-04 18:29   ` Tom Rini
2025-11-04 18:25 ` [PATCH 2/2] MAINTAINERS: Add entry for Radxa ROCK 5B+ Bryan Hinton
2025-11-04 19:04 ` [PATCH 0/2] Add Radxa ROCK 5B+ defconfig Jonas Karlman
2025-11-04 19:43   ` Bryan Hinton
2025-11-04 19:58     ` Jonas Karlman
2025-11-04 21:23       ` Bryan Hinton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox