From: Tom Rini <trini@konsulko.com>
To: Raymond Mao <raymondmaoca@gmail.com>
Cc: u-boot@lists.denx.de,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Mark Kettenis <kettenis@openbsd.org>,
Baocheng Su <baocheng.su@siemens.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Simon Glass <sjg@chromium.org>,
Li Hua Qian <huaqian.li@siemens.com>, Peng Fan <peng.fan@nxp.com>,
Samuel Holland <samuel.holland@sifive.com>
Subject: Re: [PATCH v4 1/5] smbios: Fix duplicated smbios handles
Date: Fri, 14 Nov 2025 11:19:54 -0600 [thread overview]
Message-ID: <20251114171954.GC6688@bill-the-cat> (raw)
In-Reply-To: <20251114170615.17698-1-raymondmaoca@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Fri, Nov 14, 2025 at 09:05:58AM -0800, Raymond Mao wrote:
> Some smbios types can have multiple instances (e.g. Type 7, 9, 16, 17,
> 19), thus the 'handle' argument should be a pointer so that the value
> can be accumulated when writing all the instances.
> This also fix the observed duplicated Type 7 handles.
>
> Fixes: bcf456dd369e ("smbios: add detailed smbios information")
> Signed-off-by: Raymond Mao <raymondmaoca@gmail.com>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
> Changes in v3:
> - Initial patch.
> Changes in v4:
> - None.
This really needs a cover letter. If there's no other feedback for this,
please just reply to this patch with a cover letter, so I'll have good
content for the merge. Thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-11-14 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 17:05 [PATCH v4 1/5] smbios: Fix duplicated smbios handles Raymond Mao
2025-11-14 17:05 ` [PATCH v4 2/5] smbios: add support for dynamic generation of Type 9 system slot tables Raymond Mao
2025-11-16 10:45 ` Heinrich Schuchardt
2025-11-14 17:06 ` [PATCH v4 3/5] smbios: add support for dynamic generation of Type 16 table Raymond Mao
2025-11-14 17:06 ` [PATCH v4 4/5] smbios: add support for dynamic generation of Type 17 table Raymond Mao
2025-11-16 10:41 ` Heinrich Schuchardt
2025-11-16 10:45 ` Heinrich Schuchardt
2025-11-14 17:06 ` [PATCH v4 5/5] smbios: add support for dynamic generation of Type 19 table Raymond Mao
2025-11-14 17:19 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114171954.GC6688@bill-the-cat \
--to=trini@konsulko.com \
--cc=baocheng.su@siemens.com \
--cc=huaqian.li@siemens.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=kettenis@openbsd.org \
--cc=peng.fan@nxp.com \
--cc=raymondmaoca@gmail.com \
--cc=samuel.holland@sifive.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox