U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Łukasz Majewski" <lukma@nabladev.com>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] display5: Stop disabling device tree relocation
Date: Wed, 19 Nov 2025 10:41:23 +0100	[thread overview]
Message-ID: <20251119104123.1d68e5cf@wsk> (raw)
In-Reply-To: <20251118180356.591016-1-trini@konsulko.com>

On Tue, 18 Nov 2025 12:03:56 -0600
Tom Rini <trini@konsulko.com> wrote:

> Remove setting of fdt_high to ~0, which disables device tree
> relocation, from the default environment. Doing so prevents U-Boot
> from correcting problems such as having an unaligned device tree and
> leads to various failure modes in the OS.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> If there is some window of memory that must be used for where the
> device tree is relocated to, bootm_low + bootm_size (or often just
> bootm_size) or bootm_mapsize are the correct way do this. Please see
> doc/usage/environment.rst for more details.
> 
> Cc: Lukasz Majewski <lukma@nabladev.com>
> ---
>  include/configs/display5.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/configs/display5.h b/include/configs/display5.h
> index 19d71d6066f8..c311b35bb978 100644
> --- a/include/configs/display5.h
> +++ b/include/configs/display5.h
> @@ -175,7 +175,6 @@
>  	"fdtaddr=0x12800000\0" \
>  	"console=ttymxc4,115200 quiet cma=256M\0" \
>  	"fdtfile=imx6q-display5.dtb\0" \
> -	"fdt_high=0xffffffff\0" \
>  	"initrd_high=0xffffffff\0" \
>  	"kernel_file=fitImage\0" \
>  	"fitImg_fw_sz=0x2200\0" \

Reviewed-by: Łukasz Majewski <lukma@nabladev.com>

-- 
Best regards,

Lukasz Majewski

--
Nabla Software Engineering GmbH
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@nabladev.com
Managing Director : Stefano Babic

      reply	other threads:[~2025-11-19  9:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 18:03 [PATCH] display5: Stop disabling device tree relocation Tom Rini
2025-11-19  9:41 ` Łukasz Majewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251119104123.1d68e5cf@wsk \
    --to=lukma@nabladev.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox