public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Quentin Schulz <foss+uboot@0leil.net>
To: u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>,
	Aristo Chen <jj251510319013@gmail.com>,
	 Rasmus Villemoes <ravi@prevas.dk>,
	 Marek Vasut <marek.vasut+renesas@mailbox.org>,
	 Simon Glass <sjg@chromium.org>,
	 Paul HENRYS <paul.henrys_ext@softathome.com>,
	 Heinrich Schuchardt <xypron.glpk@gmx.de>,
	 Shiji Yang <yangshiji66@outlook.com>,
	 Anton Moryakov <ant.v.moryakov@gmail.com>,
	 Alper Nebi Yasak <alpernebiyasak@gmail.com>,
	Alice Guo <alice.guo@nxp.com>,  Bryan Brattlof <bb@ti.com>,
	 Wolfgang Wallner <wolfgang.wallner@br-automation.com>,
	 Peter Robinson <pbrobinson@gmail.com>,
	Eddie Kovsky <ekovsky@redhat.com>,
	 Kever Yang <kever.yang@rock-chips.com>,
	Yannic Moog <y.moog@phytec.de>,
	 Quentin Schulz <quentin.schulz@cherry.de>
Subject: [PATCH v3 2/4] tools: binman: mkimage: add support for passing the engine
Date: Fri, 21 Nov 2025 18:14:58 +0100	[thread overview]
Message-ID: <20251121-binman-engine-v3-2-b80180aaa783@cherry.de> (raw)
In-Reply-To: <20251121-binman-engine-v3-0-b80180aaa783@cherry.de>

From: Quentin Schulz <quentin.schulz@cherry.de>

mkimage has support for OpenSSL engines but binman currently doesn't for
direct callers of mkimage (e.g. the fit etype). This prepares for adding
support for OpenSSL engines for signing elements of a FIT image, which
will done in the next commit.

Reviewed-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
 tools/binman/btool/mkimage.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/binman/btool/mkimage.py b/tools/binman/btool/mkimage.py
index 23c0a8e490d..1dbd466f438 100644
--- a/tools/binman/btool/mkimage.py
+++ b/tools/binman/btool/mkimage.py
@@ -22,7 +22,7 @@ class Bintoolmkimage(bintool.Bintool):
 
     # pylint: disable=R0913
     def run(self, reset_timestamp=False, output_fname=None, external=False,
-            pad=None, align=None, keys_dir=None):
+            pad=None, align=None, keys_dir=None, engine=None):
         """Run mkimage
 
         Args:
@@ -35,6 +35,7 @@ class Bintoolmkimage(bintool.Bintool):
                 signatures
             align: Bytes to use for alignment of the FIT and its external data
             keys_dir: Path to directory containing private and encryption keys
+            engine: Name of the OpenSSL engine to use
         """
         args = []
         if external:
@@ -49,6 +50,8 @@ class Bintoolmkimage(bintool.Bintool):
             args += ['-k', f'{keys_dir}']
         if output_fname:
             args += ['-F', output_fname]
+        if engine:
+            args += ['-N', engine]
         return self.run_cmd(*args)
 
     def fetch(self, method):

-- 
2.51.1


  parent reply	other threads:[~2025-11-21 17:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21 17:14 [PATCH v3 0/4] fit: allow signing with an OpenSSL engine Quentin Schulz
2025-11-21 17:14 ` [PATCH v3 1/4] fit: support signing with only an engine_id Quentin Schulz
2025-11-21 17:14 ` Quentin Schulz [this message]
2025-11-21 17:14 ` [PATCH v3 3/4] tools: binman: fit: add support for OpenSSL engines Quentin Schulz
2025-11-25 22:15   ` Simon Glass
2025-11-26 11:28     ` Quentin Schulz
2025-11-21 17:15 ` [PATCH v3 4/4] tools: binman: fit: add tests for signing with an OpenSSL engine Quentin Schulz
2025-11-25 22:15   ` Simon Glass
2025-11-26 11:44     ` Quentin Schulz
2025-12-02 20:06       ` Simon Glass
2025-12-02 20:14         ` Tom Rini
2025-12-04 11:52           ` Quentin Schulz
2025-12-04 14:25             ` Tom Rini
2025-12-10 12:32           ` Simon Glass
2025-12-04 11:50         ` Quentin Schulz
2025-12-10 12:32           ` Simon Glass
2025-12-10 14:29             ` Tom Rini
2025-12-07 14:04 ` [PATCH v3 0/4] fit: allow " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251121-binman-engine-v3-2-b80180aaa783@cherry.de \
    --to=foss+uboot@0leil.net \
    --cc=alice.guo@nxp.com \
    --cc=alpernebiyasak@gmail.com \
    --cc=ant.v.moryakov@gmail.com \
    --cc=bb@ti.com \
    --cc=ekovsky@redhat.com \
    --cc=jj251510319013@gmail.com \
    --cc=kever.yang@rock-chips.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=paul.henrys_ext@softathome.com \
    --cc=pbrobinson@gmail.com \
    --cc=quentin.schulz@cherry.de \
    --cc=ravi@prevas.dk \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=wolfgang.wallner@br-automation.com \
    --cc=xypron.glpk@gmx.de \
    --cc=y.moog@phytec.de \
    --cc=yangshiji66@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox