Re: [PATCH 5/5] board: toradex: add splash screen to Toradex i.MX7D Colibri board

[Francesco Dolcini <francesco@dolcini.it>]

On Wed, Nov 26, 2025 at 06:54:48PM +0100, Thomas Bonnefille wrote:
> Hello Francesco,
> On Wed Nov 26, 2025 at 12:59 PM CET, Francesco Dolcini wrote:
> > [...]
> >> -
> >> -	return 0;
> >> +	enable_pwm_clk(1, 0);
> >> +	ret = pwm_init(0, 0, 0);
> >> +	if (ret)
> >> +		return ret;
> >> +	ret = pwm_config(0, 0, 6666666);
> >
> > You are setting a period here for the PWM backlight (150Hz?),
> > considering that colibri imx7 is a SoM, e.g. there is no actual display
> > part of it, is this number generic enough?
> 
> Indeed there isn't, however for my tests I used the Toradex Colibri
> Evaluation Board with the Toradex 7 inch Capacitive Touch Display [1] that is
> meant to be used with the Colibri Evaluation Board.
> This display typically uses a 150Hz PWM for its backlight so I chose this
> value.
> However there the pwm_config configure a 150Hz PWM with 0ns duty cycle so
> in fact, no matter the frequency, this pin will act as an always off GPIO.

Yes, make sense. At the same time you might have display with the
opposite polarity for the PWM ...

To me this change is ok to go in, it does not make the code any more
specific than it was before.

Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Not sure if you have any next step planned, but adding support for a
specific display in the generic SoM support code does not seem right to
me.