From: Tom Rini <trini@konsulko.com>
To: alice.guo@oss.nxp.com
Cc: u-boot@lists.denx.de, uboot-imx@nxp.com, sbabic@nabladev.com,
festevam@gmail.com, peng.fan@nxp.com, alice.guo@nxp.com,
sjg@chromium.org, davidzangcs@gmail.com
Subject: Re: [PATCH v1 1/2] imx8ulp_evk: Move environment variables to .env file
Date: Mon, 1 Dec 2025 08:41:51 -0600 [thread overview]
Message-ID: <20251201144151.GD303283@bill-the-cat> (raw)
In-Reply-To: <20251201105657.1968244-1-alice.guo@oss.nxp.com>
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
On Mon, Dec 01, 2025 at 06:56:56PM +0800, alice.guo@oss.nxp.com wrote:
> From: Alice Guo <alice.guo@nxp.com>
>
> Add board-specific environment variables to imx8ulp_evk.env for better
> maintainability.
>
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
[snip]
> +fdt_high=0xffffffffffffffff
NAK. I just the other week sent out 40+ patches removing that setting
from other platforms and you weren't even setting it before.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-12-01 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 10:56 [PATCH v1 1/2] imx8ulp_evk: Move environment variables to .env file alice.guo
2025-12-01 14:41 ` Tom Rini [this message]
2025-12-02 1:49 ` Peng Fan
2025-12-02 2:16 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201144151.GD303283@bill-the-cat \
--to=trini@konsulko.com \
--cc=alice.guo@nxp.com \
--cc=alice.guo@oss.nxp.com \
--cc=davidzangcs@gmail.com \
--cc=festevam@gmail.com \
--cc=peng.fan@nxp.com \
--cc=sbabic@nabladev.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox