Re: [PATCH 05/12] docker: add Analog Devices tools to docker image

Tom Rini
2025-11-18T14:39:27Z

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

On Tue, Nov 18, 2025 at 01:39:38AM -0500, Greg Malysa wrote:

> The boot ROM on Analog Devices ADSP-SC5xx SoCs requires code packaged
> in the LDR format. Normally this is available as part of
> our yocto-derived toolchain but, it is not a part of any other pre-made
> toolchain anymore, so it is otherwise unavailable in the docker image
> for CI. This patch adds a source build from the ADI maintained github
> repository. In the future, a package available for install via apt will
> be available, but currently there is no arm64 build upstream, so we must
> build from source for the time being to support CI on both amd64 and
> arm64 runners. The same ldr tool is used for arm and arm64 for all of
> our boards with names adjusted to match the expected $(CROSS_COMPILE)
> for these boards.
>
> Signed-off-by: Greg Malysa <malysagreg@gmail.com>
[snip]
> +# Build ldr tool for Analog Devices boards and create prefixed symlinks to match
> +# $(CROSS_COMPILE) as used by different supported platforms
> +RUN git clone https://github.com/analogdevicesinc/lnxdsp-arm-poky-linux-gnueabi-ldr.git /opt/lnxdsp-arm-poky-linux-gnueabi-ldr && \

We need to be getting a specific branch/tag (or worst case, commit) and
using --depth=1.

[snip]
> +ENV PATH="${PATH}:/opt/lnxdsp-arm-poky-linux-gnueabi-ldr"

Does this actually do what you want, update the PATH for the shell that
we spawn and run CI in?

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]