public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Francesco Valla <francesco@valla.it>
Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
	u-boot@lists.denx.de, Fabio Estevam <festevam@gmail.com>,
	Stefano Babic <sbabic@nabladev.com>,
	Tom Rini <trini@konsulko.com>, Peng Fan <peng.fan@nxp.com>,
	Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>,
	Joseph Guo <qijian.guo@nxp.com>,
	Fabian Pflug <f.pflug@pengutronix.de>
Subject: Re: [PATCH] imx93_frdm: clear and mask TCPC interrupts
Date: Tue, 6 Jan 2026 15:40:37 +0100	[thread overview]
Message-ID: <20260106154037.27a9dfa8@windsurf> (raw)
In-Reply-To: <20260103-imx93_frdm_tcpc_fix-v1-1-d7ef892697eb@valla.it>

Hello Francesco,

On Sat, 03 Jan 2026 22:22:12 +0100
Francesco Valla <francesco@valla.it> wrote:

> One of the two on-board PTN5110 TCPC USB Power Delivery controller on
> the i.MX93 FRDM board shares its interrupt line whith the PCAL6524 power
> controller (GPIO3-27). Since the PTN5110 starts after POR with the
> interrupts enabled, this can lead to an interrupt storm on OS startup if
> only the driver for the PCAL6524 is loaded, because none is servicing
> (and clearing) the interrupt requests from the PTN5110.
> 
> Maks and clear all interrupts as part uring board initialization; they
> can be re-enabled later by a proper OS driver if required.
> 
> Co-developed-by: Joseph Guo <qijian.guo@nxp.com>
> Signed-off-by: Francesco Valla <francesco@valla.it>

Thanks a lot for this patch, I confirm it fixes the issue I was having
with the kernel experiencing spurious IRQs. I don't really have any
comments on the technical approach: it's never nice to poke into a
device registers directly from a board file and outside of the driver
for that specific device, but I don't know if there's a better approach
for this specific problem.

So in any case:

Tested-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks again!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com

  parent reply	other threads:[~2026-01-06 17:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-03 21:22 [PATCH] imx93_frdm: clear and mask TCPC interrupts Francesco Valla
2026-01-03 23:41 ` Fabio Estevam
2026-01-06 14:40 ` Thomas Petazzoni [this message]
2026-01-07  1:39 ` Peng Fan
2026-01-18  1:45 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260106154037.27a9dfa8@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=f.pflug@pengutronix.de \
    --cc=festevam@gmail.com \
    --cc=francesco@valla.it \
    --cc=mathieu.dubois-briand@bootlin.com \
    --cc=peng.fan@nxp.com \
    --cc=qijian.guo@nxp.com \
    --cc=sbabic@nabladev.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox