[PATCH v2] boot/fit: print name of config node not found

[PATCH v2] boot/fit: print name of config node not found

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Show name of configuration node which was not found.

current state gives no hint if fit image is wrong or the requested name.

Could not find configuration node
load of <NULL> failed

After this patch we see name like this:

Could not find configuration node '#ov-test'
load of <NULL> failed

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v2
- handle null
---
 boot/image-fit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/boot/image-fit.c b/boot/image-fit.c
index 2d040e38d97b..85026c2d1d02 100644
--- a/boot/image-fit.c
+++ b/boot/image-fit.c
@@ -2125,7 +2125,8 @@ int fit_image_load(struct bootm_headers *images, ulong addr,
 		if (ret < 0 && ret != -EINVAL)
 			ret = fit_conf_get_node(fit, fit_uname_config);
 		if (ret < 0) {
-			puts("Could not find configuration node\n");
+			printf("Could not find configuration node '%s'\n",
+			       fit_uname_config ? fit_uname_config : "(null)");
 			bootstage_error(bootstage_id +
 					BOOTSTAGE_SUB_NO_UNIT_NAME);
 			return -ENOENT;
-- 
2.43.0

Re: [PATCH v2] boot/fit: print name of config node not found

[Quentin Schulz]

Hi Frank,

On 1/16/26 7:29 PM, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Show name of configuration node which was not found.
> 
> current state gives no hint if fit image is wrong or the requested name.
> 
> Could not find configuration node
> load of <NULL> failed
> 
> After this patch we see name like this:
> 
> Could not find configuration node '#ov-test'
> load of <NULL> failed
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> v2
> - handle null
> ---
>   boot/image-fit.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/boot/image-fit.c b/boot/image-fit.c
> index 2d040e38d97b..85026c2d1d02 100644
> --- a/boot/image-fit.c
> +++ b/boot/image-fit.c
> @@ -2125,7 +2125,8 @@ int fit_image_load(struct bootm_headers *images, ulong addr,
>   		if (ret < 0 && ret != -EINVAL)
>   			ret = fit_conf_get_node(fit, fit_uname_config);
>   		if (ret < 0) {
> -			puts("Could not find configuration node\n");
> +			printf("Could not find configuration node '%s'\n",
> +			       fit_uname_config ? fit_uname_config : "(null)");

Given that DT node names cannot contain parentheses according to the 
Device Tree specification, "(null)" should hopefully not confuse users?

Thus,

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin

Re: [PATCH v2] boot/fit: print name of config node not found

[Tom Rini]

On Fri, 16 Jan 2026 19:29:02 +0100, Frank Wunderlich wrote:

> Show name of configuration node which was not found.
> 
> current state gives no hint if fit image is wrong or the requested name.
> 
> Could not find configuration node
> load of <NULL> failed
> 
> [...]

Applied to u-boot/master, thanks!

[1/1] boot/fit: print name of config node not found
      commit: 09cc6788683172a5588eca2cb7536a20a600faa9
-- 
Tom