From: Tom Rini <trini@konsulko.com>
To: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
Cc: casey.connolly@linaro.org, neil.armstrong@linaro.org,
sumit.garg@kernel.org, ilias.apalodimas@linaro.org,
jerome@forissier.org, marek.vasut+renesas@mailbox.org,
christopher.obbard@linaro.org, me@samcday.com,
michal.simek@amd.com, clamor95@gmail.com, u-boot@lists.denx.de,
u-boot-qcom@groups.io
Subject: Re: [PATCH v5 0/5] Implement reset to EDL for qcs9100
Date: Mon, 19 Jan 2026 11:07:01 -0600 [thread overview]
Message-ID: <20260119170701.GD3416603@bill-the-cat> (raw)
In-Reply-To: <aW3DjqaULjsb32QU@hu-varada-blr.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 6277 bytes --]
On Mon, Jan 19, 2026 at 11:09:26AM +0530, Varadarajan Narayanan wrote:
> On Fri, Jan 16, 2026 at 08:43:55AM -0600, Tom Rini wrote:
> > On Fri, Jan 16, 2026 at 12:39:47PM +0530, Varadarajan Narayanan wrote:
> > > On Tue, Jan 13, 2026 at 08:42:44AM -0600, Tom Rini wrote:
> > > > On Tue, Jan 13, 2026 at 04:08:35PM +0530, Varadarajan Narayanan wrote:
> > > >
> > > > > Using the 'reboot edl' command in Linux, the platform can reboot to the
> > > > > Emergency Download mode. Implement the same for U-Boot.
> > > >
> > > > Have you used buildman's size checking options before? If not,
> > >
> > > No.
> > >
> > > > https://source.denx.de/u-boot/u-boot-extras/-/blob/master/contrib/trini/u-boot-size-test.sh?ref_type=heads
> > > > may be helpful to you, as it can be a bit tricky at first (but IMHO is
> > > > better than the linux kernel bloat-o-meter). I ask because, what is the
> > > > size impact of these changes on things like say qemu_arm64 and qemu_arm?
> > > > I saw the cmd/ portion is guarded by a new CONFIG option which is good,
> > > > but I wonder about the more generic sysreset changes. Thanks!
> > >
> > > Please see below for u-boot-size-test.sh output
> > >
> > > $ ./u-boot-size-test.sh --board qcom_ipq9574_mmc
> > > Generating board list...Processing #include to produce configs/socfpga_agilex5_vab_defconfig
> > > Processing #include to produce configs/r8a78000_ironhide_defconfig
> > > .
> > > .
> > > .
> > > Processing #include to produce configs/am69_sk_a72_defconfig
> > > Building 2 commits for 1 boards (1 thread, 16 jobs per thread)
> > > 01: configs: am57xx_hs_evm_defconfig: Reserve EMIF memory used by PPA
> > > 06: qcom_defconfig: enable psci based sysreset
> > > 2 0 0 /2 qcom_ipq9574_mmc
> > > Completed: 2 total built, 2 newly), duration 0:00:13, rate 0.15
> > > /tmp/qcom_ipq9574_mmc/edl5/boards.cfg is up to date. Nothing to do.
> > > Summary of 2 commits for 1 boards (1 thread, 16 jobs per thread)
> > > 01: configs: am57xx_hs_evm_defconfig: Reserve EMIF memory used by PPA
> > > 06: qcom_defconfig: enable psci based sysreset
> > > aarch64: (for 1/1 boards) all +224.0 data +8.0 text +216.0
> > > qcom_ipq9574_mmc: all +224 data +8 text +216
> > > u-boot: add: 2/0, grow: 2/0 bytes: 224/0 (224)
> > > function old new delta
> > > sysreset_walk_arg - 124 +124
> > > do_reset 100 160 +60
> > > sysreset_request_arg - 32 +32
> > > psci_sysreset_ops 24 32 +8
> > > (no errors to report)
> >
> > OK, so minimal growth on the platforms that would use it. How about
> > platforms which don't? qemu_arm and qemu_arm64 should build the sysreset
> > code in general and that's where I'm most concerned, platforms which
> > aren't using this feature. Thanks.
>
> Please see below for u-boot-size-test.sh output
>
> $ ./u-boot-size-test.sh --board qemu_arm
> Generating board list...Processing #include to produce configs/socfpga_agilex5_vab_defconfig
> Processing #include to produce configs/imx6ulz_smm_m2_defconfig
> .
> .
> .
> Processing #include to produce configs/am69_sk_a72_defconfig
> Building 2 commits for 1 boards (1 thread, 16 jobs per thread)
> 01: configs: am57xx_hs_evm_defconfig: Reserve EMIF memory used by PPA
> 06: qcom_defconfig: enable psci based sysreset
> 2 0 0 /2 qemu_arm
> Completed: 2 total built, 2 newly), duration 0:00:18, rate 0.11
> /tmp/qemu_arm/edl5/boards.cfg is up to date. Nothing to do.
> Summary of 2 commits for 1 boards (1 thread, 16 jobs per thread)
> 01: configs: am57xx_hs_evm_defconfig: Reserve EMIF memory used by PPA
> 06: qcom_defconfig: enable psci based sysreset
> arm: (for 1/1 boards) all +184.0 text +184.0
> qemu_arm : all +184 text +184
> u-boot: add: 2/0, grow: 2/0 bytes: 184/0 (184)
> function old new delta
> sysreset_walk_arg - 104 +104
> do_reset 92 136 +44
> sysreset_request_arg - 32 +32
> psci_sysreset_ops 12 16 +4
> (no errors to report)
>
> $ ./u-boot-size-test.sh --board qemu_arm64
> Generating board list...Processing #include to produce configs/socfpga_agilex5_vab_defconfig
> Processing #include to produce configs/imx6ulz_smm_m2_defconfig
> .
> .
> .
> Processing #include to produce configs/genmai_defconfig
> Building 2 commits for 1 boards (1 thread, 16 jobs per thread)
> 01: configs: am57xx_hs_evm_defconfig: Reserve EMIF memory used by PPA
> 06: qcom_defconfig: enable psci based sysreset
> 2 0 0 /2 qemu_arm64
> Completed: 2 total built, 2 newly), duration 0:00:19, rate 0.11
> /tmp/qemu_arm64/edl5/boards.cfg is up to date. Nothing to do.
> Summary of 2 commits for 1 boards (1 thread, 16 jobs per thread)
> 01: configs: am57xx_hs_evm_defconfig: Reserve EMIF memory used by PPA
> 06: qcom_defconfig: enable psci based sysreset
> aarch64: (for 1/1 boards) all +216.0 data +8.0 rodata -8.0 text +216.0
> qemu_arm64 : all +216 data +8 rodata -8 text +216
> u-boot: add: 2/0, grow: 2/0 bytes: 224/0 (224)
> function old new delta
> sysreset_walk_arg - 124 +124
> do_reset 100 160 +60
> sysreset_request_arg - 32 +32
> psci_sysreset_ops 24 32 +8
> (no errors to report)
That's not great. Can you please look at if you can cleanly rework your
changes to have less, or ideally no, size growth on the 700+ other
platforms that enable SYSRESET? Thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-01-19 17:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 10:38 [PATCH v5 0/5] Implement reset to EDL for qcs9100 Varadarajan Narayanan
2026-01-13 10:38 ` [PATCH v5 1/5] arm: psci: Add API to check for support of specific PSCI function Varadarajan Narayanan
2026-01-13 10:38 ` [PATCH v5 2/5] drivers: sysreset: Add sysreset op that can take arguments Varadarajan Narayanan
2026-01-13 10:38 ` [PATCH v5 3/5] sysreset: Implement PSCI based reset to EDL mode for QCOM SoCs Varadarajan Narayanan
2026-01-13 10:38 ` [PATCH v5 4/5] cmd: boot: Add '-edl' option to reset command documentation Varadarajan Narayanan
2026-01-13 10:38 ` [PATCH v5 5/5] qcom_defconfig: enable psci based sysreset Varadarajan Narayanan
2026-01-13 14:42 ` [PATCH v5 0/5] Implement reset to EDL for qcs9100 Tom Rini
2026-01-16 7:09 ` Varadarajan Narayanan
2026-01-16 14:43 ` Tom Rini
2026-01-19 5:39 ` Varadarajan Narayanan
2026-01-19 17:07 ` Tom Rini [this message]
2026-01-21 6:42 ` Varadarajan Narayanan
2026-01-16 9:20 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119170701.GD3416603@bill-the-cat \
--to=trini@konsulko.com \
--cc=casey.connolly@linaro.org \
--cc=christopher.obbard@linaro.org \
--cc=clamor95@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jerome@forissier.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=me@samcday.com \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=sumit.garg@kernel.org \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
--cc=varadarajan.narayanan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox