From: Tom Rini <trini@konsulko.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: u-boot@lists.denx.de, eballetb@redhat.com, alexl@redhat.com
Subject: Re: [PATCH 2/5] disk: part_dos: Align dos_partition_t with struct partition
Date: Tue, 20 Jan 2026 08:35:52 -0600 [thread overview]
Message-ID: <20260120143552.GI3416603@bill-the-cat> (raw)
In-Reply-To: <20260120133630.1695055-3-javierm@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
On Tue, Jan 20, 2026 at 02:36:11PM +0100, Javier Martinez Canillas wrote:
> The dos_partition_t struct defined in part_dos.h is nearly identical to
> the struct partition defined in part_efi.h. They differ primarily in how
> define their starting sector and number of sectors fields.
>
> The former uses unsigned char arrays while the latter uses __le32 types.
> Using __le32 is preferable, as it removes the ambiguity and potential
> misuse of a raw byte array. This also aligns the structure with how the
> Linux kernel defines it nowadays, which is the original source of it.
>
> To prepare for future consolidation where one of the data structures can
> be removed, this change aligns both definitions and updates all accessors
> for dos_partition_t.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-01-20 14:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 13:36 [PATCH 0/5] efi_loader: disk: Add EFI_PARTITION_INFO_PROTOCOL support for MBR Javier Martinez Canillas
2026-01-20 13:36 ` [PATCH 1/5] disk: part_dos: Move header to the main include directory Javier Martinez Canillas
2026-01-20 14:34 ` Tom Rini
2026-01-20 13:36 ` [PATCH 2/5] disk: part_dos: Align dos_partition_t with struct partition Javier Martinez Canillas
2026-01-20 14:35 ` Tom Rini [this message]
2026-01-20 13:36 ` [PATCH 3/5] disk: part_efi: Remove redundant struct partition definition Javier Martinez Canillas
2026-01-20 14:37 ` Tom Rini
2026-01-20 13:36 ` [PATCH 4/5] efi_loader: disk: Extend EFI_PARTITION_INFO_PROTOCOL to support MBR Javier Martinez Canillas
2026-01-20 14:53 ` Heinrich Schuchardt
2026-01-21 9:25 ` Javier Martinez Canillas
2026-01-20 17:39 ` Jan Kiszka
2026-01-21 9:28 ` Javier Martinez Canillas
2026-01-22 8:54 ` Jan Kiszka
2026-01-20 13:36 ` [PATCH 5/5] efi_selftest: Enhance MBR test for PARTITION_INFO_PROTOCOL Javier Martinez Canillas
2026-01-20 14:56 ` Heinrich Schuchardt
2026-01-21 9:28 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120143552.GI3416603@bill-the-cat \
--to=trini@konsulko.com \
--cc=alexl@redhat.com \
--cc=eballetb@redhat.com \
--cc=javierm@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox