public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH v1 0/2] toradex: aquila-am69: fix SPL USB DFU, drop obsolete clock
@ 2026-01-27 10:14 Ernest Van Hoecke
  2026-01-27 10:14 ` [PATCH v1 1/2] arm: dts: k3-am69-aquila: Fix SPL USB DFU gadget failures Ernest Van Hoecke
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Ernest Van Hoecke @ 2026-01-27 10:14 UTC (permalink / raw)
  To: Tom Rini
  Cc: Ernest Van Hoecke, Neha Malcom Francis, Manorit Chawdhry,
	Andrew Davis, Francesco Dolcini, Emanuele Ghidoli, Franz Schnyder,
	u-boot

From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>

This is a small, board-specific series for Aquila AM69.

Patch 1 fixes intermittent SPL USB DFU gadget enumeration.
Patch 2 drops a stale MCU_CLKOUT0 enable for ETH_1. V1.1 hardware uses
an external 25 MHz crystal, and support for earlier revisions was
already removed from the DT before upstreaming.

Ernest Van Hoecke (2):
  arm: dts: k3-am69-aquila: Fix SPL USB DFU gadget failures
  board: toradex: aquila-am69: Remove ETH_1 MCU_CLKOUT0

 arch/arm/dts/k3-am69-aquila-dev-u-boot.dtsi | 1 +
 board/toradex/aquila-am69/aquila-am69.c     | 7 -------
 2 files changed, 1 insertion(+), 7 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v1 1/2] arm: dts: k3-am69-aquila: Fix SPL USB DFU gadget failures
  2026-01-27 10:14 [PATCH v1 0/2] toradex: aquila-am69: fix SPL USB DFU, drop obsolete clock Ernest Van Hoecke
@ 2026-01-27 10:14 ` Ernest Van Hoecke
  2026-01-27 10:14 ` [PATCH v1 2/2] board: toradex: aquila-am69: Remove ETH_1 MCU_CLKOUT0 Ernest Van Hoecke
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Ernest Van Hoecke @ 2026-01-27 10:14 UTC (permalink / raw)
  To: Tom Rini
  Cc: Ernest Van Hoecke, Neha Malcom Francis, Manorit Chawdhry,
	Andrew Davis, Francesco Dolcini, Emanuele Ghidoli, Franz Schnyder,
	u-boot

From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>

Around 1 in 20 times, the current R5 SPL fails to pull up the D+ line to
signal that a new USB device (the USB gadget used for downloading the
next stage) joined the bus.

With these strapping options, this is greatly reduced to 1 in thousands.

Link: https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1587424/am69-u-boot-spl-usb-dfu-cdns3-occasionally-fails-to-pull-up-d-in-cdns3_gadget_config
Fixes: 3f0528882c0d ("board: toradex: add aquila am69 support")
Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
---
 arch/arm/dts/k3-am69-aquila-dev-u-boot.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/dts/k3-am69-aquila-dev-u-boot.dtsi b/arch/arm/dts/k3-am69-aquila-dev-u-boot.dtsi
index 59948b9d1f4b..5b8b8539da3f 100644
--- a/arch/arm/dts/k3-am69-aquila-dev-u-boot.dtsi
+++ b/arch/arm/dts/k3-am69-aquila-dev-u-boot.dtsi
@@ -144,6 +144,7 @@
 };
 
 &usbss0 {
+	ti,modestrap-peripheral;
 	ti,usb2-only;
 	bootph-pre-ram;
 };
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v1 2/2] board: toradex: aquila-am69: Remove ETH_1 MCU_CLKOUT0
  2026-01-27 10:14 [PATCH v1 0/2] toradex: aquila-am69: fix SPL USB DFU, drop obsolete clock Ernest Van Hoecke
  2026-01-27 10:14 ` [PATCH v1 1/2] arm: dts: k3-am69-aquila: Fix SPL USB DFU gadget failures Ernest Van Hoecke
@ 2026-01-27 10:14 ` Ernest Van Hoecke
  2026-01-27 14:52 ` [PATCH v1 0/2] toradex: aquila-am69: fix SPL USB DFU, drop obsolete clock Francesco Dolcini
  2026-02-04 14:01 ` Tom Rini
  3 siblings, 0 replies; 5+ messages in thread
From: Ernest Van Hoecke @ 2026-01-27 10:14 UTC (permalink / raw)
  To: Tom Rini
  Cc: Ernest Van Hoecke, Neha Malcom Francis, Manorit Chawdhry,
	Andrew Davis, Francesco Dolcini, Emanuele Ghidoli, Franz Schnyder,
	u-boot

From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>

On the Toradex Aquila AM69 V1.1, the on-module ETH_1 relies on an
external 25 MHz crystal oscillator. On the V1.0, we needed to enable
MCU_CLKOUT0, but support for this was already dropped from the device
tree before being sent to U-Boot.

Remove this obsolete enabling of MCU_CLKOUT0.

Fixes: 3f0528882c0d ("board: toradex: add aquila am69 support")
Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
---
 board/toradex/aquila-am69/aquila-am69.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/board/toradex/aquila-am69/aquila-am69.c b/board/toradex/aquila-am69/aquila-am69.c
index 98b9bfc5aa4b..e0975d5bc6fe 100644
--- a/board/toradex/aquila-am69/aquila-am69.c
+++ b/board/toradex/aquila-am69/aquila-am69.c
@@ -22,8 +22,6 @@
 #include "ddrs_patch.h"
 
 #define CTRL_MMR_CFG0_MCU_ADC1_CTRL	0x40F040B4
-#define CTRL_MMR_CFG0_MCU_CLKOUT0_CTRL	0x40F08010
-#define MCU_CLKOUT0_CTRL_CLK_EN		BIT(4)
 
 #define HW_CFG_MEM_SZ_32GB		0x00
 #define HW_CFG_MEM_SZ_16GB		0x01
@@ -200,9 +198,4 @@ void spl_board_init(void)
 		if (ret)
 			printf("ESM PMIC init failed: %d\n", ret);
 	}
-
-	if (IS_ENABLED(CONFIG_TARGET_AQUILA_AM69_R5))
-		writel(readl(CTRL_MMR_CFG0_MCU_CLKOUT0_CTRL) |
-		       MCU_CLKOUT0_CTRL_CLK_EN,
-		       CTRL_MMR_CFG0_MCU_CLKOUT0_CTRL);
 }
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 0/2] toradex: aquila-am69: fix SPL USB DFU, drop obsolete clock
  2026-01-27 10:14 [PATCH v1 0/2] toradex: aquila-am69: fix SPL USB DFU, drop obsolete clock Ernest Van Hoecke
  2026-01-27 10:14 ` [PATCH v1 1/2] arm: dts: k3-am69-aquila: Fix SPL USB DFU gadget failures Ernest Van Hoecke
  2026-01-27 10:14 ` [PATCH v1 2/2] board: toradex: aquila-am69: Remove ETH_1 MCU_CLKOUT0 Ernest Van Hoecke
@ 2026-01-27 14:52 ` Francesco Dolcini
  2026-02-04 14:01 ` Tom Rini
  3 siblings, 0 replies; 5+ messages in thread
From: Francesco Dolcini @ 2026-01-27 14:52 UTC (permalink / raw)
  To: Ernest Van Hoecke
  Cc: Tom Rini, Ernest Van Hoecke, Neha Malcom Francis,
	Manorit Chawdhry, Andrew Davis, Francesco Dolcini,
	Emanuele Ghidoli, Franz Schnyder, u-boot

On Tue, Jan 27, 2026 at 11:14:10AM +0100, Ernest Van Hoecke wrote:
> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> 
> This is a small, board-specific series for Aquila AM69.
> 
> Patch 1 fixes intermittent SPL USB DFU gadget enumeration.
> Patch 2 drops a stale MCU_CLKOUT0 enable for ETH_1. V1.1 hardware uses
> an external 25 MHz crystal, and support for earlier revisions was
> already removed from the DT before upstreaming.

Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 0/2] toradex: aquila-am69: fix SPL USB DFU, drop obsolete clock
  2026-01-27 10:14 [PATCH v1 0/2] toradex: aquila-am69: fix SPL USB DFU, drop obsolete clock Ernest Van Hoecke
                   ` (2 preceding siblings ...)
  2026-01-27 14:52 ` [PATCH v1 0/2] toradex: aquila-am69: fix SPL USB DFU, drop obsolete clock Francesco Dolcini
@ 2026-02-04 14:01 ` Tom Rini
  3 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2026-02-04 14:01 UTC (permalink / raw)
  To: Ernest Van Hoecke
  Cc: Ernest Van Hoecke, Neha Malcom Francis, Manorit Chawdhry,
	Andrew Davis, Francesco Dolcini, Emanuele Ghidoli, Franz Schnyder,
	u-boot

On Tue, 27 Jan 2026 11:14:10 +0100, Ernest Van Hoecke wrote:

> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> 
> This is a small, board-specific series for Aquila AM69.
> 
> Patch 1 fixes intermittent SPL USB DFU gadget enumeration.
> Patch 2 drops a stale MCU_CLKOUT0 enable for ETH_1. V1.1 hardware uses
> an external 25 MHz crystal, and support for earlier revisions was
> already removed from the DT before upstreaming.
> 
> [...]

Applied to u-boot/master, thanks!

[1/2] arm: dts: k3-am69-aquila: Fix SPL USB DFU gadget failures
      commit: cdd51332cc87b1964f6b48d1c1d5ac142b0dc7a5
[2/2] board: toradex: aquila-am69: Remove ETH_1 MCU_CLKOUT0
      commit: 81cd740838b1fdc6c473580254f0f217df375bcc
-- 
Tom



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-02-04 14:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-27 10:14 [PATCH v1 0/2] toradex: aquila-am69: fix SPL USB DFU, drop obsolete clock Ernest Van Hoecke
2026-01-27 10:14 ` [PATCH v1 1/2] arm: dts: k3-am69-aquila: Fix SPL USB DFU gadget failures Ernest Van Hoecke
2026-01-27 10:14 ` [PATCH v1 2/2] board: toradex: aquila-am69: Remove ETH_1 MCU_CLKOUT0 Ernest Van Hoecke
2026-01-27 14:52 ` [PATCH v1 0/2] toradex: aquila-am69: fix SPL USB DFU, drop obsolete clock Francesco Dolcini
2026-02-04 14:01 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox