From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>,
u-boot@lists.denx.de, Alexander Graf <agraf@csgraf.de>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jerome Forissier <jerome@forissier.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Peng Fan <peng.fan@nxp.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Simon Glass <sjg@chromium.org>,
Yuya Hamamachi <yuya.hamamachi.sx@renesas.com>
Subject: Re: [PATCH 1/3] gunzip: Add ability to disable progress indicator
Date: Thu, 29 Jan 2026 10:53:41 -0600 [thread overview]
Message-ID: <20260129165341.GC2044980@bill-the-cat> (raw)
In-Reply-To: <0af7fd1f-7f8b-4ef4-b8ba-9df260fb8f81@mailbox.org>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Thu, Jan 29, 2026 at 05:33:45PM +0100, Marek Vasut wrote:
> On 1/29/26 5:17 PM, Mattijs Korpershoek wrote:
>
> Hi,
>
> > +++ b/lib/gunzip.c
> > @@ -8,6 +8,7 @@
> > #include <command.h>
> > #include <console.h>
> > #include <div64.h>
> > +#include <env.h>
> > #include <gzip.h>
> > #include <image.h>
> > #include <malloc.h>
>
> This is part of
>
> gunzip: Implement chunked decompression
>
> so clearly I should move that part here already.
>
> > Maybe this should be included conditionally depending on the command
> > being enabled or not?
> Why conditionally ?
A good general question I had is, what's the overall size impact of
these features?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-01-29 16:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 23:57 [PATCH 1/3] gunzip: Add ability to disable progress indicator Marek Vasut
2026-01-27 23:57 ` [PATCH 2/3] configs: sandbox: Enable zip command Marek Vasut
2026-01-29 16:17 ` Mattijs Korpershoek
2026-01-27 23:57 ` [PATCH 3/3] test: cmd: Add test for zip/unzip/gzwrite commands Marek Vasut
2026-01-29 16:26 ` Mattijs Korpershoek
2026-01-29 16:31 ` Marek Vasut
2026-01-29 19:34 ` Mattijs Korpershoek
2026-01-29 19:43 ` Marek Vasut
2026-01-29 16:17 ` [PATCH 1/3] gunzip: Add ability to disable progress indicator Mattijs Korpershoek
2026-01-29 16:33 ` Marek Vasut
2026-01-29 16:53 ` Tom Rini [this message]
2026-01-29 16:57 ` Marek Vasut
2026-01-29 17:16 ` Tom Rini
2026-01-29 17:25 ` Marek Vasut
2026-01-29 19:21 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129165341.GC2044980@bill-the-cat \
--to=trini@konsulko.com \
--cc=agraf@csgraf.de \
--cc=ilias.apalodimas@linaro.org \
--cc=jerome@forissier.org \
--cc=marek.vasut@mailbox.org \
--cc=mkorpershoek@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=peng.fan@nxp.com \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
--cc=yuya.hamamachi.sx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox