* [PATCH 0/2] imx9[4,5]_evk: Drop init_uart_clk from board code
@ 2026-02-06 4:25 Peng Fan (OSS)
2026-02-06 4:25 ` [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk Peng Fan (OSS)
2026-02-06 4:25 ` [PATCH 2/2] nxp: imx94_evk: " Peng Fan (OSS)
0 siblings, 2 replies; 7+ messages in thread
From: Peng Fan (OSS) @ 2026-02-06 4:25 UTC (permalink / raw)
To: NXP i.MX U-Boot Team, u-boot
Cc: Stefano Babic, Fabio Estevam, Alice Guo, Tom Rini, Ye Li,
Peng Fan
The serial driver could enable the uart clk using clk_enable, there
is no need to call init_uart_clk in board_early_init_f.
The init_uart_clk() function is still kept, in case it is needed for
debug purpose.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Peng Fan (2):
nxp: imx95_evk: Drop init_uart_clk
nxp: imx94_evk: Drop init_uart_clk
board/nxp/imx94_evk/imx94_evk.c | 1 -
board/nxp/imx95_evk/imx95_evk.c | 3 ---
2 files changed, 4 deletions(-)
---
base-commit: b5213bbfdcb1812be510427857827ee8becb9f8f
change-id: 20260206-imx9-board-clean-uart-7eda1c7fed1c
Best regards,
--
Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk
2026-02-06 4:25 [PATCH 0/2] imx9[4,5]_evk: Drop init_uart_clk from board code Peng Fan (OSS)
@ 2026-02-06 4:25 ` Peng Fan (OSS)
2026-02-06 8:35 ` Francesco Dolcini
2026-02-06 10:43 ` Fabio Estevam
2026-02-06 4:25 ` [PATCH 2/2] nxp: imx94_evk: " Peng Fan (OSS)
1 sibling, 2 replies; 7+ messages in thread
From: Peng Fan (OSS) @ 2026-02-06 4:25 UTC (permalink / raw)
To: NXP i.MX U-Boot Team, u-boot
Cc: Stefano Babic, Fabio Estevam, Alice Guo, Tom Rini, Ye Li,
Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Rely on serial driver calling clk_enable to enable the lpuart clk, no
need to do init_uart_clk in board_early_init_f().
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
board/nxp/imx95_evk/imx95_evk.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/board/nxp/imx95_evk/imx95_evk.c b/board/nxp/imx95_evk/imx95_evk.c
index ca1d916deab..9cb69543f0f 100644
--- a/board/nxp/imx95_evk/imx95_evk.c
+++ b/board/nxp/imx95_evk/imx95_evk.c
@@ -9,9 +9,6 @@
int board_early_init_f(void)
{
- /* UART1: A55, UART2: M33, UART3: M7 */
- init_uart_clk(0);
-
return 0;
}
--
2.51.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] nxp: imx94_evk: Drop init_uart_clk
2026-02-06 4:25 [PATCH 0/2] imx9[4,5]_evk: Drop init_uart_clk from board code Peng Fan (OSS)
2026-02-06 4:25 ` [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk Peng Fan (OSS)
@ 2026-02-06 4:25 ` Peng Fan (OSS)
1 sibling, 0 replies; 7+ messages in thread
From: Peng Fan (OSS) @ 2026-02-06 4:25 UTC (permalink / raw)
To: NXP i.MX U-Boot Team, u-boot
Cc: Stefano Babic, Fabio Estevam, Alice Guo, Tom Rini, Ye Li,
Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Rely on serial driver calling clk_enable to enable the lpuart clk, no
need to do init_uart_clk in board_early_init_f().
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
board/nxp/imx94_evk/imx94_evk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/board/nxp/imx94_evk/imx94_evk.c b/board/nxp/imx94_evk/imx94_evk.c
index 588aa7548d4..dafe680edbf 100644
--- a/board/nxp/imx94_evk/imx94_evk.c
+++ b/board/nxp/imx94_evk/imx94_evk.c
@@ -11,7 +11,6 @@
int board_early_init_f(void)
{
- init_uart_clk(0);
return 0;
}
--
2.51.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk
2026-02-06 4:25 ` [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk Peng Fan (OSS)
@ 2026-02-06 8:35 ` Francesco Dolcini
2026-02-06 13:27 ` Peng Fan
2026-02-06 10:43 ` Fabio Estevam
1 sibling, 1 reply; 7+ messages in thread
From: Francesco Dolcini @ 2026-02-06 8:35 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: NXP i.MX U-Boot Team, u-boot, Stefano Babic, Fabio Estevam,
Alice Guo, Tom Rini, Ye Li, Peng Fan
Hello Peng,
On Fri, Feb 06, 2026 at 12:25:42PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Rely on serial driver calling clk_enable to enable the lpuart clk, no
> need to do init_uart_clk in board_early_init_f().
It seems we copied the same mistake from your evk on our board,
see board/toradex/smarc-imx95/smarc-imx95.c:board_early_init_f(). Maybe
you can just fix also that one.
And I see init_uart_clk() called in a multiple imx8m board in U-Boot,
any comment on those?
Francesco
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk
2026-02-06 4:25 ` [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk Peng Fan (OSS)
2026-02-06 8:35 ` Francesco Dolcini
@ 2026-02-06 10:43 ` Fabio Estevam
2026-02-06 13:59 ` Peng Fan
1 sibling, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2026-02-06 10:43 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: NXP i.MX U-Boot Team, u-boot, Stefano Babic, Alice Guo, Tom Rini,
Ye Li, Peng Fan
Hi Peng,
On Fri, Feb 6, 2026 at 12:11 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
> diff --git a/board/nxp/imx95_evk/imx95_evk.c b/board/nxp/imx95_evk/imx95_evk.c
> index ca1d916deab..9cb69543f0f 100644
> --- a/board/nxp/imx95_evk/imx95_evk.c
> +++ b/board/nxp/imx95_evk/imx95_evk.c
> @@ -9,9 +9,6 @@
>
> int board_early_init_f(void)
> {
> - /* UART1: A55, UART2: M33, UART3: M7 */
> - init_uart_clk(0);
> -
> return 0;
Can board_early_init_f() be completely removed from the board file now?
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk
2026-02-06 8:35 ` Francesco Dolcini
@ 2026-02-06 13:27 ` Peng Fan
0 siblings, 0 replies; 7+ messages in thread
From: Peng Fan @ 2026-02-06 13:27 UTC (permalink / raw)
To: Francesco Dolcini, Peng Fan (OSS)
Cc: dl-uboot-imx, u-boot@lists.denx.de, Stefano Babic, Fabio Estevam,
Alice Guo, Tom Rini, Ye Li
> Subject: Re: [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk
>
> Hello Peng,
>
> On Fri, Feb 06, 2026 at 12:25:42PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Rely on serial driver calling clk_enable to enable the lpuart clk, no
> > need to do init_uart_clk in board_early_init_f().
>
> It seems we copied the same mistake from your evk on our board, see
> board/toradex/smarc-imx95/smarc-imx95.c:board_early_init_f().
> Maybe you can just fix also that one.
ok.
>
> And I see init_uart_clk() called in a multiple imx8m board in U-Boot,
> any comment on those?
I need to give a look and test to see whether it is safe to remove
the call to init_uart_clk.
My previous cleanup patchset also touches the board file. There will
be conflict for Fabio/Tom to manage the patches, I will defer
imx8m init_uart_clk changes. So V2 is still only for i.MX95/4.
Thanks,
Peng.
>
> Francesco
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk
2026-02-06 10:43 ` Fabio Estevam
@ 2026-02-06 13:59 ` Peng Fan
0 siblings, 0 replies; 7+ messages in thread
From: Peng Fan @ 2026-02-06 13:59 UTC (permalink / raw)
To: Fabio Estevam, Peng Fan (OSS)
Cc: dl-uboot-imx, u-boot@lists.denx.de, Stefano Babic, Alice Guo,
Tom Rini, Ye Li
> Subject: Re: [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk
>
> Hi Peng,
>
> On Fri, Feb 6, 2026 at 12:11 AM Peng Fan (OSS)
> <peng.fan@oss.nxp.com> wrote:
>
> > diff --git a/board/nxp/imx95_evk/imx95_evk.c
> > b/board/nxp/imx95_evk/imx95_evk.c index
> ca1d916deab..9cb69543f0f
> > 100644
> > --- a/board/nxp/imx95_evk/imx95_evk.c
> > +++ b/board/nxp/imx95_evk/imx95_evk.c
> > @@ -9,9 +9,6 @@
> >
> > int board_early_init_f(void)
> > {
> > - /* UART1: A55, UART2: M33, UART3: M7 */
> > - init_uart_clk(0);
> > -
> > return 0;
>
> Can board_early_init_f() be completely removed from the board file
> now?
Sure. I will remove it.
Regards
Peng
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-02-06 13:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-06 4:25 [PATCH 0/2] imx9[4,5]_evk: Drop init_uart_clk from board code Peng Fan (OSS)
2026-02-06 4:25 ` [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk Peng Fan (OSS)
2026-02-06 8:35 ` Francesco Dolcini
2026-02-06 13:27 ` Peng Fan
2026-02-06 10:43 ` Fabio Estevam
2026-02-06 13:59 ` Peng Fan
2026-02-06 4:25 ` [PATCH 2/2] nxp: imx94_evk: " Peng Fan (OSS)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox