RE: [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk

Peng Fan
2026-02-06T13:27:27Z

> Subject: Re: [PATCH 1/2] nxp: imx95_evk: Drop init_uart_clk
>
> Hello Peng,
>
> On Fri, Feb 06, 2026 at 12:25:42PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Rely on serial driver calling clk_enable to enable the lpuart clk, no
> > need to do init_uart_clk in board_early_init_f().
>
> It seems we copied the same mistake from your evk on our board, see
> board/toradex/smarc-imx95/smarc-imx95.c:board_early_init_f().
> Maybe you can just fix also that one.

ok.

>
> And I see init_uart_clk() called in a multiple imx8m board in U-Boot,
> any comment on those?

I need to give a look and test to see whether it is safe to remove
the call to init_uart_clk.

My previous cleanup patchset also touches the board file. There will
be conflict for Fabio/Tom to manage the patches, I will defer
imx8m init_uart_clk changes. So V2 is still only for i.MX95/4.

Thanks,
Peng.

>
> Francesco