public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@nabladev.com>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Fabio Estevam <festevam@gmail.com>,
	Peng Fan <peng.fan@oss.nxp.com>, Heiko Schocher <hs@nabladev.com>,
	Peng Fan <peng.fan@nxp.com>,
	Adrian Freihofer <adrian.freihofer@siemens.com>,
	Alexander Sverdlin <alexander.sverdlin@siemens.com>,
	Tom Rini <trini@konsulko.com>,
	Walter Schweizer <walter.schweizer@siemens.com>
Subject: [PATCH v2 08/11] siemens: capricorn: always detect emmc device
Date: Sat, 14 Feb 2026 05:57:00 +0100	[thread overview]
Message-ID: <20260214045703.28051-9-hs@nabladev.com> (raw)
In-Reply-To: <20260214045703.28051-1-hs@nabladev.com>

drop Environment variable mmcautodetect and the board logic
behind it, as we want always to autodetct the emmc device.

Signed-off-by: Heiko Schocher <hs@nabladev.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>

---

Changes in v2:
Added Reviewed-by from Peng

 board/siemens/capricorn/board.c               | 13 -------------
 board/siemens/capricorn/capricorn_default.env |  1 -
 2 files changed, 14 deletions(-)

diff --git a/board/siemens/capricorn/board.c b/board/siemens/capricorn/board.c
index 34e7f2d1713..ba6c96a409c 100644
--- a/board/siemens/capricorn/board.c
+++ b/board/siemens/capricorn/board.c
@@ -357,16 +357,6 @@ int board_mmc_get_env_dev(int devno)
 	return devno;
 }
 
-static int check_mmc_autodetect(void)
-{
-	char *autodetect_str = env_get("mmcautodetect");
-
-	if (autodetect_str && (strcmp(autodetect_str, "yes") == 0))
-		return 1;
-
-	return 0;
-}
-
 /* This should be defined for each board */
 __weak int mmc_map_to_kernel_blk(int dev_no)
 {
@@ -377,9 +367,6 @@ void board_late_mmc_env_init(void)
 {
 	u32 dev_no = mmc_get_env_dev();
 
-	if (!check_mmc_autodetect())
-		return;
-
 	env_set_ulong("mmcdev", dev_no);
 }
 
diff --git a/board/siemens/capricorn/capricorn_default.env b/board/siemens/capricorn/capricorn_default.env
index c8b5b3d7da3..ad88f7ed770 100644
--- a/board/siemens/capricorn/capricorn_default.env
+++ b/board/siemens/capricorn/capricorn_default.env
@@ -45,4 +45,3 @@ kboot=booti
 bootcmd_mfg=run mfgtool_args; if iminfo ${initrd_addr}; then if test ${tee} = yes; then bootm ${tee_addr} ${initrd_addr} ${fdt_addr}; else booti ${loadaddr} ${initrd_addr} ${fdt_addr}; fi; else echo "Run fastboot ..."; fastboot usb auto; fi;
 fastboot_bytes=124c00
 fastboot_dev=mmc
-mmcautodetect=yes
-- 
2.20.1


  parent reply	other threads:[~2026-02-14  4:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14  4:56 [PATCH v2 00/11] imx8qxp: siemens: small board updates Heiko Schocher
2026-02-14  4:56 ` [PATCH v2 01/11] arm: dts: capricorn: pinctrl_usdhc1 cleanup Heiko Schocher
2026-02-14  4:56 ` [PATCH v2 02/11] siemens: capricorn: set max-frequency for usdhc1 Heiko Schocher
2026-02-14  4:56 ` [PATCH v2 03/11] arm: dts: capricorn: remove pinctrl_usdhc2 Heiko Schocher
2026-02-14  4:56 ` [PATCH v2 04/11] arm: dts: capricorn: move fec2 config Heiko Schocher
2026-02-14  4:56 ` [PATCH v2 05/11] imx8qxp_capricorn config: add wget command Heiko Schocher
2026-02-16 10:15   ` Marek Vasut
2026-02-16 10:53     ` Heiko Schocher
2026-02-16 11:19       ` Marek Vasut
2026-02-16 11:54   ` Fabio Estevam
2026-02-14  4:56 ` [PATCH v2 06/11] capricorn: config: add bootcounter command Heiko Schocher
2026-02-14  4:56 ` [PATCH v2 07/11] siemens: capricorn: add logic to U-Boot to avoid zig-zag boot Heiko Schocher
2026-02-14  4:57 ` Heiko Schocher [this message]
2026-02-14  4:57 ` [PATCH v2 09/11] siemens: capricorn: fix fallback bootm call for fitImage Heiko Schocher
2026-02-14  4:57 ` [PATCH v2 10/11] siemens: capricorn: rework bootcmd environment variables Heiko Schocher
2026-02-14  4:57 ` [PATCH v2 11/11] siemens: capricorn: protect environment Heiko Schocher
2026-02-16  7:33 ` [PATCH v2 00/11] imx8qxp: siemens: small board updates Max Merchel
2026-02-16  7:49   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260214045703.28051-9-hs@nabladev.com \
    --to=hs@nabladev.com \
    --cc=adrian.freihofer@siemens.com \
    --cc=alexander.sverdlin@siemens.com \
    --cc=festevam@gmail.com \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=walter.schweizer@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox