Re: [RFC PATCH 00/20] boot: add OpenWrt boot method and on-demand FIT loading

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2660 bytes --]

On Mon, Feb 16, 2026 at 09:21:14PM +0000, Daniel Golle wrote:

> Hi all,
> 
> This RFC series adds a new boot method for OpenWrt's "uImage.FIT with
> embedded rootfs" firmware model, along with the underlying infrastructure
> to load FIT images on-demand directly from storage devices without copying
> them entirely to RAM first.
> 
> I would like to discuss the design with U-Boot maintainers and fellow
> OpenWrt developers before submitting a formal patch series.
[snip]
>  boot/Kconfig                   |  88 +++++++
>  boot/Makefile                  |   8 +
>  boot/bootm.c                   |  62 ++++-
>  boot/bootmeth_openwrt.c        | 248 +++++++++++++++++++
>  boot/image-fit.c               |  96 ++++++++
>  boot/image-loader-blk.c        | 133 ++++++++++
>  boot/image-loader-mtd.c        | 103 ++++++++
>  boot/image-loader-ubi.c        | 112 +++++++++
>  boot/image-loader.c            | 163 +++++++++++++
>  boot/mtd_bootdev.c             | 150 ++++++++++++
>  boot/ubi_bootdev.c             | 180 ++++++++++++++
>  cmd/bootm.c                    | 148 +++++++++++-
>  cmd/mtd.c                      |  65 ++---
>  cmd/ubi.c                      |  33 ++-
>  doc/develop/bootm-storage.rst  | 210 ++++++++++++++++
>  doc/develop/index.rst          |   1 +
>  doc/usage/fit/index.rst        |   1 +
>  doc/usage/fit/storage-boot.rst | 201 +++++++++++++++
>  drivers/mtd/mtd-uclass.c       |  15 ++
>  drivers/mtd/mtdcore.c          |  45 ++++
>  drivers/mtd/mtdpart.c          |   2 +
>  include/bootm.h                |   2 +
>  include/image-loader.h         | 188 +++++++++++++++
>  include/image.h                |   4 +
>  include/linux/mtd/mtd.h        |  24 ++
>  include/ubi_uboot.h            |   2 +
>  test/boot/Makefile             |   2 +
>  test/boot/image_loader.c       | 429 +++++++++++++++++++++++++++++++++
>  test/cmd_ut.c                  |   2 +

This isn't enabled on any platforms, and not enabled on sandbox either
so the tests aren't run. Please do that for the next iteration as well.
Since you mentioned one of the Banana Pi boards, including that would be
helpful too. If you can also include support for the openwrt one (and
instructions on how to flash it, if
https://openwrt.org/toh/openwrt/one#uart_boot) isn't enough that would
be great since I have one of those at hand.

Finally, aside from the feedback I just gave about splitting the image
portion out, it seemed like a few other changes here could be considered
stand-alone bug fixes themselves. Posting them outside of a series helps
both for ease of review and ease of merging. Thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]