From: Tom Rini <trini@konsulko.com>
To: Jeffrey Yu <jeyu@issi.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
"Mutya, Havish" <havish.mutya@amd.com>,
"Kumar, Love" <love.kumar@amd.com>,
Ron Kalakuntla <rkalakun@issi.com>, Ji-Ho Kim <jhkim@issi.com>,
Johnny Chien <jchien@issi.com>, Anand Bagchi <abagchi@issi.com>
Subject: Re: [PATCH] spi: add support for ISSI flash uboot 2025
Date: Fri, 20 Feb 2026 10:33:22 -0600 [thread overview]
Message-ID: <20260220163322.GA86794@bill-the-cat> (raw)
In-Reply-To: <PH7PR19MB73617F02C51FF5AFFA7AC0C3B6A7A@PH7PR19MB7361.namprd19.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 3519 bytes --]
On Fri, Dec 05, 2025 at 03:21:05AM +0000, Jeffrey Yu wrote:
> Signed-off-by: jeffrey yu <jeyu@issi.com>
> ---
> drivers/mtd/spi/spi-nor-ids.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index b4221a82e01..c6d65196ebc 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -222,6 +222,8 @@ const struct flash_info spi_nor_ids[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_HAS_TB) },
> { INFO("is25lp512", 0x9d601a, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_TB) },
> + { INFO("is25lp512mj", 0x9d6020, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { INFO("is25lp01g", 0x9d601b, 0, 64 * 1024, 2048,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_TB) },
> { INFO("is25lp02g", 0x9d6022, 0, 64 * 1024, 4096,
> @@ -239,6 +241,8 @@ const struct flash_info spi_nor_ids[] = {
> SPI_NOR_4B_OPCODES) },
> { INFO("is25wp512", 0x9d701a, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> + { INFO("is25wp512mj", 0x9d7020, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { INFO("is25wp01g", 0x9d701b, 0, 64 * 1024, 2048,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { INFO("is25wx256", 0x9d5b19, 0, 128 * 1024, 256,
> @@ -249,6 +253,22 @@ const struct flash_info spi_nor_ids[] = {
> SPI_NOR_OCTAL_DTR_READ | SPI_NOR_OCTAL_DTR_PP) },
> { INFO("is25lp01gg", 0x9d6021, 0, 64 * 1024, 2048,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_TB) },
> + { INFO("is25lp010e", 0x9d4011, 0, 64 * 1024, 2,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> + { INFO("is25lp020e", 0x9d4012, 0, 64 * 1024, 4,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> + { INFO("is25lp040e", 0x9d4013, 0, 64 * 1024, 8,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> + { INFO("is25lp01gj", 0x9d6021, 0, 64 * 1024, 2048,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_TB) },
> + { INFO("is25lp02gg", 0x9d6022, 0, 64 * 1024, 4096,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_TB) },
> + { INFO("is25lp02gj", 0x9d6022, 0, 64 * 1024, 4096,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_TB) },
> + { INFO("is25wp01gg", 0x9d7021, 0, 64 * 1024, 2048,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_TB) },
> + { INFO("is25wp01gj", 0x9d7021, 0, 64 * 1024, 2048,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_TB) },
> + { INFO("is25wj128f", 0x9d7118, 0, 64 * 1024, 256,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_TB) },
> + { INFO("is25wp02gg", 0x9d7022, 0, 64 * 1024, 4096,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_TB) },
> + { INFO("is25wp02gj", 0x9d7022, 0, 64 * 1024, 4096,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_TB) },
> #endif
> #ifdef CONFIG_SPI_FLASH_MACRONIX /* MACRONIX */
> /* Macronix */
In that this introduces no new problems with how we handle these types
of flash today, this is OK. However, the commit subject needs to be
clarified and then an actual commit message needs to be provided,
perhaps with some links to datasheets or similar. Thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-02-20 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 3:21 [PATCH] spi: add support for ISSI flash uboot 2025 Jeffrey Yu
2026-02-20 16:33 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220163322.GA86794@bill-the-cat \
--to=trini@konsulko.com \
--cc=abagchi@issi.com \
--cc=havish.mutya@amd.com \
--cc=jchien@issi.com \
--cc=jeyu@issi.com \
--cc=jhkim@issi.com \
--cc=love.kumar@amd.com \
--cc=rkalakun@issi.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox