public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kory Maincent <kory.maincent@bootlin.com>
To: u-boot@lists.denx.de
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Tom Rini" <trini@konsulko.com>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Paul HENRYS" <paul.henrys_ext@softathome.com>,
	"Sughosh Ganu" <sughosh.ganu@arm.com>,
	"Greg Malysa" <malysagreg@gmail.com>,
	"Arturs Artamonovs" <arturs.artamonovs@analog.com>,
	"Vasileios Bimpikas" <vasileios.bimpikas@analog.com>,
	"Utsav Agarwal" <utsav.agarwal@analog.com>,
	"Nathan Barrett-Morrison" <nathan.morrison@timesys.com>,
	"Peng Fan" <peng.fan@nxp.com>, "Simon Glass" <sjg@chromium.org>,
	"Duje Mihanović" <duje@dujemihanovic.xyz>,
	"Stefan Roese" <stefan.roese@mailbox.org>,
	"Mattijs Korpershoek" <mkorpershoek@kernel.org>,
	"Sumit Garg" <sumit.garg@kernel.org>,
	"Heiko Schocher" <hs@nabladev.com>,
	"Alif Zakuan Yuslaimi" <alif.zakuan.yuslaimi@altera.com>,
	"E Shattow" <e@freeshell.de>,
	"Raymond Mao" <raymondmaoca@gmail.com>,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Shiji Yang" <yangshiji66@outlook.com>,
	"Daniel Golle" <daniel@makrotopia.org>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"Leonard Anderweit" <l.anderweit@phytec.de>,
	"Kory Maincent" <kory.maincent@bootlin.com>,
	"Yao Zi" <me@ziyao.cc>
Subject: [PATCH v4 4/6] tools: mkfwumdata: Add bank count validation for FWU metadata v2
Date: Mon, 23 Feb 2026 14:18:38 +0100	[thread overview]
Message-ID: <20260223-feature_fwumdata-v4-4-680ea4ad6ce6@bootlin.com> (raw)
In-Reply-To: <20260223-feature_fwumdata-v4-0-680ea4ad6ce6@bootlin.com>

The FWU metadata specification version 2 supports a maximum of 4 banks.
Add validation to enforce this limit and prevent creation of non-compliant
metadata structures when using version 2.

Without this check, users could inadvertently create invalid metadata by
specifying more than 4 banks, leading to potential compatibility issues
with FWU-compliant firmware update implementations.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 tools/fwumdata_src/mkfwumdata.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/fwumdata_src/mkfwumdata.c b/tools/fwumdata_src/mkfwumdata.c
index 5ceec7a2980..8b25539fd57 100644
--- a/tools/fwumdata_src/mkfwumdata.c
+++ b/tools/fwumdata_src/mkfwumdata.c
@@ -471,6 +471,12 @@ int main(int argc, char *argv[])
 		return -EINVAL;
 	}
 
+	if (version == 2 && banks > MAX_BANKS_V2) {
+		fprintf(stderr, "Error: Version 2 supports maximum %d banks, %ld requested.\n",
+			MAX_BANKS_V2, banks);
+		return -EINVAL;
+	}
+
 	/* This command takes UUIDs * images and output file. */
 	if (optind + images + 1 != argc) {
 		fprintf(stderr,

-- 
2.43.0


  parent reply	other threads:[~2026-02-23 13:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 13:18 [PATCH v4 0/6] Add support for fwumdata Kory Maincent
2026-02-23 13:18 ` [PATCH v4 1/6] tools: gitignore: Add mkfwumdata to the git ignore file Kory Maincent
2026-02-23 13:18 ` [PATCH v4 2/6] tools: Reorganize mkfwumdata tool into fwumdata_src directory Kory Maincent
2026-02-23 13:18 ` [PATCH v4 3/6] tools: mkfwumdata: Improve error message specificity Kory Maincent
2026-02-23 13:18 ` Kory Maincent [this message]
2026-02-23 13:18 ` [PATCH v4 5/6] tools: Add support for fwumdata tool Kory Maincent
2026-02-23 13:18 ` [PATCH v4 6/6] tools: mkfwumdata: Remove dependency on fwu_mdata.h header Kory Maincent
2026-03-18 11:27 ` [PATCH v4 0/6] Add support for fwumdata Dario Binacchi
2026-03-25 10:29   ` Kory Maincent
2026-03-25 10:50     ` Sughosh Ganu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260223-feature_fwumdata-v4-4-680ea4ad6ce6@bootlin.com \
    --to=kory.maincent@bootlin.com \
    --cc=alif.zakuan.yuslaimi@altera.com \
    --cc=arturs.artamonovs@analog.com \
    --cc=daniel@makrotopia.org \
    --cc=duje@dujemihanovic.xyz \
    --cc=e@freeshell.de \
    --cc=hs@nabladev.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jan.kiszka@siemens.com \
    --cc=l.anderweit@phytec.de \
    --cc=malysagreg@gmail.com \
    --cc=me@ziyao.cc \
    --cc=mkorpershoek@kernel.org \
    --cc=nathan.morrison@timesys.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=paul.henrys_ext@softathome.com \
    --cc=peng.fan@nxp.com \
    --cc=raymondmaoca@gmail.com \
    --cc=sjg@chromium.org \
    --cc=stefan.roese@mailbox.org \
    --cc=sughosh.ganu@arm.com \
    --cc=sumit.garg@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=utsav.agarwal@analog.com \
    --cc=vasileios.bimpikas@analog.com \
    --cc=xypron.glpk@gmx.de \
    --cc=yangshiji66@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox