From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDD85EF8FF4 for ; Wed, 4 Mar 2026 15:24:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 24F22838BB; Wed, 4 Mar 2026 16:24:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="gAs+dAXi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 332E083AA9; Wed, 4 Mar 2026 16:24:53 +0100 (CET) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EBE4E83642 for ; Wed, 4 Mar 2026 16:24:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=conor@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 59F80432B6; Wed, 4 Mar 2026 15:24:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9AC9C4CEF7; Wed, 4 Mar 2026 15:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772637889; bh=ghcHLFieJTbDB9yoOqGqL924EGH4vPu+pje0hF/xJaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gAs+dAXi6yiruLoBec9RupFdzo8WTg/hOWFpIHgbk0sj0KbbP7yQDSitvwsl9u9ld d8DxwtujVjEzRXL6IZRwsVCEZTdGmFWFm2VXTqmSBMciJ8c8YGVNWmCHTpGDtmY2Dk p8e16fIcUXBzaARpPdS5bKaANyeobj7IKLN4uT3sgKtVaKBYhTPu18a/pNnOSPGdqz St6m+TKgAJzl6VeexXKKlRqYpA5OPWb8vh7hoo8sitVkzUfBWUJZVILamD+4sCt4q7 DAiUVYYBUnRqCd/KT5j09n/iysdh/2NFHslqlRrNgojF3vII772Q0kUcXrhj2k0v0B lxsLnun5wgMFQ== Date: Wed, 4 Mar 2026 15:24:45 +0000 From: Conor Dooley To: Tom Rini Cc: u-boot@lists.denx.de, Simon Glass , Ilias Apalodimas , Simon Glass , Sughosh Ganu Subject: Re: [PATCH] kbuild: unexport sub_make_done to fix child make invocations Message-ID: <20260304-germproof-gawk-d26040529131@spud> References: <20260214024736.3726811-1-simon.glass@canonical.com> <177256385549.3975993.592734328770415000.b4-ty@konsulko.com> <20260304-robe-praising-5509e3a984cd@spud> <20260304150145.GX1388590@bill-the-cat> <20260304-acquaint-wager-688fd7fbae6a@spud> <20260304151154.GY1388590@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xM3qPq/sripHeDH7" Content-Disposition: inline In-Reply-To: <20260304151154.GY1388590@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --xM3qPq/sripHeDH7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 04, 2026 at 09:11:54AM -0600, Tom Rini wrote: > On Wed, Mar 04, 2026 at 03:09:40PM +0000, Conor Dooley wrote: > > On Wed, Mar 04, 2026 at 09:01:45AM -0600, Tom Rini wrote: > > > On Wed, Mar 04, 2026 at 09:54:22AM +0000, Conor Dooley wrote: > > > > On Tue, Mar 03, 2026 at 12:50:55PM -0600, Tom Rini wrote: > > > > > On Fri, 13 Feb 2026 19:47:34 -0700, Simon Glass wrote: > > > > >=20 > > > > > > The exported sub_make_done variable leaks into the environment = of all > > > > > > child processes. When make targets like tcheck spawn independen= t make > > > > > > invocations with O=3D, those child makes inherit sub_make_done= =3D1, skip > > > > > > the KBUILD_OUTPUT setup and try to build in the source tree. > > > > > >=20 > > > > > > There is a workaround that resets sub_make_done to 0 for specif= ic test > > > > > > targets, but this isn't great since it has tolist every target = that > > > > > > spawns independent make invocations. > > > > > >=20 > > > > > > [...] > > > > >=20 > > > > > Applied to u-boot/master, thanks! > > > > >=20 > > > > > [1/1] kbuild: unexport sub_make_done to fix child make invocations > > > > > commit: 4284306d22c5b6d64ecd62b462551d9d313c8104 > > > >=20 > > > >=20 > > > > This breaks the build for me: > > > > make ARCH=3Driscv CROSS_COMPILE=3Driscv64-unknown-linux-gnu- O=3Dbu= ild microchip_mpfs_generic_defconfig > > > > GEN Makefile > > > > # > > > > # configuration written to .config > > > > # > > > > make ARCH=3Driscv CROSS_COMPILE=3Driscv64-unknown-linux-gnu- O=3Dbu= ild > > > > HOSTCC scripts/basic/fixdep > > > > GEN Makefile > > > > HOSTCC scripts/kconfig/conf.o > > > > YACC scripts/kconfig/zconf.tab.[ch] > > > > LEX scripts/kconfig/zconf.lex.c > > > > HOSTCC scripts/kconfig/zconf.tab.o > > > > HOSTLD scripts/kconfig/conf > > > > scripts/kconfig/conf --syncconfig Kconfig > > > > *** > > > > *** Configuration file ".config" not found! > > > > *** > > > > *** Please run some configurator (e.g. "make oldconfig" or > > > > *** "make menuconfig" or "make xconfig"). > > > > *** > > > > make[4]: *** [/stuff/u-boot/scripts/kconfig/Makefile:75: syncconfig= ] Error 1 > > > > make[3]: *** [/stuff/u-boot/Makefile:702: syncconfig] Error 2 > > > > make[2]: *** [../Makefile:189: __sub-make] Error 2 > > > > make[1]: *** No rule to make target 'include/config/auto.conf', nee= ded by 'include/config/uboot.release'. Stop. > > > > make: *** [Makefile:189: __sub-make] Error 2 > > >=20 > > > That's odd. What host distro and make? I don't see that on Ubuntu 24.= 04. > >=20 > > Originally my CI found it in a docker container with "from: ubuntu:nobl= e", > > so 24.04. I reproduced it locally on debian unstable with make 4.4.1 >=20 > That's even more puzzling (noble is 24.04) since that sounds very close > to our CI too. Can you please look more in to what's going on? Can I assume your CI also sets O=3D then? Is the CI config stuff in tree, or somewhere else? --xM3qPq/sripHeDH7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaahOvQAKCRB4tDGHoIJi 0h/UAQCEZCm027p3U85HHgr+cfuKukAf1+zJn2/3NK+82YPVSQEAut3mYi10lvMV 29qRpxcFlD5LgXmABxsrUYao5jOZVwY= =Q+kz -----END PGP SIGNATURE----- --xM3qPq/sripHeDH7--