From: Francesco Dolcini <francesco@dolcini.it>
To: Emanuele Ghidoli <ghidoliemanuele@gmail.com>,
Simona Toaca <simona.toaca@oss.nxp.com>
Cc: uboot-imx@nxp.com, u-boot@lists.denx.de,
Stefano Babic <sbabic@nabladev.com>,
festevam@gmail.com, peng.fan@nxp.com, alice.guo@nxp.com,
ye.li@nxp.com, simona.toaca@nxp.com, viorel.suman@nxp.com,
marex@nabladev.com, ravi@prevas.dk, fedor.ross@ifm.com,
sebastien.szymanski@armadeus.com, joao.goncalves@toradex.com,
ji.luo@nxp.com, semen.protsenko@linaro.org, sjg@chromium.org,
tharvey@gateworks.com, ping.bai@nxp.com, qijian.guo@nxp.com
Subject: Re: [PATCH 4/5] board: nxp: imx9{4,5}_evk: Add qb save option in SPL
Date: Wed, 11 Mar 2026 10:14:19 +0100 [thread overview]
Message-ID: <20260311091419.GA6525@francesco-nb> (raw)
In-Reply-To: <llrc46dn7akdpro5bim3egfuuktyvwbrmb4odenspiz7tnwdme@3hc5leohkgzr>
On Tue, Mar 10, 2026 at 05:27:45PM +0200, Simona Toaca wrote:
> On Tue, Mar 10, 2026 at 04:04:19PM +0100, Emanuele Ghidoli wrote:
> > On 3/10/26 12:54, Simona Toaca (OSS) wrote:
> > > From: Simona Toaca <simona.toaca@nxp.com>
> > >
> > > Call qb save automatically in the board-specific
> > > spl_board_init(), if SPL_QB option is enabled. This
> > > makes sure qb_save is called before any image loading
> > > is done by the SPL.
> > >
> > > Signed-off-by: Simona Toaca <simona.toaca@nxp.com>
...
> > > diff --git a/board/nxp/imx94_evk/spl.c b/board/nxp/imx94_evk/spl.c
> > > index cc5b7f9ef0f..1d25795eb17 100644
> > > --- a/board/nxp/imx94_evk/spl.c
> > > +++ b/board/nxp/imx94_evk/spl.c
> > > @@ -44,6 +45,9 @@ void spl_board_init(void)
> > > ret = ele_start_rng();
> > > if (ret)
> > > printf("Fail to start RNG: %d\n", ret);
> > > +
> > > + if (IS_ENABLED(CONFIG_SPL_IMX_QB))
> > > + spl_qb_save();
> > Does it write to MMC/NOR/SD at every boot? Is that necessary if a quick boot
> > was performed and the data has not changed?
> > > }
> No, the qb() method calls qb_check, which returns true only if OEI
> saved valid data to volatile memory (meaning it has run Training flow).
> So, if Quickboot flow is run, the data in volatile memory is not valid,
> qb_check fails -> qb returns and does not write anything to the NVM.
>
> Also, another thing to keep in mind is that after a successfull
> qb save, the data in volatile memory is invalidated -> qb check will
> fail as well even if OEI doesn't run (so on a warm reboot).
Do you think that this is something that should be generally enabled on
any i.MX95 boards? Emanuele?
Francesco
next prev parent reply other threads:[~2026-03-11 9:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 11:54 [PATCH 0/5] imx9{4,5}: Add Quickboot support Simona Toaca (OSS)
2026-03-10 11:54 ` [PATCH 1/5] imx9: Add support for saving DDR training data to NVM Simona Toaca (OSS)
2026-03-10 11:54 ` [PATCH 2/5] arm: mach-imx: Add command to expose QB functionality Simona Toaca (OSS)
2026-03-10 11:54 ` [PATCH 3/5] imx9: Enable QB data saving for iMX9{4,5} EVK Simona Toaca (OSS)
2026-03-10 11:54 ` [PATCH 4/5] board: nxp: imx9{4,5}_evk: Add qb save option in SPL Simona Toaca (OSS)
2026-03-10 15:04 ` Emanuele Ghidoli
2026-03-10 15:27 ` Simona Toaca
2026-03-11 9:14 ` Francesco Dolcini [this message]
2026-03-11 14:58 ` Simona Toaca
2026-03-10 16:12 ` Fabio Estevam
2026-03-11 7:54 ` Simona Toaca
2026-03-10 11:54 ` [PATCH 5/5] doc: board: nxp: Add Quickboot documentation Simona Toaca (OSS)
2026-03-11 15:42 ` [PATCH 0/5] imx9{4,5}: Add Quickboot support Marek Vasut
2026-03-12 11:47 ` Simona Toaca
2026-03-12 13:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260311091419.GA6525@francesco-nb \
--to=francesco@dolcini.it \
--cc=alice.guo@nxp.com \
--cc=fedor.ross@ifm.com \
--cc=festevam@gmail.com \
--cc=ghidoliemanuele@gmail.com \
--cc=ji.luo@nxp.com \
--cc=joao.goncalves@toradex.com \
--cc=marex@nabladev.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=qijian.guo@nxp.com \
--cc=ravi@prevas.dk \
--cc=sbabic@nabladev.com \
--cc=sebastien.szymanski@armadeus.com \
--cc=semen.protsenko@linaro.org \
--cc=simona.toaca@nxp.com \
--cc=simona.toaca@oss.nxp.com \
--cc=sjg@chromium.org \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
--cc=viorel.suman@nxp.com \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox