Re: [PATCH] optee: Correct dependencies for BOOTM_OPTEE

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2178 bytes --]

On Tue, Mar 17, 2026 at 03:32:16AM +0100, Marek Vasut wrote:
> On 3/17/26 2:24 AM, Tom Rini wrote:
> > As exposed by "make randconfig", we have an issue with the dependencies
> > for BOOTM_OPTEE. This symbol needs to select BOOTM_LINUX and in turn
> > that is only valid for CMD_BOOTM or CMD_BOOTZ. Add this dependency.
> > 
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > I am looking for feedback on this, so I've added the board maintainers
> > for the platforms which enable this option. It looks like this is only
> > valid on 32bit ARM platforms, to start with and not 64bit, is that
> > correct? That's why I excluded CMD_BOOTI from the list. I suspect that
> > this should really depend on CMD_BOOT{M,Z} and BOOTM_LINUX, and not
> > select it. If someone can confirm, I can do that instead, or someone can
> > just do the replacement patch for this. Thanks!
> > 
> > Cc: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: Marek Vasut <marek.vasut@mailbox.org>
> > Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> > Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> > Cc: u-boot@dh-electronics.com
> > ---
> >   lib/optee/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/lib/optee/Kconfig b/lib/optee/Kconfig
> > index 34b9d8afe675..9251faf73cd7 100644
> > --- a/lib/optee/Kconfig
> > +++ b/lib/optee/Kconfig
> > @@ -40,6 +40,7 @@ config OPTEE_TZDRAM_SIZE
> >   config BOOTM_OPTEE
> >   	bool "Support OPTEE bootm command"
> > +	depends on CMD_BOOTM || CMD_BOOTZ
> ARM32 SPL arch/arm/lib/spl.c has this piece of code, which does not depend
> on "bootm" command. This is used by falcon boot to jump into optee-os , with
> the optee-os return address being Linux kernel entry point. So I don't think
> depending on CMD_BOOT{M,Z,I} is enough ?
> 
> 77 #if defined(CONFIG_BOOTM_OPTEE) && defined(CONFIG_ARM) &&
> !defined(CONFIG_ARM64)
> 78         if (spl_image->optee_addr)
> 79                 boot_jump_linux_via_optee((void
> *)(spl_image->entry_point),

Ah right, I forgot about xPL_LIB_BOOTM. But, is this 32bit only?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]