From: Tom Rini <trini@konsulko.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Michael Walle <mwalle@kernel.org>,
Ashish Kumar <Ashish.kumar@nxp.com>,
Priyanka Jain <priyanka.jain@nxp.com>,
Kuldeep Singh <kuldeep.singh@nxp.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH 2/3] configs: ls1021atsn: enable serial driver
Date: Thu, 19 Mar 2026 08:25:05 -0600 [thread overview]
Message-ID: <20260319142505.GS502704@bill-the-cat> (raw)
In-Reply-To: <20260319141919.7i4lvuivexnek2ni@skbuf>
[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]
On Thu, Mar 19, 2026 at 04:19:19PM +0200, Vladimir Oltean wrote:
> On Wed, Mar 18, 2026 at 03:29:16PM +0100, Michael Walle wrote:
> > Switching to DM_SERIAL disabled any serial driver. Re-enable it again.
> >
> > Fixes: 191b10ac70d7 ("PowerPC / Layerscape: Finish migration to DM_SERIAL")
> > Signed-off-by: Michael Walle <mwalle@kernel.org>
> > ---
> > configs/ls1021atsn_qspi_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/configs/ls1021atsn_qspi_defconfig b/configs/ls1021atsn_qspi_defconfig
> > index e36d336d84b..37629d88c48 100644
> > --- a/configs/ls1021atsn_qspi_defconfig
> > +++ b/configs/ls1021atsn_qspi_defconfig
> > @@ -68,6 +68,7 @@ CONFIG_TSEC_ENET=y
> > CONFIG_NVME_PCI=y
> > CONFIG_PCIE_LAYERSCAPE_RC=y
> > CONFIG_DM_SERIAL=y
> > +CONFIG_SYS_NS16550=y
> > CONFIG_SPI=y
> > CONFIG_DM_SPI=y
> > CONFIG_FSL_DSPI=y
> > --
> > 2.47.3
> >
>
> Ok, in ls1021atsn_sdcard_defconfig it is selected by
> CONFIG_SPL_SYS_NS16550_SERIAL=y. In ls1021atsn_qspi_defconfig it isn't
> selected.
>
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
And the ls1021atsn_qspi_defconfig example isn't great, ugh. There's
certainly other platforms I didn't migrate correctly in that commit,
I'll go take a look now.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-03-19 14:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 14:29 [PATCH 0/3] arm: Give the LS1021ATSN board some love Michael Walle
2026-03-18 14:29 ` [PATCH 1/3] arm: dts: ls1021a-tsn: add default serial output Michael Walle
2026-03-18 14:29 ` [PATCH 2/3] configs: ls1021atsn: enable serial driver Michael Walle
2026-03-19 14:19 ` Vladimir Oltean
2026-03-19 14:25 ` Tom Rini [this message]
2026-03-19 14:54 ` Tom Rini
2026-03-18 14:29 ` [PATCH 3/3] armv7: ls102xa: fix SPI flash clock Michael Walle
2026-03-19 14:11 ` Vladimir Oltean
2026-03-19 14:24 ` Michael Walle
2026-03-30 13:13 ` Michael Walle
2026-03-23 6:29 ` [PATCH 0/3] arm: Give the LS1021ATSN board some love Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319142505.GS502704@bill-the-cat \
--to=trini@konsulko.com \
--cc=Ashish.kumar@nxp.com \
--cc=kuldeep.singh@nxp.com \
--cc=mwalle@kernel.org \
--cc=olteanv@gmail.com \
--cc=priyanka.jain@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox