public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>,
	Marek Vasut <marek.vasut+usb@mailbox.org>
Subject: [PATCH v2] usb: gadget: Move USB_GADGET_DUALSPEED to be slightly more visible
Date: Mon, 23 Mar 2026 08:32:53 -0600	[thread overview]
Message-ID: <20260323143253.2272167-1-trini@konsulko.com> (raw)
In-Reply-To: <20260317012433.4162524-1-trini@konsulko.com>

As exposed by "make randconfig", we have an issue around
USB_GADGET_DUALSPEED. It is possible to select this symbol (via
SPL_USB_CDNS3_GADGET for example) and so have an unmet dependency due to
how this symbol is placed today. Move this to it's own section of the
file guarded by USB_GADGET || SPL_USB_GADGET.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
Changes in v2:
- Implement this move as suggested by Marek instead

Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
Cc: Marek Vasut <marek.vasut+usb@mailbox.org>
---
 drivers/usb/gadget/Kconfig | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index baa2eb61ea33..2f79840df18c 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -179,10 +179,6 @@ config SDP_LOADADDR
 	hex "Default load address at SDP_WRITE and SDP_JUMP"
 	default 0x0
 
-# Selected by UDC drivers that support high-speed operation.
-config USB_GADGET_DUALSPEED
-	bool
-
 config USB_GADGET_DOWNLOAD
 	bool "Enable USB download gadget"
 	help
@@ -372,3 +368,11 @@ config SPL_SDP_USB_DEV
 	  so it can be used in compiled environment.
 
 endif # SPL_USB_GADGET
+
+if USB_GADGET || SPL_USB_GADGET
+
+# Selected by UDC drivers that support high-speed operation.
+config USB_GADGET_DUALSPEED
+	bool
+
+endif
-- 
2.43.0


  parent reply	other threads:[~2026-03-23 14:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17  1:24 [PATCH] usb: gadget: Move USB_GADGET_DUALSPEED to be slightly more visible Tom Rini
2026-03-17  2:34 ` Marek Vasut
2026-03-17 13:41   ` Tom Rini
2026-03-17 19:42     ` Marek Vasut
2026-03-18  1:26       ` Tom Rini
2026-03-19  0:50         ` Marek Vasut
2026-03-19 13:39           ` Tom Rini
2026-03-19 17:57             ` Marek Vasut
2026-03-20 13:53               ` Tom Rini
2026-03-21  1:53                 ` Marek Vasut
2026-03-21 17:34                   ` Tom Rini
2026-03-21 18:50                     ` Marek Vasut
2026-03-23 14:32 ` Tom Rini [this message]
2026-03-23 15:05   ` [PATCH v2] " Marek Vasut
2026-03-26  8:57   ` Mattijs Korpershoek
2026-04-08  9:26   ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260323143253.2272167-1-trini@konsulko.com \
    --to=trini@konsulko.com \
    --cc=marek.vasut+usb@mailbox.org \
    --cc=mkorpershoek@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox