Re: [PATCH] global: Correct duplicate U_BOOT_DRIVER entry names

Heiko Schocher
2026-03-25T05:15:54Z

Hello Tom,

On 23.03.26 23:55, Tom Rini wrote:
> The U_BOOT_DRIVER macro creates a list of drivers used at link time, and
> all entries here must be unique. This in turn means that all entries in
> the code should also be unique in order to not lead to build failures
> later with unexpected build combinations. Typically, the problem we have
> here is when a driver is obviously based on another driver and didn't
> update this particular field and so while the name field reflects
> something unique the linker entry itself is not. In a few places this
> provides a more suitable string name as well, however.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Cc: Anatolij Gustschin <ag.dev.uboot@gmail.com>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Casey Connolly <casey.connolly@linaro.org>
> Cc: Heiko Schocher <hs@nabladev.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Jerome Forissier <jerome.forissier@arm.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Cc: Łukasz Majewski <lukma@nabladev.com>
> Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>
> Cc: Masahisa Kojima <kojima.masahisa@socionext.com>
> Cc: Matthias Brugger <mbrugger@suse.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Peter Robinson <pbrobinson@gmail.com>
> Cc: Philipp Tomsich <philipp.tomsich@vrull.eu>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Stefan Roese <stefan.roese@mailbox.org>
> Cc: Svyatoslav Ryhel <clamor95@gmail.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Tien Fong Chee <tien.fong.chee@altera.com>
> Cc: u-boot-amlogic@groups.io
> Cc: uboot-stm32@st-md-mailman.stormreply.com
> Cc: u-boot-qcom@groups.io
> Cc: linux@analog.com
> ---
> arch/x86/cpu/broadwell/sdram.c | 2 +-
> arch/x86/cpu/ivybridge/early_me.c | 2 +-
> board/liebherr/btt/btt.c | 2 +-
> board/liebherr/xea/xea.c | 2 +-
> drivers/block/efi_blk.c | 2 +-
> drivers/clk/at91/compat.c | 4 ++--
> drivers/clk/at91/sckc.c | 2 +-
> drivers/clk/meson/a1.c | 2 +-
> drivers/clk/meson/gxbb.c | 2 +-
> drivers/clk/nuvoton/clk_npcm7xx.c | 2 +-
> drivers/clk/nuvoton/clk_npcm8xx.c | 2 +-
> drivers/clk/stm32/clk-stm32mp13.c | 2 +-
> drivers/dma/ti/k3-udma.c | 2 +-
> drivers/i2c/tegra186_bpmp_i2c.c | 2 +-
> drivers/mmc/bcm2835_sdhci.c | 2 +-
> drivers/mmc/fsl_esdhc_imx.c | 2 +-
> drivers/mmc/rockchip_sdhci.c | 2 +-
> drivers/net/calxedaxgmac.c | 2 +-
> drivers/net/dwc_eth_xgmac.c | 2 +-
> drivers/net/qe/dm_qe_uec_phy.c | 2 +-
> drivers/net/sni_netsec.c | 2 +-
> drivers/pinctrl/meson/pinctrl-meson-g12a.c | 2 +-
> drivers/pinctrl/tegra/pinctrl-tegra20.c | 4 ++--
> drivers/reset/stm32/stm32-reset-mp1.c | 2 +-
> drivers/spi/kirkwood_spi.c | 4 ++--
> drivers/spi/mvebu_a3700_spi.c | 4 ++--
> drivers/sysreset/sysreset_socfpga_soc64.c | 2 +-
> drivers/usb/dwc3/dwc3-meson-g12a.c | 2 +-
> drivers/usb/dwc3/dwc3-meson-gxl.c | 2 +-
> drivers/usb/host/ehci-exynos.c | 2 +-
> drivers/usb/host/ehci-msm.c | 2 +-
> drivers/usb/host/ehci-tegra.c | 2 +-
> drivers/usb/host/ehci-vf.c | 2 +-
> drivers/usb/host/ohci-da8xx.c | 2 +-
> drivers/usb/musb-new/pic32.c | 2 +-
> drivers/usb/musb-new/sc5xx.c | 2 +-
> drivers/usb/musb-new/sunxi.c | 2 +-
> drivers/video/rockchip/rk3288_mipi.c | 4 ++--
> drivers/video/rockchip/rk3399_mipi.c | 4 ++--
> drivers/watchdog/arm_smc_wdt.c | 2 +-
> 40 files changed, 46 insertions(+), 46 deletions(-)

Reviewed-by: Heiko Schocher <hs@nabladev.com>

bye,
Heiko
--
Nabla Software Engineering
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@nabladev.com
Geschäftsführer : Stefano Babic