From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: u-boot@lists.denx.de,
"Anatolij Gustschin" <ag.dev.uboot@gmail.com>,
"Bin Meng" <bmeng.cn@gmail.com>,
"Casey Connolly" <casey.connolly@linaro.org>,
"Heiko Schocher" <hs@nabladev.com>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Jerome Forissier" <jerome.forissier@arm.com>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Łukasz Majewski" <lukma@nabladev.com>,
"Marek Vasut" <marek.vasut+renesas@mailbox.org>,
"Masahisa Kojima" <kojima.masahisa@socionext.com>,
"Matthias Brugger" <mbrugger@suse.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
"Peng Fan" <peng.fan@nxp.com>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Philipp Tomsich" <philipp.tomsich@vrull.eu>,
"Simon Glass" <sjg@chromium.org>,
"Simon Goldschmidt" <simon.k.r.goldschmidt@gmail.com>,
"Stefan Roese" <stefan.roese@mailbox.org>,
"Svyatoslav Ryhel" <clamor95@gmail.com>,
"Thierry Reding" <treding@nvidia.com>,
"Tien Fong Chee" <tien.fong.chee@altera.com>,
u-boot-amlogic@groups.io,
uboot-stm32@st-md-mailman.stormreply.com, u-boot-qcom@groups.io,
linux@analog.com
Subject: Re: [PATCH] global: Correct duplicate U_BOOT_DRIVER entry names
Date: Tue, 24 Mar 2026 08:59:10 -0600 [thread overview]
Message-ID: <20260324145910.GP502704@bill-the-cat> (raw)
In-Reply-To: <ef7c8db3-0df8-4d32-983f-4b2dd81b298e@mailbox.org>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
On Tue, Mar 24, 2026 at 12:28:13AM +0100, Marek Vasut wrote:
>
> [...]
>
> > diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
> > index 41d15996e5b2..49e9c3fa0e99 100644
> > --- a/drivers/usb/dwc3/dwc3-meson-g12a.c
> > +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
> > @@ -533,7 +533,7 @@ static const struct udevice_id dwc3_meson_g12a_ids[] = {
> > { }
> > };
> > -U_BOOT_DRIVER(dwc3_generic_wrapper) = {
> > +U_BOOT_DRIVER(dwc3_meson_g12a) = {
>
> Could you please add usb_ as a prefix in front those usb drivers ?
As we talked about on IRC a bit, globally we're not consistent with
prefix or suffix or nothing. Your suggestion of a new macro that takes
the uclass name and rest of the driver name and constructs U_BOOT_DRIVER
from that sounds great and would be a good general improvement. If you
can file an issue about it please I'll try and find some time to look in
to doing that.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-03-24 14:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 22:55 [PATCH] global: Correct duplicate U_BOOT_DRIVER entry names Tom Rini
2026-03-23 23:28 ` Marek Vasut
2026-03-24 14:59 ` Tom Rini [this message]
2026-03-24 17:41 ` Simon Glass
2026-03-25 5:15 ` Heiko Schocher
2026-03-25 9:49 ` Svyatoslav Ryhel
2026-03-25 11:27 ` Peter Robinson
2026-04-07 19:50 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324145910.GP502704@bill-the-cat \
--to=trini@konsulko.com \
--cc=ag.dev.uboot@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=casey.connolly@linaro.org \
--cc=clamor95@gmail.com \
--cc=hs@nabladev.com \
--cc=jerome.forissier@arm.com \
--cc=jh80.chung@samsung.com \
--cc=kever.yang@rock-chips.com \
--cc=kojima.masahisa@socionext.com \
--cc=linux@analog.com \
--cc=lukma@nabladev.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=marek.vasut@mailbox.org \
--cc=mbrugger@suse.com \
--cc=neil.armstrong@linaro.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=pbrobinson@gmail.com \
--cc=peng.fan@nxp.com \
--cc=philipp.tomsich@vrull.eu \
--cc=simon.k.r.goldschmidt@gmail.com \
--cc=sjg@chromium.org \
--cc=stefan.roese@mailbox.org \
--cc=tien.fong.chee@altera.com \
--cc=treding@nvidia.com \
--cc=u-boot-amlogic@groups.io \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox