public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Vitor Soares <ivitro@gmail.com>, Tom Rini <trini@konsulko.com>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
	Vitor Soares <vitor.soares@toradex.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH v1] configs: aquila-am69: Set ENV_MMC_EMMC_HW_PARTITION and ENV_RELOC_GD_ENV_ADDR
Date: Wed, 1 Apr 2026 16:32:21 +0200	[thread overview]
Message-ID: <20260401143221.GA52316@francesco-nb> (raw)
In-Reply-To: <20260401141844.539308-2-ivitro@gmail.com>

Hello Tom,

On Wed, Apr 01, 2026 at 03:18:42PM +0100, Vitor Soares wrote:
> From: Vitor Soares <vitor.soares@toradex.com>
> 
> Set CONFIG_ENV_MMC_EMMC_HW_PARTITION=1 to store the environment in the
> eMMC first hardware boot partition instead of defaulting to 0 (user
> data area), where the rootfs and data partitions normally reside,
> risking corruption. This keeps the full boot stack self-contained in
> the eMMC hardware boot partition.
> 
> Enable CONFIG_ENV_RELOC_GD_ENV_ADDR so that gd->env_addr is adjusted by
> the relocation offset during U-Boot relocation. Without it, gd->env_addr
> keeps pointing to the pre-relocation address of the default
> environment, leading to incorrect environment access before env_load()
> completes.
> 
> Fixes: 3f0528882c0d ("board: toradex: add aquila am69 support")
> Signed-off-by: Vitor Soares <vitor.soares@toradex.com>

Acked-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Tom, this is for master, I know we are very close to the release date.

Thanks,
Francesco


      reply	other threads:[~2026-04-01 14:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01 14:18 [PATCH v1] configs: aquila-am69: Set ENV_MMC_EMMC_HW_PARTITION and ENV_RELOC_GD_ENV_ADDR Vitor Soares
2026-04-01 14:32 ` Francesco Dolcini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401143221.GA52316@francesco-nb \
    --to=francesco@dolcini.it \
    --cc=francesco.dolcini@toradex.com \
    --cc=ivitro@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vitor.soares@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox