From: <rs@ti.com>
To: <robertcnelson@gmail.com>, <ayush@beagleboard.org>,
<Erik.Welsh@octavosystems.com>, <anshuld@ti.com>, <bb@ti.com>,
<trini@konsulko.com>, <afd@ti.com>, <xypron.glpk@gmx.de>,
<ilias.apalodimas@linaro.org>
Cc: <u-boot@lists.denx.de>
Subject: [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY
Date: Wed, 1 Apr 2026 19:14:09 -0500 [thread overview]
Message-ID: <20260402001410.3736815-6-rs@ti.com> (raw)
In-Reply-To: <20260402001410.3736815-1-rs@ti.com>
From: Randolph Sapp <rs@ti.com>
Backfill any fragmented EFI_CONVENTIONAL_MEMORY when LMB allocations
start to fail. This may be a low memory environment, or maybe LMB is
running up against a tricky reserved region.
Signed-off-by: Randolph Sapp <rs@ti.com>
---
lib/efi_loader/efi_memory.c | 35 +++++++++++++++++++++++++++++++++--
1 file changed, 33 insertions(+), 2 deletions(-)
diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c
index 882366a9f8a..f07cc39b157 100644
--- a/lib/efi_loader/efi_memory.c
+++ b/lib/efi_loader/efi_memory.c
@@ -441,6 +441,27 @@ static efi_status_t efi_check_allocated(u64 addr, bool must_be_allocated)
return EFI_NOT_FOUND;
}
+/**
+ * efi_get_conventional_start - find the highest conventional region start
+ * address with at least the specified number of
+ * pages
+ *
+ * @pages: number of pages required to be in that carveout
+ * Return: starting address of the give carveout
+ */
+static u64 efi_get_conventional_start(u64 pages)
+{
+ struct efi_mem_list *item;
+
+ list_for_each_entry(item, &efi_mem, link) {
+ if (item->desc.type != EFI_CONVENTIONAL_MEMORY)
+ continue;
+ if (item->desc.num_pages >= pages)
+ return item->desc.physical_start;
+ }
+ return 0;
+}
+
/**
* efi_allocate_pages - allocate memory pages
*
@@ -507,10 +528,20 @@ efi_status_t efi_allocate_pages(enum efi_allocate_type type,
/* Reserve that map in our memory maps */
ret = efi_update_memory_map(efi_addr, pages, memory_type, true, false);
if (ret != EFI_SUCCESS) {
- /* Map would overlap, bail out */
+ /* Map would overlap, try something else */
lmb_free(addr, (u64)pages << EFI_PAGE_SHIFT, flags);
unmap_sysmem((void *)(uintptr_t)efi_addr);
- return EFI_OUT_OF_RESOURCES;
+
+ /* See if there is any EFI_CONVENTIONAL_MEMORY allocations */
+ if (type != EFI_ALLOCATE_ADDRESS) {
+ *memory = efi_get_conventional_start(pages);
+ if (*memory != 0)
+ return efi_allocate_pages(EFI_ALLOCATE_ADDRESS,
+ memory_type, pages,
+ memory);
+ }
+
+ return EFI_OUT_OF_RESOURCES;
}
*memory = efi_addr;
--
2.53.0
next prev parent reply other threads:[~2026-04-02 0:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 0:14 [PATCH 0/6] various memory related fixups rs
2026-04-02 0:14 ` [PATCH 1/6] lmb: add LMB_FDT for fdt reserved regions rs
2026-04-02 0:36 ` Randolph Sapp
2026-04-02 0:14 ` [PATCH 2/6] efi_dt_fixup: use fdtdec_get_bool rs
2026-04-02 8:38 ` Ilias Apalodimas
2026-04-02 0:14 ` [PATCH 3/6] efi_selftest_memory: check for duplicates first rs
2026-04-02 0:14 ` [PATCH 4/6] efi_memory: nitpick removal loop rs
2026-04-02 9:04 ` Ilias Apalodimas
2026-04-02 17:39 ` Randolph Sapp
2026-04-02 19:02 ` Ilias Apalodimas
2026-04-02 19:21 ` Randolph Sapp
2026-04-02 0:14 ` rs [this message]
2026-04-02 8:53 ` [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY Ilias Apalodimas
2026-04-02 17:32 ` Randolph Sapp
2026-04-02 19:58 ` Randolph Sapp
2026-04-03 5:28 ` Ilias Apalodimas
2026-04-04 0:08 ` Randolph Sapp
2026-04-02 0:14 ` [PATCH 6/6] memory: reserve from start_addr_sp to relocaddr rs
2026-04-02 9:21 ` Ilias Apalodimas
2026-04-02 19:15 ` Randolph Sapp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402001410.3736815-6-rs@ti.com \
--to=rs@ti.com \
--cc=Erik.Welsh@octavosystems.com \
--cc=afd@ti.com \
--cc=anshuld@ti.com \
--cc=ayush@beagleboard.org \
--cc=bb@ti.com \
--cc=ilias.apalodimas@linaro.org \
--cc=robertcnelson@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox