Re: [PATCH v1] misc: fs_loader: Add QSPI RAW partition loading support

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1829 bytes --]

On Thu, Mar 19, 2026 at 06:02:56PM +0800, Boon Khai Ng wrote:

> Enhanced the generic firmware loader to support QSPI RAW partition
> loading. This would enable FPGA configuration bitstream loading
> from QSPI RAW partition to program FPGA.
> 
> Signed-off-by: Tien Fong Chee <tien.fong.chee@altera.com>
> Signed-off-by: Boon Khai Ng <boon.khai.ng@altera.com>
> ---
>  drivers/misc/fs_loader.c | 111 +++++++++++++++++++++++++++++++--------
>  include/fs_loader.h      |  35 ++++++++++++
>  2 files changed, 123 insertions(+), 23 deletions(-)

Building this on sandbox gives:
drivers/misc/fs_loader.c: In function 'fs_loader_probe':
drivers/misc/fs_loader.c:310:68: error: passing argument 3 of 'spi_flash_probe_bus_cs' makes pointer from integer without a cast [-Werror=int-conversion]
  310 |                                                      plat->sfconfig.speed,
      |                                                      ~~~~~~~~~~~~~~^~~~~~
      |                                                                    |
      |                                                                    u32 {aka unsigned int}
In file included from drivers/misc/fs_loader.c:22:
include/spi_flash.h:105:45: note: expected 'struct udevice **' but argument is of type 'u32' {aka 'unsigned int'}
  105 |                            struct udevice **devp);
      |                            ~~~~~~~~~~~~~~~~~^~~~
drivers/misc/fs_loader.c:308:31: error: too many arguments to function 'spi_flash_probe_bus_cs'
  308 |                         ret = spi_flash_probe_bus_cs(plat->sfconfig.bus,
      |                               ^~~~~~~~~~~~~~~~~~~~~~
include/spi_flash.h:104:5: note: declared here
  104 | int spi_flash_probe_bus_cs(unsigned int busnum, unsigned int cs,

Please fix, thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]