public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: yan wang <yan.wang@softathome.com>
To: trini+nodisclaimer@konsulko.com, sjg+nodisclaimer@chromium.org,
	alpernebiyasak+nodisclaimer@gmail.com
Cc: philippe.reynes+nodisclaimer@softathome.com,
	paul.henrys_ext+nodisclaimer@softathome.com,
	u-boot+nodisclaimer@lists.denx.de,
	Paul HENRYS <paul.henrys_ext@softathome.com>
Subject: [PATCH v2 2/3] binman: Generate preload header and sign data only once
Date: Thu,  2 Apr 2026 21:24:30 +0200	[thread overview]
Message-ID: <20260402192431.2421155-2-yan.wang@softathome.com> (raw)
In-Reply-To: <20260402192431.2421155-1-yan.wang@softathome.com>

From: Paul HENRYS <paul.henrys_ext@softathome.com>

To optimize preload generation, generate the header and signatures only
after all data has been collected. This avoids signing the data multiple
times.

Since header_size is known upfront (from __init__), set the preload
header size in `ObtainContents()` to avoid an extra packing pass when
ProcessContentsUpdate() detects the size changed from 0 to header_size.

This reduces unnecessary repacking and signing operations.

Signed-off-by: Paul HENRYS <paul.henrys_ext@softathome.com>
---
Changes for v2:
- Set contents_size knowing header_size in ObtainContents()

 tools/binman/etype/pre_load.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/binman/etype/pre_load.py b/tools/binman/etype/pre_load.py
index 00f1a896767..34a7bc1b985 100644
--- a/tools/binman/etype/pre_load.py
+++ b/tools/binman/etype/pre_load.py
@@ -152,14 +152,14 @@ class Entry_pre_load(Entry_collection):
         return data + pad
 
     def ObtainContents(self):
-        """Obtain a placeholder for the header contents"""
-        # wait that the image is available
-        self.image = self.GetContents(False)
-        if self.image is None:
-            return False
-        self.SetContents(self._CreateHeader())
+        """Only set the known size of the preload header. The data will be
+        generated later on in ProcessContents() when the data from every entries
+        can be retrieved.
+        """
+        self.contents_size = self.header_size
         return True
 
     def ProcessContents(self):
+        self.image = self.GetContents(True)
         data = self._CreateHeader()
         return self.ProcessContentsUpdate(data)
-- 
2.43.0


  reply	other threads:[~2026-04-02 19:24 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 19:24 [PATCH v2 1/3] tools: binman: Test signing an encrypted FIT with a preload header yan wang
2026-04-02 19:24 ` yan wang [this message]
2026-04-03  1:02   ` [PATCH v2 2/3] binman: Generate preload header and sign data only once Simon Glass
2026-04-02 19:24 ` [PATCH v2 3/3] binman: collection: Set build_done on referenced entries yan wang
2026-04-03  1:02   ` Simon Glass
2026-04-02 19:35 ` [PATCH v2 1/3] tools: binman: Test signing an encrypted FIT with a preload header Tom Rini
2026-04-03  7:32 ` [PATCH v3 " Paul HENRYS
2026-04-03  7:32   ` [PATCH v3 2/3] binman: Generate preload header and sign data only once Paul HENRYS
2026-04-03  7:32   ` [PATCH v3 3/3] binman: collection: Set build_done on referenced entries Paul HENRYS
2026-04-03  7:41   ` [PATCH v3 1/3] tools: binman: Test signing an encrypted FIT with a preload header Paul HENRYS
2026-04-03 14:53     ` Tom Rini
2026-04-03  7:55   ` [PATCH v4 " Paul HENRYS
2026-04-03  7:55     ` [PATCH v4 2/3] binman: Generate preload header and sign data only once Paul HENRYS
2026-04-03 13:21       ` Simon Glass
2026-04-03  7:55     ` [PATCH v4 3/3] binman: collection: Set build_done on referenced entries Paul HENRYS
2026-04-03 13:22       ` Simon Glass
2026-04-08 15:01       ` [PATCH v5 0/3] binman: Fix preload signing with encrypted FIT Paul HENRYS
2026-04-08 15:01         ` [PATCH v5 1/3] binman: Generate preload header and sign data only once Paul HENRYS
2026-04-11 17:19           ` Simon Glass
2026-04-08 15:02         ` [PATCH v5 2/3] binman: collection: Set build_done on referenced entries Paul HENRYS
2026-04-11 17:18           ` Simon Glass
2026-04-14 13:15           ` [PATCH v6 0/3] binman: Fix preload signing with encrypted FIT Yan WANG
2026-04-14 13:15             ` [PATCH v6 1/3] binman: Generate preload header and sign data only once Yan WANG
2026-04-16 17:37               ` Simon Glass
2026-04-14 13:15             ` [PATCH v6 2/3] binman: collection: Set build_done on referenced entries Yan WANG
2026-04-16 17:36               ` Simon Glass
2026-04-17  8:30               ` [PATCH v7 0/3] binman: Fix preload signing with encrypted FIT Yan WANG
2026-04-17  8:30                 ` [PATCH v7 1/3] binman: Generate preload header and sign data only once Yan WANG
2026-04-18 18:14                   ` Simon Glass
2026-04-17  8:30                 ` [PATCH v7 2/3] binman: collection: Set build_done on referenced entries Yan WANG
2026-04-18 18:15                   ` Simon Glass
2026-04-17  8:30                 ` [PATCH v7 3/3] tools: binman: Test signing an encrypted FIT with a preload header Yan WANG
2026-04-18 18:15                   ` Simon Glass
2026-04-14 13:15             ` [PATCH v6 " Yan WANG
2026-04-16 17:37               ` Simon Glass
2026-04-08 15:02         ` [PATCH v5 " Paul HENRYS
2026-04-11 17:19           ` Simon Glass
2026-04-03 13:22     ` [PATCH v4 1/3] " Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260402192431.2421155-2-yan.wang@softathome.com \
    --to=yan.wang@softathome.com \
    --cc=alpernebiyasak+nodisclaimer@gmail.com \
    --cc=paul.henrys_ext+nodisclaimer@softathome.com \
    --cc=paul.henrys_ext@softathome.com \
    --cc=philippe.reynes+nodisclaimer@softathome.com \
    --cc=sjg+nodisclaimer@chromium.org \
    --cc=trini+nodisclaimer@konsulko.com \
    --cc=u-boot+nodisclaimer@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox