From: Daniel Palmer <daniel@thingy.jp>
To: visitorckw@gmail.com, angelo@kernel-space.org, bmeng.cn@gmail.com
Cc: u-boot@lists.denx.de, Daniel Palmer <daniel@thingy.jp>
Subject: [PATCH v2 3/5] virtio: mmio: Keep vendor id little endian
Date: Mon, 6 Apr 2026 23:24:09 +0900 [thread overview]
Message-ID: <20260406142411.2992618-4-daniel@thingy.jp> (raw)
In-Reply-To: <20260406142411.2992618-1-daniel@thingy.jp>
The vendor id is used as a little endian value but it gets
swapped to the CPU endian in readl(). Swap it back to le
to avoid the below weird output from `virtio info`.
Device 0: UMEQ VirtIO Block Device
Type: Hard Disk
Capacity: 1.0 MB = 0.0 GB (2056 x 512)
Signed-off-by: Daniel Palmer <daniel@thingy.jp>
---
drivers/virtio/virtio_mmio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index 1cd737aca249..ddf873fa96fb 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers/virtio/virtio_mmio.c
@@ -374,7 +374,7 @@ static int virtio_mmio_probe(struct udevice *udev)
*/
return 0;
}
- uc_priv->vendor = readl(priv->base + VIRTIO_MMIO_VENDOR_ID);
+ uc_priv->vendor = cpu_to_le32(readl(priv->base + VIRTIO_MMIO_VENDOR_ID));
if (priv->version == 1)
writel(PAGE_SIZE, priv->base + VIRTIO_MMIO_GUEST_PAGE_SIZE);
--
2.51.0
next prev parent reply other threads:[~2026-04-06 14:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 14:24 [PATCH v2 0/5] Add virtio-mmio support to m68k virt machine Daniel Palmer
2026-04-06 14:24 ` [PATCH v2 1/5] sysreset: qemu virt: Use __raw_writel() Daniel Palmer
2026-04-06 16:57 ` Kuan-Wei Chiu
2026-04-08 12:15 ` Angelo Dureghello
2026-04-06 14:24 ` [PATCH v2 2/5] m68k: Fix writew(), writel(), readw(), readl() endianness Daniel Palmer
2026-04-06 17:15 ` Kuan-Wei Chiu
2026-04-07 0:58 ` Daniel Palmer
2026-04-08 12:12 ` Angelo Dureghello
2026-04-08 12:49 ` Daniel Palmer
2026-04-08 13:26 ` Angelo Dureghello
2026-04-08 13:40 ` Daniel Palmer
2026-04-08 14:18 ` Angelo Dureghello
2026-04-06 14:24 ` Daniel Palmer [this message]
2026-04-06 16:54 ` [PATCH v2 3/5] virtio: mmio: Keep vendor id little endian Kuan-Wei Chiu
2026-04-07 1:00 ` Daniel Palmer
2026-04-07 8:20 ` Daniel Palmer
2026-04-06 14:24 ` [PATCH v2 4/5] virtio: mmio: Allow instantiation via platform data Daniel Palmer
2026-04-08 1:47 ` Kuan-Wei Chiu
2026-04-08 9:39 ` Daniel Palmer
2026-04-06 14:24 ` [PATCH v2 5/5] board: qemu: m68k: Create virtio mmio instances Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260406142411.2992618-4-daniel@thingy.jp \
--to=daniel@thingy.jp \
--cc=angelo@kernel-space.org \
--cc=bmeng.cn@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox