From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v2 6/8] test: Convert FIT test to use a class
Date: Mon, 6 Apr 2026 08:35:29 -0600 [thread overview]
Message-ID: <20260406143529.GO41863@bill-the-cat> (raw)
In-Reply-To: <20260405111206.945185-7-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Sun, Apr 05, 2026 at 05:11:51AM -0600, Simon Glass wrote:
> Move this test over to use a class instead of a function, so we can
> easily split it into some related tests.
>
> Move the TODO so it is part of the comment for the class.
>
> Tidy up some function comments while we are here.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2:
> - Remove doctest examples from find_matching() to fix Sphinx warnings
You shouldn't need to drop anything. It does likely require a different
quoting. If you look at the changes between a865d1d25410 and
02e5d344a0d7 you should find an example that helps. My first guess is
that the backtrace needs a ".. code-block::" around it with possibly
some indentation changes.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-04-06 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-05 11:11 [PATCH v2 0/8] test: Refactor FIT test for clarity and extensibility Simon Glass
2026-04-05 11:11 ` [PATCH v2 1/8] test: fit: Drop the fit_signature buildconfigspec Simon Glass
2026-04-05 11:11 ` [PATCH v2 2/8] test: fit: Avoid restarting U-Boot Simon Glass
2026-04-05 11:11 ` [PATCH v2 3/8] test: Rename test_fit() to test_fit_base() Simon Glass
2026-04-05 11:11 ` [PATCH v2 4/8] test: Add a check for a missing kernel Simon Glass
2026-04-05 11:11 ` [PATCH v2 5/8] test: Update fit test to fix a few Python warnings Simon Glass
2026-04-05 11:11 ` [PATCH v2 6/8] test: Convert FIT test to use a class Simon Glass
2026-04-06 14:35 ` Tom Rini [this message]
2026-04-05 11:11 ` [PATCH v2 7/8] test: Add fsetup fixture and prepare helper for FIT test Simon Glass
2026-04-05 11:11 ` [PATCH v2 8/8] test: Add documentation for the " Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260406143529.GO41863@bill-the-cat \
--to=trini@konsulko.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox