From: Alexander Dahl <ada@thorsis.com>
To: Michal Simek <michal.simek@amd.com>
Cc: u-boot@lists.denx.de, git@amd.com,
Pieter Van Trappen <pieter.van.trappen@cern.ch>,
Tom Rini <trini@konsulko.com>,
Ibai Erkiaga <ibai.erkiaga-elorza@amd.com>
Subject: Re: [PATCH] cmd: fpga: Fix wrong preprocessor guard for loadb help text
Date: Tue, 7 Apr 2026 12:38:02 +0200 [thread overview]
Message-ID: <20260407-contusion-daylight-5eeffaaab47e@thorsis.com> (raw)
In-Reply-To: <366dfe78e2028f53a6274da75547fb68844764cc.1775549229.git.michal.simek@amd.com>
Hello Michal,
Am Tue, Apr 07, 2026 at 10:07:11AM +0200 schrieb Michal Simek:
> The help text for the "fpga loadb" command was incorrectly guarded by
> CONFIG_CMD_FPGA_LOADP instead of CONFIG_CMD_FPGA_LOADB. This meant the
> loadb help text would only be shown when LOADP was enabled, rather than
> when LOADB was enabled.
>
> Fix the preprocessor condition to use the correct config option.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> cmd/fpga.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/fpga.c b/cmd/fpga.c
> index d51c380d7b3e..d347a7002906 100644
> --- a/cmd/fpga.c
> +++ b/cmd/fpga.c
> @@ -417,7 +417,7 @@ U_BOOT_CMD(fpga, 6, 1, do_fpga_wrapper,
> "info [dev] List known device information\n"
> "fpga dump <dev> <address> <size> Load device to memory buffer\n"
> "fpga load <dev> <address> <size> Load device from memory buffer\n"
> -#if defined(CONFIG_CMD_FPGA_LOADP)
> +#if defined(CONFIG_CMD_FPGA_LOADB)
> "fpga loadb <dev> <address> <size> Load device from bitstream buffer\n"
> #endif
> #if defined(CONFIG_CMD_FPGA_LOADP)
Fixes: f8f378877b8f ("fpga: add new symbol for fpga_loadb")
Reviewed-by: Alexander Dahl <ada@thorsis.com>
Added original patch author to Cc.
Greets
Alex
prev parent reply other threads:[~2026-04-07 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 8:07 [PATCH] cmd: fpga: Fix wrong preprocessor guard for loadb help text Michal Simek
2026-04-07 10:38 ` Alexander Dahl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407-contusion-daylight-5eeffaaab47e@thorsis.com \
--to=ada@thorsis.com \
--cc=git@amd.com \
--cc=ibai.erkiaga-elorza@amd.com \
--cc=michal.simek@amd.com \
--cc=pieter.van.trappen@cern.ch \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox