From: Philippe Simons <simons.philippe@gmail.com>
To: Jagan Teki <jagan@amarulasolutions.com>,
Andre Przywara <andre.przywara@arm.com>,
Tom Rini <trini@konsulko.com>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>,
"Kory Maincent (TI.com)" <kory.maincent@bootlin.com>,
Paul Kocialkowski <contact@paulk.fr>,
Cody Eksal <masterr3c0rd@epochal.quest>,
Philippe Simons <simons.philippe@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Mikhail Kalashnikov <iuncuim@gmail.com>,
u-boot@lists.denx.de
Subject: [PATCH v2] sunxi: H616: dram: fix LPDDR3 TRP6 parsing
Date: Tue, 7 Apr 2026 18:47:17 +0200 [thread overview]
Message-ID: <20260407164717.7356-1-simons.philippe@gmail.com> (raw)
From: Jernej Skrabec <jernej.skrabec@gmail.com>
Allwinner's BSP DRAM code uses parameter TPR6, presumably containing
some "Vref" parameter, to encode the values for *all* four supported DRAM
types. The code selects one byte based on the DRAM type used at runtime.
To allow copying DRAM parameters from vendor firmware, we used this value
and its encoding, but wrongly: the proper order of bytes is DDR3, DDR4,
LPDDR3, LPDDR4, from LSB to MSB, cf. the A523 and A133 DRAM code.
Correct the masking for LPDDR3 to fix DRAM operation on some boards
using this DRAM type.
With LPDDR3 TRP6 parsing fixed, adapt default DRAM_SUNXI_TPR6 value.
Also change LPDDR4 default value to 0x38 used by A523 boards.
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
[adjusted commit message, update default value]
Signed-off-by: Philippe Simons <simons.philippe@gmail.com>
---
arch/arm/mach-sunxi/Kconfig | 2 +-
arch/arm/mach-sunxi/dram_sun50i_h616.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
index e979ee4a2cc..a1ddc6a1fc8 100644
--- a/arch/arm/mach-sunxi/Kconfig
+++ b/arch/arm/mach-sunxi/Kconfig
@@ -144,7 +144,7 @@ config DRAM_SUNXI_TPR3
config DRAM_SUNXI_TPR6
hex "DRAM TPR6 parameter"
- default 0x3300c080
+ default 0x38c00080
help
TPR6 value from vendor DRAM settings.
diff --git a/arch/arm/mach-sunxi/dram_sun50i_h616.c b/arch/arm/mach-sunxi/dram_sun50i_h616.c
index 3345c9b8e82..42a0550e015 100644
--- a/arch/arm/mach-sunxi/dram_sun50i_h616.c
+++ b/arch/arm/mach-sunxi/dram_sun50i_h616.c
@@ -975,7 +975,7 @@ static bool mctl_phy_init(const struct dram_para *para,
val = para->tpr6 & 0xff;
break;
case SUNXI_DRAM_TYPE_LPDDR3:
- val = para->tpr6 >> 8 & 0xff;
+ val = para->tpr6 >> 16 & 0xff;
break;
case SUNXI_DRAM_TYPE_LPDDR4:
val = para->tpr6 >> 24 & 0xff;
--
2.53.0
next reply other threads:[~2026-04-07 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 16:47 Philippe Simons [this message]
2026-04-09 5:48 ` [PATCH v2] sunxi: H616: dram: fix LPDDR3 TRP6 parsing Mikhail Kalashnikov
2026-04-09 15:10 ` Paul Kocialkowski
2026-04-09 21:34 ` Andre Przywara
2026-04-10 15:54 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407164717.7356-1-simons.philippe@gmail.com \
--to=simons.philippe@gmail.com \
--cc=andre.przywara@arm.com \
--cc=contact@paulk.fr \
--cc=iuncuim@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=masterr3c0rd@epochal.quest \
--cc=samuel@sholland.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox