public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Bosch <stefan_b@posteo.net>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Stefan Bosch <stefan_b@posteo.net>
Subject: [PATCH v1] arm: dts: s5p4418: fix "mmc write failed" e.g. at cmd saveenv
Date: Tue, 07 Apr 2026 17:23:19 +0000	[thread overview]
Message-ID: <20260407172155.3419-1-stefan_b@posteo.net> (raw)

s5p4418-pinctrl.dtsi: Fix mmc bus definitions to fix "mmc write failed"
e.g. when cmd saveenv is executed. Initialize all four GPIO of the
mmc-buses instead of only the first one.

Signed-off-by: Stefan Bosch <stefan_b@posteo.net>
---

 arch/arm/dts/s5p4418-pinctrl.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/dts/s5p4418-pinctrl.dtsi b/arch/arm/dts/s5p4418-pinctrl.dtsi
index 0768d80fc95..639b6d2ca6d 100644
--- a/arch/arm/dts/s5p4418-pinctrl.dtsi
+++ b/arch/arm/dts/s5p4418-pinctrl.dtsi
@@ -35,7 +35,7 @@ pinctrl@C0010000 {
 	};
 
 	mmc0_bus4: mmc0-bus-width4 {
-		pins = "gpiob-1, gpiob-3, gpiob-5, gpiob-7";
+		pins = "gpiob-1", "gpiob-3", "gpiob-5", "gpiob-7";
 		pin-function = <1>;
 		pin-pull = <2>;
 		pin-strength = <1>;
@@ -56,7 +56,7 @@ pinctrl@C0010000 {
 	};
 
 	mmc1_bus4: mmc1-bus-width4 {
-		pins = "gpiod-24, gpiod-25, gpiod-26, gpiod-27";
+		pins = "gpiod-24", "gpiod-25", "gpiod-26", "gpiod-27";
 		pin-function = <1>;
 		pin-pull = <2>;
 		pin-strength = <1>;
@@ -77,7 +77,7 @@ pinctrl@C0010000 {
 	};
 
 	mmc2_bus4: mmc2-bus-width4 {
-		pins = "gpioc-20, gpioc-21, gpioc-22, gpioc-23";
+		pins = "gpioc-20", "gpioc-21", "gpioc-22", "gpioc-23";
 		pin-function = <2>;
 		pin-pull = <2>;
 		pin-strength = <1>;
-- 
2.17.1


             reply	other threads:[~2026-04-07 17:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07 17:23 Stefan Bosch [this message]
2026-04-07 17:26 ` [PATCH v1] arm: dts: s5p4418: fix "mmc write failed" e.g. at cmd saveenv Tom Rini
2026-04-08 17:59   ` Stefan Bosch
2026-04-08 18:05     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260407172155.3419-1-stefan_b@posteo.net \
    --to=stefan_b@posteo.net \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox