From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de, James Hilliard <james.hilliard1@gmail.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH 02/13] boot: Move call to fit_image_select() and rename it
Date: Wed, 8 Apr 2026 10:25:50 -0600 [thread overview]
Message-ID: <20260408162550.GE41863@bill-the-cat> (raw)
In-Reply-To: <20260325165431.1027591-3-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
On Wed, Mar 25, 2026 at 10:54:11AM -0600, Simon Glass wrote:
> This function is named a bit vaguely, since it prints some info and then
> does verification of the image.
>
> Rename it to print_and_verify() and move the call to select_image().
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Renaming functions inside a bigger overall series makes review harder,
this should be independent, either before or after.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-04-08 16:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 16:54 [PATCH 00/13] boot: Make fit_image_load() easier to maintain Simon Glass
2026-03-25 16:54 ` [PATCH 01/13] boot: Split out the first part of fit_image_load() Simon Glass
2026-04-08 16:25 ` Tom Rini
2026-03-25 16:54 ` [PATCH 02/13] boot: Move call to fit_image_select() and rename it Simon Glass
2026-04-08 16:25 ` Tom Rini [this message]
2026-03-25 16:54 ` [PATCH 03/13] boot: Tidy up setting of the OS arch on host builds Simon Glass
2026-04-08 16:25 ` Tom Rini
2026-03-25 16:54 ` [PATCH 04/13] boot: Move type and OS checking into a new function Simon Glass
2026-04-08 16:26 ` Tom Rini
2026-03-25 16:54 ` [PATCH 05/13] boot: Move handling of the load_op into a separate function Simon Glass
2026-04-08 16:26 ` Tom Rini
2026-03-25 16:54 ` [PATCH 06/13] boot: Move obtaining data from a FIT image into a function Simon Glass
2026-03-25 16:54 ` [PATCH 07/13] boot: Check the image is allowed before setting os.arch Simon Glass
2026-03-25 16:54 ` [PATCH 08/13] boot: Move the architecture check into check_allowed() Simon Glass
2026-03-25 16:54 ` [PATCH 09/13] boot: Move image-decompression into a separate function Simon Glass
2026-03-25 16:54 ` [PATCH 10/13] boot: Move decomp_image() into handle_load_op() Simon Glass
2026-03-25 16:54 ` [PATCH 11/13] boot: Move setting the OS arch into check_allowed() Simon Glass
2026-03-25 16:54 ` [PATCH 12/13] boot: Drop unnecessary data variable Simon Glass
2026-03-25 16:54 ` [PATCH 13/13] boot: Tidy local variables in fit_image_load() Simon Glass
2026-04-08 16:26 ` [PATCH 00/13] boot: Make fit_image_load() easier to maintain Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408162550.GE41863@bill-the-cat \
--to=trini@konsulko.com \
--cc=james.hilliard1@gmail.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox