[PATCH v1] arm: dts: s5p4418: fix "mmc write failed" e.g. at cmd saveenv

[PATCH v1] arm: dts: s5p4418: fix "mmc write failed" e.g. at cmd saveenv

[Stefan Bosch]

s5p4418-pinctrl.dtsi: Fix mmc bus definitions to fix "mmc write failed"
e.g. when cmd saveenv is executed. Initialize all four GPIO of the
mmc-buses instead of only the first one.

Signed-off-by: Stefan Bosch <stefan_b@posteo.net>
---

 arch/arm/dts/s5p4418-pinctrl.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/dts/s5p4418-pinctrl.dtsi b/arch/arm/dts/s5p4418-pinctrl.dtsi
index 0768d80fc95..639b6d2ca6d 100644
--- a/arch/arm/dts/s5p4418-pinctrl.dtsi
+++ b/arch/arm/dts/s5p4418-pinctrl.dtsi
@@ -35,7 +35,7 @@ pinctrl@C0010000 {
 	};
 
 	mmc0_bus4: mmc0-bus-width4 {
-		pins = "gpiob-1, gpiob-3, gpiob-5, gpiob-7";
+		pins = "gpiob-1", "gpiob-3", "gpiob-5", "gpiob-7";
 		pin-function = <1>;
 		pin-pull = <2>;
 		pin-strength = <1>;
@@ -56,7 +56,7 @@ pinctrl@C0010000 {
 	};
 
 	mmc1_bus4: mmc1-bus-width4 {
-		pins = "gpiod-24, gpiod-25, gpiod-26, gpiod-27";
+		pins = "gpiod-24", "gpiod-25", "gpiod-26", "gpiod-27";
 		pin-function = <1>;
 		pin-pull = <2>;
 		pin-strength = <1>;
@@ -77,7 +77,7 @@ pinctrl@C0010000 {
 	};
 
 	mmc2_bus4: mmc2-bus-width4 {
-		pins = "gpioc-20, gpioc-21, gpioc-22, gpioc-23";
+		pins = "gpioc-20", "gpioc-21", "gpioc-22", "gpioc-23";
 		pin-function = <2>;
 		pin-pull = <2>;
 		pin-strength = <1>;
-- 
2.17.1

Re: [PATCH v1] arm: dts: s5p4418: fix "mmc write failed" e.g. at cmd saveenv

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

On Tue, Apr 07, 2026 at 05:23:19PM +0000, Stefan Bosch wrote:

> s5p4418-pinctrl.dtsi: Fix mmc bus definitions to fix "mmc write failed"
> e.g. when cmd saveenv is executed. Initialize all four GPIO of the
> mmc-buses instead of only the first one.
> 
> Signed-off-by: Stefan Bosch <stefan_b@posteo.net>
> ---
> 
>  arch/arm/dts/s5p4418-pinctrl.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Hey, I'm curious what it would take to move this to using OF_UPSTREAM,
where I assume this problem has already been fixed? Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v1] arm: dts: s5p4418: fix "mmc write failed" e.g. at cmd saveenv

[Stefan Bosch]

Hi Tom,

On 07.04.26 19:26, Tom Rini wrote:
> On Tue, Apr 07, 2026 at 05:23:19PM +0000, Stefan Bosch wrote:
> 
>> s5p4418-pinctrl.dtsi: Fix mmc bus definitions to fix "mmc write failed"
>> e.g. when cmd saveenv is executed. Initialize all four GPIO of the
>> mmc-buses instead of only the first one.
>>
>> Signed-off-by: Stefan Bosch <stefan_b@posteo.net>
>> ---
>>
>>   arch/arm/dts/s5p4418-pinctrl.dtsi | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Hey, I'm curious what it would take to move this to using OF_UPSTREAM,
> where I assume this problem has already been fixed? Thanks!
> 
If I'm not mistaken, using OF_UPSTREAM is not possible because I think 
the s5p4418 SoC is not in the Linux kernel source tree and therefore 
also not in the devicetree-rebasing repo.

Regards
Stefan

Re: [PATCH v1] arm: dts: s5p4418: fix "mmc write failed" e.g. at cmd saveenv

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

On Wed, Apr 08, 2026 at 05:59:27PM +0000, Stefan Bosch wrote:
> Hi Tom,
> 
> On 07.04.26 19:26, Tom Rini wrote:
> > On Tue, Apr 07, 2026 at 05:23:19PM +0000, Stefan Bosch wrote:
> > 
> > > s5p4418-pinctrl.dtsi: Fix mmc bus definitions to fix "mmc write failed"
> > > e.g. when cmd saveenv is executed. Initialize all four GPIO of the
> > > mmc-buses instead of only the first one.
> > > 
> > > Signed-off-by: Stefan Bosch <stefan_b@posteo.net>
> > > ---
> > > 
> > >   arch/arm/dts/s5p4418-pinctrl.dtsi | 6 +++---
> > >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > Hey, I'm curious what it would take to move this to using OF_UPSTREAM,
> > where I assume this problem has already been fixed? Thanks!
> > 
> If I'm not mistaken, using OF_UPSTREAM is not possible because I think the
> s5p4418 SoC is not in the Linux kernel source tree and therefore also not in
> the devicetree-rebasing repo.

Ah. That would be higher bar to clear. OK, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]